[VOTE] Release Apache Flink 1.3.0 (RC3)
Locked
12
12
[VOTE] Release Apache Flink 1.3.0 (RC3)
 
|
Hi all,
this is the second VOTEing release candidate for Flink 1.3.0 The commit to be voted on: 760eea8a <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a> (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a>*) Branch: release-1.3.0-rc3 The release artifacts to be voted on can be found at: http://people.apache.org/~rmetzger/flink-1.3.0-rc3 The release artifacts are signed with the key with fingerprint D9839159: http://www.apache.org/dist/flink/KEYS The staging repository for this release can be found at: *https://repository.apache.org/content/repositories/orgapacheflink-1122 <https://repository.apache.org/content/repositories/orgapacheflink-1122>* ------------------------------------------------------------- The vote ends on Tuesday (May 30th), 7pm CET. [ ] +1 Release this package as Apache Flink 1.3.0 [ ] -1 Do not release this package, because ... |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
|
Hi Robert.
Will doc update be a blocker for release? Release 1.3 has many updates on tableAPI and SQL, and the docs are kind of lagging. We are trying the efforts to update the doc as much as possible before the release is officially published, but I am hoping this is not a blocker for the release. Shaoxuan On Sat, May 27, 2017 at 12:58 AM, Robert Metzger <[hidden email]> wrote: > Hi all, > > this is the second VOTEing release candidate for Flink 1.3.0 > > The commit to be voted on: > 760eea8a <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a> > (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a > <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a>*) > > Branch: > release-1.3.0-rc3 > > The release artifacts to be voted on can be found at: > http://people.apache.org/~rmetzger/flink-1.3.0-rc3 > > > The release artifacts are signed with the key with fingerprint D9839159: > http://www.apache.org/dist/flink/KEYS > > The staging repository for this release can be found at: > *https://repository.apache.org/content/repositories/orgapacheflink-1122 > <https://repository.apache.org/content/repositories/orgapacheflink-1122>* > > ------------------------------------------------------------- > > > The vote ends on Tuesday (May 30th), 7pm CET. > > [ ] +1 Release this package as Apache Flink 1.3.0 > [ ] -1 Do not release this package, because ... > |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
|
Hi!
I have found this issue: https://issues.apache.org/jira/browse/FLINK-6742 Not sure if it's a blocker or not (not even completely sure what causes it at the moment) Gyula Shaoxuan Wang <[hidden email]> ezt írta (időpont: 2017. máj. 27., Szo, 6:30): > Hi Robert. > Will doc update be a blocker for release? > Release 1.3 has many updates on tableAPI and SQL, and the docs are kind of > lagging. We are trying the efforts to update the doc as much as possible > before the release is officially published, but I am hoping this is not a > blocker for the release. > > Shaoxuan > > > > On Sat, May 27, 2017 at 12:58 AM, Robert Metzger <[hidden email]> > wrote: > > > Hi all, > > > > this is the second VOTEing release candidate for Flink 1.3.0 > > > > The commit to be voted on: > > 760eea8a <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a> > > (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a > > <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a>*) > > > > Branch: > > release-1.3.0-rc3 > > > > The release artifacts to be voted on can be found at: > > http://people.apache.org/~rmetzger/flink-1.3.0-rc3 > > > > > > The release artifacts are signed with the key with fingerprint D9839159: > > http://www.apache.org/dist/flink/KEYS > > > > The staging repository for this release can be found at: > > *https://repository.apache.org/content/repositories/orgapacheflink-1122 > > <https://repository.apache.org/content/repositories/orgapacheflink-1122 > >* > > > > ------------------------------------------------------------- > > > > > > The vote ends on Tuesday (May 30th), 7pm CET. > > > > [ ] +1 Release this package as Apache Flink 1.3.0 > > [ ] -1 Do not release this package, because ... > > > |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
|
I've responded in the JIRA. In my opinion isn't a functional issue, but
more about improving error messages/documentation. On 27.05.2017 18:07, Gyula Fóra wrote: > Hi! > I have found this issue: https://issues.apache.org/jira/browse/FLINK-6742 > > Not sure if it's a blocker or not (not even completely sure what causes it > at the moment) > > Gyula > > Shaoxuan Wang <[hidden email]> ezt írta (időpont: 2017. máj. 27., Szo, > 6:30): > >> Hi Robert. >> Will doc update be a blocker for release? >> Release 1.3 has many updates on tableAPI and SQL, and the docs are kind of >> lagging. We are trying the efforts to update the doc as much as possible >> before the release is officially published, but I am hoping this is not a >> blocker for the release. >> >> Shaoxuan >> >> >> >> On Sat, May 27, 2017 at 12:58 AM, Robert Metzger <[hidden email]> >> wrote: >> >>> Hi all, >>> >>> this is the second VOTEing release candidate for Flink 1.3.0 >>> >>> The commit to be voted on: >>> 760eea8a <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a> >>> (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a >>> <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a>*) >>> >>> Branch: >>> release-1.3.0-rc3 >>> >>> The release artifacts to be voted on can be found at: >>> http://people.apache.org/~rmetzger/flink-1.3.0-rc3 >>> >>> >>> The release artifacts are signed with the key with fingerprint D9839159: >>> http://www.apache.org/dist/flink/KEYS >>> >>> The staging repository for this release can be found at: >>> *https://repository.apache.org/content/repositories/orgapacheflink-1122 >>> <https://repository.apache.org/content/repositories/orgapacheflink-1122 >>> * >>> >>> ------------------------------------------------------------- >>> >>> >>> The vote ends on Tuesday (May 30th), 7pm CET. >>> >>> [ ] +1 Release this package as Apache Flink 1.3.0 >>> [ ] -1 Do not release this package, because ... >>> |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
|
@Shaoxuan, I don't think missing documentation is a release blocker, but
it's something we should fix asap and with high priority :) Since the documentation is not bundled with the release, and the docs are build off the "release-x.y" branch, we can always update them (even after the release). However, it makes sense to have the docs ready when we announce the release so that users can understand how to use the newly released features. On Sat, May 27, 2017 at 6:14 PM, Chesnay Schepler <[hidden email]> wrote: > I've responded in the JIRA. In my opinion isn't a functional issue, but > more about improving > error messages/documentation. > > > On 27.05.2017 18:07, Gyula Fóra wrote: > >> Hi! >> I have found this issue: https://issues.apache.org/jira/browse/FLINK-6742 >> >> Not sure if it's a blocker or not (not even completely sure what causes it >> at the moment) >> >> Gyula >> >> Shaoxuan Wang <[hidden email]> ezt írta (időpont: 2017. máj. 27., >> Szo, >> 6:30): >> >> Hi Robert. >>> Will doc update be a blocker for release? >>> Release 1.3 has many updates on tableAPI and SQL, and the docs are kind >>> of >>> lagging. We are trying the efforts to update the doc as much as possible >>> before the release is officially published, but I am hoping this is not a >>> blocker for the release. >>> >>> Shaoxuan >>> >>> >>> >>> On Sat, May 27, 2017 at 12:58 AM, Robert Metzger <[hidden email]> >>> wrote: >>> >>> Hi all, >>>> >>>> this is the second VOTEing release candidate for Flink 1.3.0 >>>> >>>> The commit to be voted on: >>>> 760eea8a <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a> >>>> (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a >>>> <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a>*) >>>> >>>> Branch: >>>> release-1.3.0-rc3 >>>> >>>> The release artifacts to be voted on can be found at: >>>> http://people.apache.org/~rmetzger/flink-1.3.0-rc3 >>>> >>>> >>>> The release artifacts are signed with the key with fingerprint D9839159: >>>> http://www.apache.org/dist/flink/KEYS >>>> >>>> The staging repository for this release can be found at: >>>> *https://repository.apache.org/content/repositories/orgapacheflink-1122 >>>> <https://repository.apache.org/content/repositories/orgapacheflink-1122 >>>> * >>>> >>>> ------------------------------------------------------------- >>>> >>>> >>>> The vote ends on Tuesday (May 30th), 7pm CET. >>>> >>>> [ ] +1 Release this package as Apache Flink 1.3.0 >>>> [ ] -1 Do not release this package, because ... >>>> >>>> > |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
|
+1
* Builds from source * start/stop scripts work * logs don't show anything suspicious on startup/shutdown * ran some example jobs * ran jobs on yarn with exactly-once & RocksDB o canceling with savepoint/resuming from savepoint o without/with rescaling * SideOutputs work * Metrics are properly transmitted & displayed in the webUI On 28.05.2017 20:33, Robert Metzger wrote: > @Shaoxuan, I don't think missing documentation is a release blocker, but > it's something we should fix asap and with high priority :) > Since the documentation is not bundled with the release, and the docs are > build off the "release-x.y" branch, we can always update them (even after > the release). > > However, it makes sense to have the docs ready when we announce the release > so that users can understand how to use the newly released features. > > On Sat, May 27, 2017 at 6:14 PM, Chesnay Schepler <[hidden email]> > wrote: > >> I've responded in the JIRA. In my opinion isn't a functional issue, but >> more about improving >> error messages/documentation. >> >> >> On 27.05.2017 18:07, Gyula Fóra wrote: >> >>> Hi! >>> I have found this issue: https://issues.apache.org/jira/browse/FLINK-6742 >>> >>> Not sure if it's a blocker or not (not even completely sure what causes it >>> at the moment) >>> >>> Gyula >>> >>> Shaoxuan Wang <[hidden email]> ezt írta (időpont: 2017. máj. 27., >>> Szo, >>> 6:30): >>> >>> Hi Robert. >>>> Will doc update be a blocker for release? >>>> Release 1.3 has many updates on tableAPI and SQL, and the docs are kind >>>> of >>>> lagging. We are trying the efforts to update the doc as much as possible >>>> before the release is officially published, but I am hoping this is not a >>>> blocker for the release. >>>> >>>> Shaoxuan >>>> >>>> >>>> >>>> On Sat, May 27, 2017 at 12:58 AM, Robert Metzger <[hidden email]> >>>> wrote: >>>> >>>> Hi all, >>>>> this is the second VOTEing release candidate for Flink 1.3.0 >>>>> >>>>> The commit to be voted on: >>>>> 760eea8a <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a> >>>>> (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a >>>>> <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a>*) >>>>> >>>>> Branch: >>>>> release-1.3.0-rc3 >>>>> >>>>> The release artifacts to be voted on can be found at: >>>>> http://people.apache.org/~rmetzger/flink-1.3.0-rc3 >>>>> >>>>> >>>>> The release artifacts are signed with the key with fingerprint D9839159: >>>>> http://www.apache.org/dist/flink/KEYS >>>>> >>>>> The staging repository for this release can be found at: >>>>> *https://repository.apache.org/content/repositories/orgapacheflink-1122 >>>>> <https://repository.apache.org/content/repositories/orgapacheflink-1122 >>>>> * >>>>> >>>>> ------------------------------------------------------------- >>>>> >>>>> >>>>> The vote ends on Tuesday (May 30th), 7pm CET. >>>>> >>>>> [ ] +1 Release this package as Apache Flink 1.3.0 >>>>> [ ] -1 Do not release this package, because ... >>>>> >>>>> |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
|
+1 to release:
- Tested building job against staging repository - tested YARN session start and container recovery on YARN - Validated HA on YARN (per job and session mode) - Incremental checkpointing with rocksdb works - FsStatebackend with async snapshots works - Flink builds from source on Linux (includes rat license header check) - source doesn't contain binaries - checked md5 / sha512 sum of source archive (assuming the other sums are valid as well) I noticed one minor thing: the copyright in the NOTICE file is 2014-2016. I'll update it on master and the release branch. On Mon, May 29, 2017 at 12:42 PM, Chesnay Schepler <[hidden email]> wrote: > +1 > > * Builds from source > * start/stop scripts work > * logs don't show anything suspicious on startup/shutdown > * ran some example jobs > * ran jobs on yarn with exactly-once & RocksDB > o canceling with savepoint/resuming from savepoint > o without/with rescaling > * SideOutputs work > * Metrics are properly transmitted & displayed in the webUI > > > On 28.05.2017 20:33, Robert Metzger wrote: > >> @Shaoxuan, I don't think missing documentation is a release blocker, but >> it's something we should fix asap and with high priority :) >> Since the documentation is not bundled with the release, and the docs are >> build off the "release-x.y" branch, we can always update them (even after >> the release). >> >> However, it makes sense to have the docs ready when we announce the >> release >> so that users can understand how to use the newly released features. >> >> On Sat, May 27, 2017 at 6:14 PM, Chesnay Schepler <[hidden email]> >> wrote: >> >> I've responded in the JIRA. In my opinion isn't a functional issue, but >>> more about improving >>> error messages/documentation. >>> >>> >>> On 27.05.2017 18:07, Gyula Fóra wrote: >>> >>> Hi! >>>> I have found this issue: https://issues.apache.org/jira >>>> /browse/FLINK-6742 >>>> >>>> Not sure if it's a blocker or not (not even completely sure what causes >>>> it >>>> at the moment) >>>> >>>> Gyula >>>> >>>> Shaoxuan Wang <[hidden email]> ezt írta (időpont: 2017. máj. 27., >>>> Szo, >>>> 6:30): >>>> >>>> Hi Robert. >>>> >>>>> Will doc update be a blocker for release? >>>>> Release 1.3 has many updates on tableAPI and SQL, and the docs are kind >>>>> of >>>>> lagging. We are trying the efforts to update the doc as much as >>>>> possible >>>>> before the release is officially published, but I am hoping this is >>>>> not a >>>>> blocker for the release. >>>>> >>>>> Shaoxuan >>>>> >>>>> >>>>> >>>>> On Sat, May 27, 2017 at 12:58 AM, Robert Metzger <[hidden email]> >>>>> wrote: >>>>> >>>>> Hi all, >>>>> >>>>>> this is the second VOTEing release candidate for Flink 1.3.0 >>>>>> >>>>>> The commit to be voted on: >>>>>> 760eea8a <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8 >>>>>> a> >>>>>> (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a >>>>>> <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a>*) >>>>>> >>>>>> Branch: >>>>>> release-1.3.0-rc3 >>>>>> >>>>>> The release artifacts to be voted on can be found at: >>>>>> http://people.apache.org/~rmetzger/flink-1.3.0-rc3 >>>>>> >>>>>> >>>>>> The release artifacts are signed with the key with fingerprint >>>>>> D9839159: >>>>>> http://www.apache.org/dist/flink/KEYS >>>>>> >>>>>> The staging repository for this release can be found at: >>>>>> *https://repository.apache.org/content/repositories/orgapach >>>>>> eflink-1122 >>>>>> <https://repository.apache.org/content/repositories/orgapach >>>>>> eflink-1122 >>>>>> * >>>>>> >>>>>> ------------------------------------------------------------- >>>>>> >>>>>> >>>>>> The vote ends on Tuesday (May 30th), 7pm CET. >>>>>> >>>>>> [ ] +1 Release this package as Apache Flink 1.3.0 >>>>>> [ ] -1 Do not release this package, because ... >>>>>> >>>>>> >>>>>> > |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
|
Hi,
I have found an issue with rescaling incremental checkpoints: https://issues.apache.org/jira/browse/FLINK-6762 I am not sure if this is regarded as a blocker, it depends on our assumptions about externalized checkpoints. What do you think? Cheers, Gyula Robert Metzger <[hidden email]> ezt írta (időpont: 2017. máj. 29., H, 15:59): > +1 to release: > > - Tested building job against staging repository > - tested YARN session start and container recovery on YARN > - Validated HA on YARN (per job and session mode) > - Incremental checkpointing with rocksdb works > - FsStatebackend with async snapshots works > > - Flink builds from source on Linux (includes rat license header check) > - source doesn't contain binaries > - checked md5 / sha512 sum of source archive (assuming the other sums are > valid as well) > > > I noticed one minor thing: the copyright in the NOTICE file is 2014-2016. > I'll update it on master and the release branch. > > > On Mon, May 29, 2017 at 12:42 PM, Chesnay Schepler <[hidden email]> > wrote: > > > +1 > > > > * Builds from source > > * start/stop scripts work > > * logs don't show anything suspicious on startup/shutdown > > * ran some example jobs > > * ran jobs on yarn with exactly-once & RocksDB > > o canceling with savepoint/resuming from savepoint > > o without/with rescaling > > * SideOutputs work > > * Metrics are properly transmitted & displayed in the webUI > > > > > > On 28.05.2017 20:33, Robert Metzger wrote: > > > >> @Shaoxuan, I don't think missing documentation is a release blocker, but > >> it's something we should fix asap and with high priority :) > >> Since the documentation is not bundled with the release, and the docs > are > >> build off the "release-x.y" branch, we can always update them (even > after > >> the release). > >> > >> However, it makes sense to have the docs ready when we announce the > >> release > >> so that users can understand how to use the newly released features. > >> > >> On Sat, May 27, 2017 at 6:14 PM, Chesnay Schepler <[hidden email]> > >> wrote: > >> > >> I've responded in the JIRA. In my opinion isn't a functional issue, but > >>> more about improving > >>> error messages/documentation. > >>> > >>> > >>> On 27.05.2017 18:07, Gyula Fóra wrote: > >>> > >>> Hi! > >>>> I have found this issue: https://issues.apache.org/jira > >>>> /browse/FLINK-6742 > >>>> > >>>> Not sure if it's a blocker or not (not even completely sure what > causes > >>>> it > >>>> at the moment) > >>>> > >>>> Gyula > >>>> > >>>> Shaoxuan Wang <[hidden email]> ezt írta (időpont: 2017. máj. > 27., > >>>> Szo, > >>>> 6:30): > >>>> > >>>> Hi Robert. > >>>> > >>>>> Will doc update be a blocker for release? > >>>>> Release 1.3 has many updates on tableAPI and SQL, and the docs are > kind > >>>>> of > >>>>> lagging. We are trying the efforts to update the doc as much as > >>>>> possible > >>>>> before the release is officially published, but I am hoping this is > >>>>> not a > >>>>> blocker for the release. > >>>>> > >>>>> Shaoxuan > >>>>> > >>>>> > >>>>> > >>>>> On Sat, May 27, 2017 at 12:58 AM, Robert Metzger < > [hidden email]> > >>>>> wrote: > >>>>> > >>>>> Hi all, > >>>>> > >>>>>> this is the second VOTEing release candidate for Flink 1.3.0 > >>>>>> > >>>>>> The commit to be voted on: > >>>>>> 760eea8a < > http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8 > >>>>>> a> > >>>>>> (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a > >>>>>> <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a>*) > >>>>>> > >>>>>> Branch: > >>>>>> release-1.3.0-rc3 > >>>>>> > >>>>>> The release artifacts to be voted on can be found at: > >>>>>> http://people.apache.org/~rmetzger/flink-1.3.0-rc3 > >>>>>> > >>>>>> > >>>>>> The release artifacts are signed with the key with fingerprint > >>>>>> D9839159: > >>>>>> http://www.apache.org/dist/flink/KEYS > >>>>>> > >>>>>> The staging repository for this release can be found at: > >>>>>> *https://repository.apache.org/content/repositories/orgapach > >>>>>> eflink-1122 > >>>>>> <https://repository.apache.org/content/repositories/orgapach > >>>>>> eflink-1122 > >>>>>> * > >>>>>> > >>>>>> ------------------------------------------------------------- > >>>>>> > >>>>>> > >>>>>> The vote ends on Tuesday (May 30th), 7pm CET. > >>>>>> > >>>>>> [ ] +1 Release this package as Apache Flink 1.3.0 > >>>>>> [ ] -1 Do not release this package, because ... > >>>>>> > >>>>>> > >>>>>> > > > |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
|
Hi,
officially, we currently do not want to support rescaling from (incremental) checkpoints, but only from savepoints. For this reason, I would not consider this a blocking issue. Unofficially, I think we are not too far away from supporting this, but there is a question mark behind the efficiency. The procedure will involve redundant data shuffling and reconstruction efforts because incremental checkpoints cannot track key-groups. Best, Stefan > Am 29.05.2017 um 16:57 schrieb Gyula Fóra <[hidden email]>: > > Hi, > > I have found an issue with rescaling incremental checkpoints: > https://issues.apache.org/jira/browse/FLINK-6762 > > I am not sure if this is regarded as a blocker, it depends on our > assumptions about externalized checkpoints. > > What do you think? > > Cheers, > Gyula > > Robert Metzger <[hidden email]> ezt írta (időpont: 2017. máj. 29., H, > 15:59): > >> +1 to release: >> >> - Tested building job against staging repository >> - tested YARN session start and container recovery on YARN >> - Validated HA on YARN (per job and session mode) >> - Incremental checkpointing with rocksdb works >> - FsStatebackend with async snapshots works >> >> - Flink builds from source on Linux (includes rat license header check) >> - source doesn't contain binaries >> - checked md5 / sha512 sum of source archive (assuming the other sums are >> valid as well) >> >> >> I noticed one minor thing: the copyright in the NOTICE file is 2014-2016. >> I'll update it on master and the release branch. >> >> >> On Mon, May 29, 2017 at 12:42 PM, Chesnay Schepler <[hidden email]> >> wrote: >> >>> +1 >>> >>> * Builds from source >>> * start/stop scripts work >>> * logs don't show anything suspicious on startup/shutdown >>> * ran some example jobs >>> * ran jobs on yarn with exactly-once & RocksDB >>> o canceling with savepoint/resuming from savepoint >>> o without/with rescaling >>> * SideOutputs work >>> * Metrics are properly transmitted & displayed in the webUI >>> >>> >>> On 28.05.2017 20:33, Robert Metzger wrote: >>> >>>> @Shaoxuan, I don't think missing documentation is a release blocker, but >>>> it's something we should fix asap and with high priority :) >>>> Since the documentation is not bundled with the release, and the docs >> are >>>> build off the "release-x.y" branch, we can always update them (even >> after >>>> the release). >>>> >>>> However, it makes sense to have the docs ready when we announce the >>>> release >>>> so that users can understand how to use the newly released features. >>>> >>>> On Sat, May 27, 2017 at 6:14 PM, Chesnay Schepler <[hidden email]> >>>> wrote: >>>> >>>> I've responded in the JIRA. In my opinion isn't a functional issue, but >>>>> more about improving >>>>> error messages/documentation. >>>>> >>>>> >>>>> On 27.05.2017 18:07, Gyula Fóra wrote: >>>>> >>>>> Hi! >>>>>> I have found this issue: https://issues.apache.org/jira >>>>>> /browse/FLINK-6742 >>>>>> >>>>>> Not sure if it's a blocker or not (not even completely sure what >> causes >>>>>> it >>>>>> at the moment) >>>>>> >>>>>> Gyula >>>>>> >>>>>> Shaoxuan Wang <[hidden email]> ezt írta (időpont: 2017. máj. >> 27., >>>>>> Szo, >>>>>> 6:30): >>>>>> >>>>>> Hi Robert. >>>>>> >>>>>>> Will doc update be a blocker for release? >>>>>>> Release 1.3 has many updates on tableAPI and SQL, and the docs are >> kind >>>>>>> of >>>>>>> lagging. We are trying the efforts to update the doc as much as >>>>>>> possible >>>>>>> before the release is officially published, but I am hoping this is >>>>>>> not a >>>>>>> blocker for the release. >>>>>>> >>>>>>> Shaoxuan >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Sat, May 27, 2017 at 12:58 AM, Robert Metzger < >> [hidden email]> >>>>>>> wrote: >>>>>>> >>>>>>> Hi all, >>>>>>> >>>>>>>> this is the second VOTEing release candidate for Flink 1.3.0 >>>>>>>> >>>>>>>> The commit to be voted on: >>>>>>>> 760eea8a < >> http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8 >>>>>>>> a> >>>>>>>> (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a >>>>>>>> <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a>*) >>>>>>>> >>>>>>>> Branch: >>>>>>>> release-1.3.0-rc3 >>>>>>>> >>>>>>>> The release artifacts to be voted on can be found at: >>>>>>>> http://people.apache.org/~rmetzger/flink-1.3.0-rc3 >>>>>>>> >>>>>>>> >>>>>>>> The release artifacts are signed with the key with fingerprint >>>>>>>> D9839159: >>>>>>>> http://www.apache.org/dist/flink/KEYS >>>>>>>> >>>>>>>> The staging repository for this release can be found at: >>>>>>>> *https://repository.apache.org/content/repositories/orgapach >>>>>>>> eflink-1122 >>>>>>>> <https://repository.apache.org/content/repositories/orgapach >>>>>>>> eflink-1122 >>>>>>>> * >>>>>>>> >>>>>>>> ------------------------------------------------------------- >>>>>>>> >>>>>>>> >>>>>>>> The vote ends on Tuesday (May 30th), 7pm CET. >>>>>>>> >>>>>>>> [ ] +1 Release this package as Apache Flink 1.3.0 >>>>>>>> [ ] -1 Do not release this package, because ... >>>>>>>> >>>>>>>> >>>>>>>> >>> >> |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
|
In reply to this post by Gyula Fóra
Hi Robert,
+1 to release: Check items have been checked, as follows: (flink-table) 1.Check that the JAVA and SCALA logical plans are consistent. 2.Check that the SQL and Table API logical plans are consistent. 3.Check that UDF, UDTF, and UDAF are working properly in group-windows and over-windows. 4.Check that all built-in Agg on Batch and Stream are working properly. 5.Let types such as Timestamp, BigDecimal or Pojo flow through UDF. UDTF, UDAF (input and output types). Cheers, SunJincheng 2017-05-29 22:57 GMT+08:00 Gyula Fóra <[hidden email]>: > Hi, > > I have found an issue with rescaling incremental checkpoints: > https://issues.apache.org/jira/browse/FLINK-6762 > > I am not sure if this is regarded as a blocker, it depends on our > assumptions about externalized checkpoints. > > What do you think? > > Cheers, > Gyula > > Robert Metzger <[hidden email]> ezt írta (időpont: 2017. máj. 29., H, > 15:59): > > > +1 to release: > > > > - Tested building job against staging repository > > - tested YARN session start and container recovery on YARN > > - Validated HA on YARN (per job and session mode) > > - Incremental checkpointing with rocksdb works > > - FsStatebackend with async snapshots works > > > > - Flink builds from source on Linux (includes rat license header check) > > - source doesn't contain binaries > > - checked md5 / sha512 sum of source archive (assuming the other sums are > > valid as well) > > > > > > I noticed one minor thing: the copyright in the NOTICE file is 2014-2016. > > I'll update it on master and the release branch. > > > > > > On Mon, May 29, 2017 at 12:42 PM, Chesnay Schepler <[hidden email]> > > wrote: > > > > > +1 > > > > > > * Builds from source > > > * start/stop scripts work > > > * logs don't show anything suspicious on startup/shutdown > > > * ran some example jobs > > > * ran jobs on yarn with exactly-once & RocksDB > > > o canceling with savepoint/resuming from savepoint > > > o without/with rescaling > > > * SideOutputs work > > > * Metrics are properly transmitted & displayed in the webUI > > > > > > > > > On 28.05.2017 20:33, Robert Metzger wrote: > > > > > >> @Shaoxuan, I don't think missing documentation is a release blocker, > but > > >> it's something we should fix asap and with high priority :) > > >> Since the documentation is not bundled with the release, and the docs > > are > > >> build off the "release-x.y" branch, we can always update them (even > > after > > >> the release). > > >> > > >> However, it makes sense to have the docs ready when we announce the > > >> release > > >> so that users can understand how to use the newly released features. > > >> > > >> On Sat, May 27, 2017 at 6:14 PM, Chesnay Schepler <[hidden email] > > > > >> wrote: > > >> > > >> I've responded in the JIRA. In my opinion isn't a functional issue, > but > > >>> more about improving > > >>> error messages/documentation. > > >>> > > >>> > > >>> On 27.05.2017 18:07, Gyula Fóra wrote: > > >>> > > >>> Hi! > > >>>> I have found this issue: https://issues.apache.org/jira > > >>>> /browse/FLINK-6742 > > >>>> > > >>>> Not sure if it's a blocker or not (not even completely sure what > > causes > > >>>> it > > >>>> at the moment) > > >>>> > > >>>> Gyula > > >>>> > > >>>> Shaoxuan Wang <[hidden email]> ezt írta (időpont: 2017. máj. > > 27., > > >>>> Szo, > > >>>> 6:30): > > >>>> > > >>>> Hi Robert. > > >>>> > > >>>>> Will doc update be a blocker for release? > > >>>>> Release 1.3 has many updates on tableAPI and SQL, and the docs are > > kind > > >>>>> of > > >>>>> lagging. We are trying the efforts to update the doc as much as > > >>>>> possible > > >>>>> before the release is officially published, but I am hoping this is > > >>>>> not a > > >>>>> blocker for the release. > > >>>>> > > >>>>> Shaoxuan > > >>>>> > > >>>>> > > >>>>> > > >>>>> On Sat, May 27, 2017 at 12:58 AM, Robert Metzger < > > [hidden email]> > > >>>>> wrote: > > >>>>> > > >>>>> Hi all, > > >>>>> > > >>>>>> this is the second VOTEing release candidate for Flink 1.3.0 > > >>>>>> > > >>>>>> The commit to be voted on: > > >>>>>> 760eea8a < > > http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8 > > >>>>>> a> > > >>>>>> (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a > > >>>>>> <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a>*) > > >>>>>> > > >>>>>> Branch: > > >>>>>> release-1.3.0-rc3 > > >>>>>> > > >>>>>> The release artifacts to be voted on can be found at: > > >>>>>> http://people.apache.org/~rmetzger/flink-1.3.0-rc3 > > >>>>>> > > >>>>>> > > >>>>>> The release artifacts are signed with the key with fingerprint > > >>>>>> D9839159: > > >>>>>> http://www.apache.org/dist/flink/KEYS > > >>>>>> > > >>>>>> The staging repository for this release can be found at: > > >>>>>> *https://repository.apache.org/content/repositories/orgapach > > >>>>>> eflink-1122 > > >>>>>> <https://repository.apache.org/content/repositories/orgapach > > >>>>>> eflink-1122 > > >>>>>> * > > >>>>>> > > >>>>>> ------------------------------------------------------------- > > >>>>>> > > >>>>>> > > >>>>>> The vote ends on Tuesday (May 30th), 7pm CET. > > >>>>>> > > >>>>>> [ ] +1 Release this package as Apache Flink 1.3.0 > > >>>>>> [ ] -1 Do not release this package, because ... > > >>>>>> > > >>>>>> > > >>>>>> > > > > > > |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
|
Thank you all for the +1 votes so far.
As far as I see it, none of the issues mentioned in the thread are blockers. I've started putting together the blog post for the release announcement. It is ready to review here: https://github.com/apache/flink-web/pull/62 On Mon, May 29, 2017 at 5:16 PM, jincheng sun <[hidden email]> wrote: > Hi Robert, > > +1 to release: > > Check items have been checked, as follows: (flink-table) > > 1.Check that the JAVA and SCALA logical plans are consistent. > 2.Check that the SQL and Table API logical plans are consistent. > 3.Check that UDF, UDTF, and UDAF are working properly in group-windows and > over-windows. > 4.Check that all built-in Agg on Batch and Stream are working properly. > 5.Let types such as Timestamp, BigDecimal or Pojo flow through UDF. UDTF, > UDAF (input and output types). > > Cheers, > SunJincheng > > > 2017-05-29 22:57 GMT+08:00 Gyula Fóra <[hidden email]>: > > > Hi, > > > > I have found an issue with rescaling incremental checkpoints: > > https://issues.apache.org/jira/browse/FLINK-6762 > > > > I am not sure if this is regarded as a blocker, it depends on our > > assumptions about externalized checkpoints. > > > > What do you think? > > > > Cheers, > > Gyula > > > > Robert Metzger <[hidden email]> ezt írta (időpont: 2017. máj. 29., > H, > > 15:59): > > > > > +1 to release: > > > > > > - Tested building job against staging repository > > > - tested YARN session start and container recovery on YARN > > > - Validated HA on YARN (per job and session mode) > > > - Incremental checkpointing with rocksdb works > > > - FsStatebackend with async snapshots works > > > > > > - Flink builds from source on Linux (includes rat license header check) > > > - source doesn't contain binaries > > > - checked md5 / sha512 sum of source archive (assuming the other sums > are > > > valid as well) > > > > > > > > > I noticed one minor thing: the copyright in the NOTICE file is > 2014-2016. > > > I'll update it on master and the release branch. > > > > > > > > > On Mon, May 29, 2017 at 12:42 PM, Chesnay Schepler <[hidden email] > > > > > wrote: > > > > > > > +1 > > > > > > > > * Builds from source > > > > * start/stop scripts work > > > > * logs don't show anything suspicious on startup/shutdown > > > > * ran some example jobs > > > > * ran jobs on yarn with exactly-once & RocksDB > > > > o canceling with savepoint/resuming from savepoint > > > > o without/with rescaling > > > > * SideOutputs work > > > > * Metrics are properly transmitted & displayed in the webUI > > > > > > > > > > > > On 28.05.2017 20:33, Robert Metzger wrote: > > > > > > > >> @Shaoxuan, I don't think missing documentation is a release blocker, > > but > > > >> it's something we should fix asap and with high priority :) > > > >> Since the documentation is not bundled with the release, and the > docs > > > are > > > >> build off the "release-x.y" branch, we can always update them (even > > > after > > > >> the release). > > > >> > > > >> However, it makes sense to have the docs ready when we announce the > > > >> release > > > >> so that users can understand how to use the newly released features. > > > >> > > > >> On Sat, May 27, 2017 at 6:14 PM, Chesnay Schepler < > [hidden email] > > > > > > >> wrote: > > > >> > > > >> I've responded in the JIRA. In my opinion isn't a functional issue, > > but > > > >>> more about improving > > > >>> error messages/documentation. > > > >>> > > > >>> > > > >>> On 27.05.2017 18:07, Gyula Fóra wrote: > > > >>> > > > >>> Hi! > > > >>>> I have found this issue: https://issues.apache.org/jira > > > >>>> /browse/FLINK-6742 > > > >>>> > > > >>>> Not sure if it's a blocker or not (not even completely sure what > > > causes > > > >>>> it > > > >>>> at the moment) > > > >>>> > > > >>>> Gyula > > > >>>> > > > >>>> Shaoxuan Wang <[hidden email]> ezt írta (időpont: 2017. máj. > > > 27., > > > >>>> Szo, > > > >>>> 6:30): > > > >>>> > > > >>>> Hi Robert. > > > >>>> > > > >>>>> Will doc update be a blocker for release? > > > >>>>> Release 1.3 has many updates on tableAPI and SQL, and the docs > are > > > kind > > > >>>>> of > > > >>>>> lagging. We are trying the efforts to update the doc as much as > > > >>>>> possible > > > >>>>> before the release is officially published, but I am hoping this > is > > > >>>>> not a > > > >>>>> blocker for the release. > > > >>>>> > > > >>>>> Shaoxuan > > > >>>>> > > > >>>>> > > > >>>>> > > > >>>>> On Sat, May 27, 2017 at 12:58 AM, Robert Metzger < > > > [hidden email]> > > > >>>>> wrote: > > > >>>>> > > > >>>>> Hi all, > > > >>>>> > > > >>>>>> this is the second VOTEing release candidate for Flink 1.3.0 > > > >>>>>> > > > >>>>>> The commit to be voted on: > > > >>>>>> 760eea8a < > > > http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8 > > > >>>>>> a> > > > >>>>>> (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a > > > >>>>>> <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a > >*) > > > >>>>>> > > > >>>>>> Branch: > > > >>>>>> release-1.3.0-rc3 > > > >>>>>> > > > >>>>>> The release artifacts to be voted on can be found at: > > > >>>>>> http://people.apache.org/~rmetzger/flink-1.3.0-rc3 > > > >>>>>> > > > >>>>>> > > > >>>>>> The release artifacts are signed with the key with fingerprint > > > >>>>>> D9839159: > > > >>>>>> http://www.apache.org/dist/flink/KEYS > > > >>>>>> > > > >>>>>> The staging repository for this release can be found at: > > > >>>>>> *https://repository.apache.org/content/repositories/orgapach > > > >>>>>> eflink-1122 > > > >>>>>> <https://repository.apache.org/content/repositories/orgapach > > > >>>>>> eflink-1122 > > > >>>>>> * > > > >>>>>> > > > >>>>>> ------------------------------------------------------------- > > > >>>>>> > > > >>>>>> > > > >>>>>> The vote ends on Tuesday (May 30th), 7pm CET. > > > >>>>>> > > > >>>>>> [ ] +1 Release this package as Apache Flink 1.3.0 > > > >>>>>> [ ] -1 Do not release this package, because ... > > > >>>>>> > > > >>>>>> > > > >>>>>> > > > > > > > > > > |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
|
+1
I did: - manually check the release using the new end-to-end tests: https://github.com/apache/flink/pull/3911 <https://github.com/apache/flink/pull/3911>. - verify that the source builds - Check the (transitive) dependencies of flink-dist compared to 1.2.x. The new deps are: com.squareup.okio (ASL), com.squareup.okhttp3 (ASL) (due to shading this does not catch all dependencies, though) > On 30. May 2017, at 10:58, Robert Metzger <[hidden email]> wrote: > > Thank you all for the +1 votes so far. > > As far as I see it, none of the issues mentioned in the thread are blockers. > > I've started putting together the blog post for the release announcement. > It is ready to review here: https://github.com/apache/flink-web/pull/62 > > On Mon, May 29, 2017 at 5:16 PM, jincheng sun <[hidden email]> > wrote: > >> Hi Robert, >> >> +1 to release: >> >> Check items have been checked, as follows: (flink-table) >> >> 1.Check that the JAVA and SCALA logical plans are consistent. >> 2.Check that the SQL and Table API logical plans are consistent. >> 3.Check that UDF, UDTF, and UDAF are working properly in group-windows and >> over-windows. >> 4.Check that all built-in Agg on Batch and Stream are working properly. >> 5.Let types such as Timestamp, BigDecimal or Pojo flow through UDF. UDTF, >> UDAF (input and output types). >> >> Cheers, >> SunJincheng >> >> >> 2017-05-29 22:57 GMT+08:00 Gyula Fóra <[hidden email]>: >> >>> Hi, >>> >>> I have found an issue with rescaling incremental checkpoints: >>> https://issues.apache.org/jira/browse/FLINK-6762 >>> >>> I am not sure if this is regarded as a blocker, it depends on our >>> assumptions about externalized checkpoints. >>> >>> What do you think? >>> >>> Cheers, >>> Gyula >>> >>> Robert Metzger <[hidden email]> ezt írta (időpont: 2017. máj. 29., >> H, >>> 15:59): >>> >>>> +1 to release: >>>> >>>> - Tested building job against staging repository >>>> - tested YARN session start and container recovery on YARN >>>> - Validated HA on YARN (per job and session mode) >>>> - Incremental checkpointing with rocksdb works >>>> - FsStatebackend with async snapshots works >>>> >>>> - Flink builds from source on Linux (includes rat license header check) >>>> - source doesn't contain binaries >>>> - checked md5 / sha512 sum of source archive (assuming the other sums >> are >>>> valid as well) >>>> >>>> >>>> I noticed one minor thing: the copyright in the NOTICE file is >> 2014-2016. >>>> I'll update it on master and the release branch. >>>> >>>> >>>> On Mon, May 29, 2017 at 12:42 PM, Chesnay Schepler <[hidden email] >>> >>>> wrote: >>>> >>>>> +1 >>>>> >>>>> * Builds from source >>>>> * start/stop scripts work >>>>> * logs don't show anything suspicious on startup/shutdown >>>>> * ran some example jobs >>>>> * ran jobs on yarn with exactly-once & RocksDB >>>>> o canceling with savepoint/resuming from savepoint >>>>> o without/with rescaling >>>>> * SideOutputs work >>>>> * Metrics are properly transmitted & displayed in the webUI >>>>> >>>>> >>>>> On 28.05.2017 20:33, Robert Metzger wrote: >>>>> >>>>>> @Shaoxuan, I don't think missing documentation is a release blocker, >>> but >>>>>> it's something we should fix asap and with high priority :) >>>>>> Since the documentation is not bundled with the release, and the >> docs >>>> are >>>>>> build off the "release-x.y" branch, we can always update them (even >>>> after >>>>>> the release). >>>>>> >>>>>> However, it makes sense to have the docs ready when we announce the >>>>>> release >>>>>> so that users can understand how to use the newly released features. >>>>>> >>>>>> On Sat, May 27, 2017 at 6:14 PM, Chesnay Schepler < >> [hidden email] >>>> >>>>>> wrote: >>>>>> >>>>>> I've responded in the JIRA. In my opinion isn't a functional issue, >>> but >>>>>>> more about improving >>>>>>> error messages/documentation. >>>>>>> >>>>>>> >>>>>>> On 27.05.2017 18:07, Gyula Fóra wrote: >>>>>>> >>>>>>> Hi! >>>>>>>> I have found this issue: https://issues.apache.org/jira >>>>>>>> /browse/FLINK-6742 >>>>>>>> >>>>>>>> Not sure if it's a blocker or not (not even completely sure what >>>> causes >>>>>>>> it >>>>>>>> at the moment) >>>>>>>> >>>>>>>> Gyula >>>>>>>> >>>>>>>> Shaoxuan Wang <[hidden email]> ezt írta (időpont: 2017. máj. >>>> 27., >>>>>>>> Szo, >>>>>>>> 6:30): >>>>>>>> >>>>>>>> Hi Robert. >>>>>>>> >>>>>>>>> Will doc update be a blocker for release? >>>>>>>>> Release 1.3 has many updates on tableAPI and SQL, and the docs >> are >>>> kind >>>>>>>>> of >>>>>>>>> lagging. We are trying the efforts to update the doc as much as >>>>>>>>> possible >>>>>>>>> before the release is officially published, but I am hoping this >> is >>>>>>>>> not a >>>>>>>>> blocker for the release. >>>>>>>>> >>>>>>>>> Shaoxuan >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Sat, May 27, 2017 at 12:58 AM, Robert Metzger < >>>> [hidden email]> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>> Hi all, >>>>>>>>> >>>>>>>>>> this is the second VOTEing release candidate for Flink 1.3.0 >>>>>>>>>> >>>>>>>>>> The commit to be voted on: >>>>>>>>>> 760eea8a < >>>> http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8 >>>>>>>>>> a> >>>>>>>>>> (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a >>>>>>>>>> <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a >>> *) >>>>>>>>>> >>>>>>>>>> Branch: >>>>>>>>>> release-1.3.0-rc3 >>>>>>>>>> >>>>>>>>>> The release artifacts to be voted on can be found at: >>>>>>>>>> http://people.apache.org/~rmetzger/flink-1.3.0-rc3 >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> The release artifacts are signed with the key with fingerprint >>>>>>>>>> D9839159: >>>>>>>>>> http://www.apache.org/dist/flink/KEYS >>>>>>>>>> >>>>>>>>>> The staging repository for this release can be found at: >>>>>>>>>> *https://repository.apache.org/content/repositories/orgapach >>>>>>>>>> eflink-1122 >>>>>>>>>> <https://repository.apache.org/content/repositories/orgapach >>>>>>>>>> eflink-1122 >>>>>>>>>> * >>>>>>>>>> >>>>>>>>>> ------------------------------------------------------------- >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> The vote ends on Tuesday (May 30th), 7pm CET. >>>>>>>>>> >>>>>>>>>> [ ] +1 Release this package as Apache Flink 1.3.0 >>>>>>>>>> [ ] -1 Do not release this package, because ... >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>> >>>> >>> >> |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
|
+1
Tests I did: New features: - Tested rescaling Kinesis Consumer + transparent shard discovery - Tested topology changes on restore: changed chain orderings, added stateful / stateless operators, remove stateful / stateless operators - Tested new Flink CEP features: loop states, quantifiers, NOT states, timeout handling - Tested min / max network buffer size auto configuration Checks on previous features / behavior: - Kerberos authentication for Zookeeper, HDFS, Kafka, YARN - Flink’s Kerberos authentication works nicely with MapR’s security - Tested Flink on Mesos - Tested backwards compatibility against Flink 1.2.1: empty 1.2 state, large 1.2 state, rescaled after the restore in 1.3 - Tested HA with YARN session mode + YARN cluster mode, works and no staged files dangling - Ran random simple jobs with Kafka as source and sink + checkpoint in standalone / YARN session / per-job YARN On 30 May 2017 at 11:39:14 AM, Aljoscha Krettek ([hidden email]) wrote: +1 I did: - manually check the release using the new end-to-end tests: https://github.com/apache/flink/pull/3911 <https://github.com/apache/flink/pull/3911>. - verify that the source builds - Check the (transitive) dependencies of flink-dist compared to 1.2.x. The new deps are: com.squareup.okio (ASL), com.squareup.okhttp3 (ASL) (due to shading this does not catch all dependencies, though) > On 30. May 2017, at 10:58, Robert Metzger <[hidden email]> wrote: > > Thank you all for the +1 votes so far. > > As far as I see it, none of the issues mentioned in the thread are blockers. > > I've started putting together the blog post for the release announcement. > It is ready to review here: https://github.com/apache/flink-web/pull/62 > > On Mon, May 29, 2017 at 5:16 PM, jincheng sun <[hidden email]> > wrote: > >> Hi Robert, >> >> +1 to release: >> >> Check items have been checked, as follows: (flink-table) >> >> 1.Check that the JAVA and SCALA logical plans are consistent. >> 2.Check that the SQL and Table API logical plans are consistent. >> 3.Check that UDF, UDTF, and UDAF are working properly in group-windows and >> over-windows. >> 4.Check that all built-in Agg on Batch and Stream are working properly. >> 5.Let types such as Timestamp, BigDecimal or Pojo flow through UDF. UDTF, >> UDAF (input and output types). >> >> Cheers, >> SunJincheng >> >> >> 2017-05-29 22:57 GMT+08:00 Gyula Fóra <[hidden email]>: >> >>> Hi, >>> >>> I have found an issue with rescaling incremental checkpoints: >>> https://issues.apache.org/jira/browse/FLINK-6762 >>> >>> I am not sure if this is regarded as a blocker, it depends on our >>> assumptions about externalized checkpoints. >>> >>> What do you think? >>> >>> Cheers, >>> Gyula >>> >>> Robert Metzger <[hidden email]> ezt írta (időpont: 2017. máj. 29., >> H, >>> 15:59): >>> >>>> +1 to release: >>>> >>>> - Tested building job against staging repository >>>> - tested YARN session start and container recovery on YARN >>>> - Validated HA on YARN (per job and session mode) >>>> - Incremental checkpointing with rocksdb works >>>> - FsStatebackend with async snapshots works >>>> >>>> - Flink builds from source on Linux (includes rat license header check) >>>> - source doesn't contain binaries >>>> - checked md5 / sha512 sum of source archive (assuming the other sums >> are >>>> valid as well) >>>> >>>> >>>> I noticed one minor thing: the copyright in the NOTICE file is >> 2014-2016. >>>> I'll update it on master and the release branch. >>>> >>>> >>>> On Mon, May 29, 2017 at 12:42 PM, Chesnay Schepler <[hidden email] >>> >>>> wrote: >>>> >>>>> +1 >>>>> >>>>> * Builds from source >>>>> * start/stop scripts work >>>>> * logs don't show anything suspicious on startup/shutdown >>>>> * ran some example jobs >>>>> * ran jobs on yarn with exactly-once & RocksDB >>>>> o canceling with savepoint/resuming from savepoint >>>>> o without/with rescaling >>>>> * SideOutputs work >>>>> * Metrics are properly transmitted & displayed in the webUI >>>>> >>>>> >>>>> On 28.05.2017 20:33, Robert Metzger wrote: >>>>> >>>>>> @Shaoxuan, I don't think missing documentation is a release blocker, >>> but >>>>>> it's something we should fix asap and with high priority :) >>>>>> Since the documentation is not bundled with the release, and the >> docs >>>> are >>>>>> build off the "release-x.y" branch, we can always update them (even >>>> after >>>>>> the release). >>>>>> >>>>>> However, it makes sense to have the docs ready when we announce the >>>>>> release >>>>>> so that users can understand how to use the newly released features. >>>>>> >>>>>> On Sat, May 27, 2017 at 6:14 PM, Chesnay Schepler < >> [hidden email] >>>> >>>>>> wrote: >>>>>> >>>>>> I've responded in the JIRA. In my opinion isn't a functional issue, >>> but >>>>>>> more about improving >>>>>>> error messages/documentation. >>>>>>> >>>>>>> >>>>>>> On 27.05.2017 18:07, Gyula Fóra wrote: >>>>>>> >>>>>>> Hi! >>>>>>>> I have found this issue: https://issues.apache.org/jira >>>>>>>> /browse/FLINK-6742 >>>>>>>> >>>>>>>> Not sure if it's a blocker or not (not even completely sure what >>>> causes >>>>>>>> it >>>>>>>> at the moment) >>>>>>>> >>>>>>>> Gyula >>>>>>>> >>>>>>>> Shaoxuan Wang <[hidden email]> ezt írta (időpont: 2017. máj. >>>> 27., >>>>>>>> Szo, >>>>>>>> 6:30): >>>>>>>> >>>>>>>> Hi Robert. >>>>>>>> >>>>>>>>> Will doc update be a blocker for release? >>>>>>>>> Release 1.3 has many updates on tableAPI and SQL, and the docs >> are >>>> kind >>>>>>>>> of >>>>>>>>> lagging. We are trying the efforts to update the doc as much as >>>>>>>>> possible >>>>>>>>> before the release is officially published, but I am hoping this >> is >>>>>>>>> not a >>>>>>>>> blocker for the release. >>>>>>>>> >>>>>>>>> Shaoxuan >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Sat, May 27, 2017 at 12:58 AM, Robert Metzger < >>>> [hidden email]> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>> Hi all, >>>>>>>>> >>>>>>>>>> this is the second VOTEing release candidate for Flink 1.3.0 >>>>>>>>>> >>>>>>>>>> The commit to be voted on: >>>>>>>>>> 760eea8a < >>>> http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8 >>>>>>>>>> a> >>>>>>>>>> (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a >>>>>>>>>> <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a >>> *) >>>>>>>>>> >>>>>>>>>> Branch: >>>>>>>>>> release-1.3.0-rc3 >>>>>>>>>> >>>>>>>>>> The release artifacts to be voted on can be found at: >>>>>>>>>> http://people.apache.org/~rmetzger/flink-1.3.0-rc3 >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> The release artifacts are signed with the key with fingerprint >>>>>>>>>> D9839159: >>>>>>>>>> http://www.apache.org/dist/flink/KEYS >>>>>>>>>> >>>>>>>>>> The staging repository for this release can be found at: >>>>>>>>>> *https://repository.apache.org/content/repositories/orgapach >>>>>>>>>> eflink-1122 >>>>>>>>>> <https://repository.apache.org/content/repositories/orgapach >>>>>>>>>> eflink-1122 >>>>>>>>>> * >>>>>>>>>> >>>>>>>>>> ------------------------------------------------------------- >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> The vote ends on Tuesday (May 30th), 7pm CET. >>>>>>>>>> >>>>>>>>>> [ ] +1 Release this package as Apache Flink 1.3.0 >>>>>>>>>> [ ] -1 Do not release this package, because ... >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>> >>>> >>> >> |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
|
In reply to this post by Robert Metzger
+1 (binding)
- verified source and binary signatures - verified source and binary checksums - verified LICENSEs - verified NOTICEs - built from source Greg > On May 26, 2017, at 12:58 PM, Robert Metzger <[hidden email]> wrote: > > Hi all, > > this is the second VOTEing release candidate for Flink 1.3.0 > > The commit to be voted on: > 760eea8a <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a> > (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a > <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a>*) > > Branch: > release-1.3.0-rc3 > > The release artifacts to be voted on can be found at: > http://people.apache.org/~rmetzger/flink-1.3.0-rc3 > > > The release artifacts are signed with the key with fingerprint D9839159: > http://www.apache.org/dist/flink/KEYS > > The staging repository for this release can be found at: > *https://repository.apache.org/content/repositories/orgapacheflink-1122 > <https://repository.apache.org/content/repositories/orgapacheflink-1122>* > > ------------------------------------------------------------- > > > The vote ends on Tuesday (May 30th), 7pm CET. > > [ ] +1 Release this package as Apache Flink 1.3.0 > [ ] -1 Do not release this package, because ... |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
I might have found a blocking issue [1]. The problem is that a
StateDescriptor cannot be shared by multiple subtasks because they don't duplicate their serializer. As a consequence, things break if you have a stateful serializer. The problem exists since 1.0. However, given that this issue is really hard to debug for the user and one can easily fall into this trap, I would like to fix it for the release. [1] https://issues.apache.org/jira/browse/FLINK-6775 Cheers, Till On Tue, May 30, 2017 at 4:01 PM, Greg Hogan <[hidden email]> wrote: > +1 (binding) > > - verified source and binary signatures > - verified source and binary checksums > - verified LICENSEs > - verified NOTICEs > - built from source > > Greg > > > > On May 26, 2017, at 12:58 PM, Robert Metzger <[hidden email]> > wrote: > > > > Hi all, > > > > this is the second VOTEing release candidate for Flink 1.3.0 > > > > The commit to be voted on: > > 760eea8a <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a> > > (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a > > <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a>*) > > > > Branch: > > release-1.3.0-rc3 > > > > The release artifacts to be voted on can be found at: > > http://people.apache.org/~rmetzger/flink-1.3.0-rc3 > > > > > > The release artifacts are signed with the key with fingerprint D9839159: > > http://www.apache.org/dist/flink/KEYS > > > > The staging repository for this release can be found at: > > *https://repository.apache.org/content/repositories/orgapacheflink-1122 > > <https://repository.apache.org/content/repositories/orgapacheflink-1122 > >* > > > > ------------------------------------------------------------- > > > > > > The vote ends on Tuesday (May 30th), 7pm CET. > > > > [ ] +1 Release this package as Apache Flink 1.3.0 > > [ ] -1 Do not release this package, because ... > > |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
|
Hi Till,
good catch! That is definitively a severe issue. Probably it didn't surface yet, because a) the code example in the documentation is using a new instance for each state descriptor b) people are using stateless serializers? c) don't have the same state descriptor on the same machine I see two options how to handle the situation 1) Cancel RC3 and do another vote (potentially with a 24 hrs vote time) 2) Release RC3 as 1.3.0 and start the vote for 1.3.1 right afterwards. + Pros and - cons for cancelling RC3 - The release would be delayed (not sure who's expecting the 1.3.0 to be available on time) - The bug has been there since many releases, probably no user is affected and it was not introduced during the rel 1.3.0 cycle. - There is a workaround for the issue + We would have a better feeling for the 1.3.0 release because there are no known critical issues. + pro and - cons for releasing RC3: + there are some other "minor" issues that showed up during the 1.3.0 testing that could go into 1.3.1 (FLINK-6763 <https://issues.apache.org/jira/browse/FLINK-6763>, FLINK-6764 <https://issues.apache.org/jira/browse/FLINK-6764>) without too much time-pressure (I'm happy to manage the 1.3.1 release and start it tomorrow) I'm undecided between both options and more than happy to hear your opinion. On Tue, May 30, 2017 at 4:18 PM, Till Rohrmann <[hidden email]> wrote: > I might have found a blocking issue [1]. The problem is that a > StateDescriptor cannot be shared by multiple subtasks because they don't > duplicate their serializer. As a consequence, things break if you have a > stateful serializer. The problem exists since 1.0. However, given that this > issue is really hard to debug for the user and one can easily fall into > this trap, I would like to fix it for the release. > > [1] https://issues.apache.org/jira/browse/FLINK-6775 > > Cheers, > Till > > On Tue, May 30, 2017 at 4:01 PM, Greg Hogan <[hidden email]> wrote: > > > +1 (binding) > > > > - verified source and binary signatures > > - verified source and binary checksums > > - verified LICENSEs > > - verified NOTICEs > > - built from source > > > > Greg > > > > > > > On May 26, 2017, at 12:58 PM, Robert Metzger <[hidden email]> > > wrote: > > > > > > Hi all, > > > > > > this is the second VOTEing release candidate for Flink 1.3.0 > > > > > > The commit to be voted on: > > > 760eea8a <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a > > > > > (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a > > > <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a>*) > > > > > > Branch: > > > release-1.3.0-rc3 > > > > > > The release artifacts to be voted on can be found at: > > > http://people.apache.org/~rmetzger/flink-1.3.0-rc3 > > > > > > > > > The release artifacts are signed with the key with fingerprint > D9839159: > > > http://www.apache.org/dist/flink/KEYS > > > > > > The staging repository for this release can be found at: > > > *https://repository.apache.org/content/repositories/orgapach > eflink-1122 > > > <https://repository.apache.org/content/repositories/orgapach > eflink-1122 > > >* > > > > > > ------------------------------------------------------------- > > > > > > > > > The vote ends on Tuesday (May 30th), 7pm CET. > > > > > > [ ] +1 Release this package as Apache Flink 1.3.0 > > > [ ] -1 Do not release this package, because ... > > > > > |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
|
The vote time is over, but I'll keep it open for a bit longer until we've
decided regarding Till's issue. On Tue, May 30, 2017 at 6:10 PM, Robert Metzger <[hidden email]> wrote: > Hi Till, > good catch! That is definitively a severe issue. Probably it didn't > surface yet, because > a) the code example in the documentation is using a new instance for each > state descriptor > b) people are using stateless serializers? > c) don't have the same state descriptor on the same machine > > I see two options how to handle the situation > 1) Cancel RC3 and do another vote (potentially with a 24 hrs vote time) > 2) Release RC3 as 1.3.0 and start the vote for 1.3.1 right afterwards. > > > + Pros and - cons for cancelling RC3 > - The release would be delayed (not sure who's expecting the 1.3.0 to be > available on time) > - The bug has been there since many releases, probably no user is affected > and it was not introduced during the rel 1.3.0 cycle. > - There is a workaround for the issue > + We would have a better feeling for the 1.3.0 release because there are > no known critical issues. > > + pro and - cons for releasing RC3: > + there are some other "minor" issues that showed up during the 1.3.0 > testing that could go into 1.3.1 (FLINK-6763 > <https://issues.apache.org/jira/browse/FLINK-6763>, FLINK-6764 > <https://issues.apache.org/jira/browse/FLINK-6764>) without too much > time-pressure (I'm happy to manage the 1.3.1 release and start it tomorrow) > > > I'm undecided between both options and more than happy to hear your > opinion. > > > > On Tue, May 30, 2017 at 4:18 PM, Till Rohrmann <[hidden email]> > wrote: > >> I might have found a blocking issue [1]. The problem is that a >> StateDescriptor cannot be shared by multiple subtasks because they don't >> duplicate their serializer. As a consequence, things break if you have a >> stateful serializer. The problem exists since 1.0. However, given that >> this >> issue is really hard to debug for the user and one can easily fall into >> this trap, I would like to fix it for the release. >> >> [1] https://issues.apache.org/jira/browse/FLINK-6775 >> >> Cheers, >> Till >> >> On Tue, May 30, 2017 at 4:01 PM, Greg Hogan <[hidden email]> wrote: >> >> > +1 (binding) >> > >> > - verified source and binary signatures >> > - verified source and binary checksums >> > - verified LICENSEs >> > - verified NOTICEs >> > - built from source >> > >> > Greg >> > >> > >> > > On May 26, 2017, at 12:58 PM, Robert Metzger <[hidden email]> >> > wrote: >> > > >> > > Hi all, >> > > >> > > this is the second VOTEing release candidate for Flink 1.3.0 >> > > >> > > The commit to be voted on: >> > > 760eea8a <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8 >> a> >> > > (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a >> > > <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a>*) >> > > >> > > Branch: >> > > release-1.3.0-rc3 >> > > >> > > The release artifacts to be voted on can be found at: >> > > http://people.apache.org/~rmetzger/flink-1.3.0-rc3 >> > > >> > > >> > > The release artifacts are signed with the key with fingerprint >> D9839159: >> > > http://www.apache.org/dist/flink/KEYS >> > > >> > > The staging repository for this release can be found at: >> > > *https://repository.apache.org/content/repositories/orgapach >> eflink-1122 >> > > <https://repository.apache.org/content/repositories/orgapach >> eflink-1122 >> > >* >> > > >> > > ------------------------------------------------------------- >> > > >> > > >> > > The vote ends on Tuesday (May 30th), 7pm CET. >> > > >> > > [ ] +1 Release this package as Apache Flink 1.3.0 >> > > [ ] -1 Do not release this package, because ... >> > >> > >> > > |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
|
Just some thoughts concerning the cons for cancelling RC3:
- Technically, the release is already delayed since the official release date was the 26th of May - Not sure whether it's a good argument to defer fixing major bugs because they have not been introduced with 1.3.0. It's actually alarming that these things have not been found earlier given that we test our releases thoroughly. - The shared serializer surfaced in the form of a cryptic ArrayIndexOutOfBoundsException. Only if you realize that this is related to a shared StateDescriptor you can look for a workaround. It took me 2h to realize that. Cheers, Till On Tue, May 30, 2017 at 7:02 PM, Robert Metzger <[hidden email]> wrote: > The vote time is over, but I'll keep it open for a bit longer until we've > decided regarding Till's issue. > > On Tue, May 30, 2017 at 6:10 PM, Robert Metzger <[hidden email]> > wrote: > > > Hi Till, > > good catch! That is definitively a severe issue. Probably it didn't > > surface yet, because > > a) the code example in the documentation is using a new instance for each > > state descriptor > > b) people are using stateless serializers? > > c) don't have the same state descriptor on the same machine > > > > I see two options how to handle the situation > > 1) Cancel RC3 and do another vote (potentially with a 24 hrs vote time) > > 2) Release RC3 as 1.3.0 and start the vote for 1.3.1 right afterwards. > > > > > > + Pros and - cons for cancelling RC3 > > - The release would be delayed (not sure who's expecting the 1.3.0 to be > > available on time) > > - The bug has been there since many releases, probably no user is > affected > > and it was not introduced during the rel 1.3.0 cycle. > > - There is a workaround for the issue > > + We would have a better feeling for the 1.3.0 release because there are > > no known critical issues. > > > > + pro and - cons for releasing RC3: > > + there are some other "minor" issues that showed up during the 1.3.0 > > testing that could go into 1.3.1 (FLINK-6763 > > <https://issues.apache.org/jira/browse/FLINK-6763>, FLINK-6764 > > <https://issues.apache.org/jira/browse/FLINK-6764>) without too much > > time-pressure (I'm happy to manage the 1.3.1 release and start it > tomorrow) > > > > > > I'm undecided between both options and more than happy to hear your > > opinion. > > > > > > > > On Tue, May 30, 2017 at 4:18 PM, Till Rohrmann <[hidden email]> > > wrote: > > > >> I might have found a blocking issue [1]. The problem is that a > >> StateDescriptor cannot be shared by multiple subtasks because they don't > >> duplicate their serializer. As a consequence, things break if you have a > >> stateful serializer. The problem exists since 1.0. However, given that > >> this > >> issue is really hard to debug for the user and one can easily fall into > >> this trap, I would like to fix it for the release. > >> > >> [1] https://issues.apache.org/jira/browse/FLINK-6775 > >> > >> Cheers, > >> Till > >> > >> On Tue, May 30, 2017 at 4:01 PM, Greg Hogan <[hidden email]> wrote: > >> > >> > +1 (binding) > >> > > >> > - verified source and binary signatures > >> > - verified source and binary checksums > >> > - verified LICENSEs > >> > - verified NOTICEs > >> > - built from source > >> > > >> > Greg > >> > > >> > > >> > > On May 26, 2017, at 12:58 PM, Robert Metzger <[hidden email]> > >> > wrote: > >> > > > >> > > Hi all, > >> > > > >> > > this is the second VOTEing release candidate for Flink 1.3.0 > >> > > > >> > > The commit to be voted on: > >> > > 760eea8a <http://git-wip-us.apache.org/ > repos/asf/flink/commit/760eea8 > >> a> > >> > > (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a > >> > > <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a>*) > >> > > > >> > > Branch: > >> > > release-1.3.0-rc3 > >> > > > >> > > The release artifacts to be voted on can be found at: > >> > > http://people.apache.org/~rmetzger/flink-1.3.0-rc3 > >> > > > >> > > > >> > > The release artifacts are signed with the key with fingerprint > >> D9839159: > >> > > http://www.apache.org/dist/flink/KEYS > >> > > > >> > > The staging repository for this release can be found at: > >> > > *https://repository.apache.org/content/repositories/orgapach > >> eflink-1122 > >> > > <https://repository.apache.org/content/repositories/orgapach > >> eflink-1122 > >> > >* > >> > > > >> > > ------------------------------------------------------------- > >> > > > >> > > > >> > > The vote ends on Tuesday (May 30th), 7pm CET. > >> > > > >> > > [ ] +1 Release this package as Apache Flink 1.3.0 > >> > > [ ] -1 Do not release this package, because ... > >> > > >> > > >> > > > > > |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
|
Hi,
We have discovered https://issues.apache.org/jira/browse/FLINK-6780 which effectively makes external catalogs in the table API very difficult to use. It may not be a show stopper but in my opinion it is worth a fix before the release. Regards, Haohui On Tue, May 30, 2017 at 11:22 AM Till Rohrmann <[hidden email]> wrote: > Just some thoughts concerning the cons for cancelling RC3: > > - Technically, the release is already delayed since the official release > date was the 26th of May > - Not sure whether it's a good argument to defer fixing major bugs because > they have not been introduced with 1.3.0. It's actually alarming that these > things have not been found earlier given that we test our releases > thoroughly. > - The shared serializer surfaced in the form of a cryptic > ArrayIndexOutOfBoundsException. Only if you realize that this is related to > a shared StateDescriptor you can look for a workaround. It took me 2h to > realize that. > > Cheers, > Till > > On Tue, May 30, 2017 at 7:02 PM, Robert Metzger <[hidden email]> > wrote: > > > The vote time is over, but I'll keep it open for a bit longer until we've > > decided regarding Till's issue. > > > > On Tue, May 30, 2017 at 6:10 PM, Robert Metzger <[hidden email]> > > wrote: > > > > > Hi Till, > > > good catch! That is definitively a severe issue. Probably it didn't > > > surface yet, because > > > a) the code example in the documentation is using a new instance for > each > > > state descriptor > > > b) people are using stateless serializers? > > > c) don't have the same state descriptor on the same machine > > > > > > I see two options how to handle the situation > > > 1) Cancel RC3 and do another vote (potentially with a 24 hrs vote time) > > > 2) Release RC3 as 1.3.0 and start the vote for 1.3.1 right afterwards. > > > > > > > > > + Pros and - cons for cancelling RC3 > > > - The release would be delayed (not sure who's expecting the 1.3.0 to > be > > > available on time) > > > - The bug has been there since many releases, probably no user is > > affected > > > and it was not introduced during the rel 1.3.0 cycle. > > > - There is a workaround for the issue > > > + We would have a better feeling for the 1.3.0 release because there > are > > > no known critical issues. > > > > > > + pro and - cons for releasing RC3: > > > + there are some other "minor" issues that showed up during the 1.3.0 > > > testing that could go into 1.3.1 (FLINK-6763 > > > <https://issues.apache.org/jira/browse/FLINK-6763>, FLINK-6764 > > > <https://issues.apache.org/jira/browse/FLINK-6764>) without too much > > > time-pressure (I'm happy to manage the 1.3.1 release and start it > > tomorrow) > > > > > > > > > I'm undecided between both options and more than happy to hear your > > > opinion. > > > > > > > > > > > > On Tue, May 30, 2017 at 4:18 PM, Till Rohrmann <[hidden email]> > > > wrote: > > > > > >> I might have found a blocking issue [1]. The problem is that a > > >> StateDescriptor cannot be shared by multiple subtasks because they > don't > > >> duplicate their serializer. As a consequence, things break if you > have a > > >> stateful serializer. The problem exists since 1.0. However, given that > > >> this > > >> issue is really hard to debug for the user and one can easily fall > into > > >> this trap, I would like to fix it for the release. > > >> > > >> [1] https://issues.apache.org/jira/browse/FLINK-6775 > > >> > > >> Cheers, > > >> Till > > >> > > >> On Tue, May 30, 2017 at 4:01 PM, Greg Hogan <[hidden email]> > wrote: > > >> > > >> > +1 (binding) > > >> > > > >> > - verified source and binary signatures > > >> > - verified source and binary checksums > > >> > - verified LICENSEs > > >> > - verified NOTICEs > > >> > - built from source > > >> > > > >> > Greg > > >> > > > >> > > > >> > > On May 26, 2017, at 12:58 PM, Robert Metzger <[hidden email] > > > > >> > wrote: > > >> > > > > >> > > Hi all, > > >> > > > > >> > > this is the second VOTEing release candidate for Flink 1.3.0 > > >> > > > > >> > > The commit to be voted on: > > >> > > 760eea8a <http://git-wip-us.apache.org/ > > repos/asf/flink/commit/760eea8 > > >> a> > > >> > > (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a > > >> > > <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a>*) > > >> > > > > >> > > Branch: > > >> > > release-1.3.0-rc3 > > >> > > > > >> > > The release artifacts to be voted on can be found at: > > >> > > http://people.apache.org/~rmetzger/flink-1.3.0-rc3 > > >> > > > > >> > > > > >> > > The release artifacts are signed with the key with fingerprint > > >> D9839159: > > >> > > http://www.apache.org/dist/flink/KEYS > > >> > > > > >> > > The staging repository for this release can be found at: > > >> > > *https://repository.apache.org/content/repositories/orgapach > > >> eflink-1122 > > >> > > <https://repository.apache.org/content/repositories/orgapach > > >> eflink-1122 > > >> > >* > > >> > > > > >> > > ------------------------------------------------------------- > > >> > > > > >> > > > > >> > > The vote ends on Tuesday (May 30th), 7pm CET. > > >> > > > > >> > > [ ] +1 Release this package as Apache Flink 1.3.0 > > >> > > [ ] -1 Do not release this package, because ... > > >> > > > >> > > > >> > > > > > > > > > |
Re: [VOTE] Release Apache Flink 1.3.0 (RC3)
|
|
I don't think that FLINK-6780 is a blocker, because the Table API is
still a new feature. FLINK-6736 was also a hard bug. However, if there will be a RC4, a fix should be included. Regards, Timo Am 31.05.17 um 02:55 schrieb Haohui Mai: > Hi, > > We have discovered https://issues.apache.org/jira/browse/FLINK-6780 which > effectively makes external catalogs in the table API very difficult to use. > > It may not be a show stopper but in my opinion it is worth a fix before the > release. > > Regards, > Haohui > > On Tue, May 30, 2017 at 11:22 AM Till Rohrmann <[hidden email]> wrote: > >> Just some thoughts concerning the cons for cancelling RC3: >> >> - Technically, the release is already delayed since the official release >> date was the 26th of May >> - Not sure whether it's a good argument to defer fixing major bugs because >> they have not been introduced with 1.3.0. It's actually alarming that these >> things have not been found earlier given that we test our releases >> thoroughly. >> - The shared serializer surfaced in the form of a cryptic >> ArrayIndexOutOfBoundsException. Only if you realize that this is related to >> a shared StateDescriptor you can look for a workaround. It took me 2h to >> realize that. >> >> Cheers, >> Till >> >> On Tue, May 30, 2017 at 7:02 PM, Robert Metzger <[hidden email]> >> wrote: >> >>> The vote time is over, but I'll keep it open for a bit longer until we've >>> decided regarding Till's issue. >>> >>> On Tue, May 30, 2017 at 6:10 PM, Robert Metzger <[hidden email]> >>> wrote: >>> >>>> Hi Till, >>>> good catch! That is definitively a severe issue. Probably it didn't >>>> surface yet, because >>>> a) the code example in the documentation is using a new instance for >> each >>>> state descriptor >>>> b) people are using stateless serializers? >>>> c) don't have the same state descriptor on the same machine >>>> >>>> I see two options how to handle the situation >>>> 1) Cancel RC3 and do another vote (potentially with a 24 hrs vote time) >>>> 2) Release RC3 as 1.3.0 and start the vote for 1.3.1 right afterwards. >>>> >>>> >>>> + Pros and - cons for cancelling RC3 >>>> - The release would be delayed (not sure who's expecting the 1.3.0 to >> be >>>> available on time) >>>> - The bug has been there since many releases, probably no user is >>> affected >>>> and it was not introduced during the rel 1.3.0 cycle. >>>> - There is a workaround for the issue >>>> + We would have a better feeling for the 1.3.0 release because there >> are >>>> no known critical issues. >>>> >>>> + pro and - cons for releasing RC3: >>>> + there are some other "minor" issues that showed up during the 1.3.0 >>>> testing that could go into 1.3.1 (FLINK-6763 >>>> <https://issues.apache.org/jira/browse/FLINK-6763>, FLINK-6764 >>>> <https://issues.apache.org/jira/browse/FLINK-6764>) without too much >>>> time-pressure (I'm happy to manage the 1.3.1 release and start it >>> tomorrow) >>>> >>>> I'm undecided between both options and more than happy to hear your >>>> opinion. >>>> >>>> >>>> >>>> On Tue, May 30, 2017 at 4:18 PM, Till Rohrmann <[hidden email]> >>>> wrote: >>>> >>>>> I might have found a blocking issue [1]. The problem is that a >>>>> StateDescriptor cannot be shared by multiple subtasks because they >> don't >>>>> duplicate their serializer. As a consequence, things break if you >> have a >>>>> stateful serializer. The problem exists since 1.0. However, given that >>>>> this >>>>> issue is really hard to debug for the user and one can easily fall >> into >>>>> this trap, I would like to fix it for the release. >>>>> >>>>> [1] https://issues.apache.org/jira/browse/FLINK-6775 >>>>> >>>>> Cheers, >>>>> Till >>>>> >>>>> On Tue, May 30, 2017 at 4:01 PM, Greg Hogan <[hidden email]> >> wrote: >>>>>> +1 (binding) >>>>>> >>>>>> - verified source and binary signatures >>>>>> - verified source and binary checksums >>>>>> - verified LICENSEs >>>>>> - verified NOTICEs >>>>>> - built from source >>>>>> >>>>>> Greg >>>>>> >>>>>> >>>>>>> On May 26, 2017, at 12:58 PM, Robert Metzger <[hidden email] >>>>>> wrote: >>>>>>> Hi all, >>>>>>> >>>>>>> this is the second VOTEing release candidate for Flink 1.3.0 >>>>>>> >>>>>>> The commit to be voted on: >>>>>>> 760eea8a <http://git-wip-us.apache.org/ >>> repos/asf/flink/commit/760eea8 >>>>> a> >>>>>>> (*http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a >>>>>>> <http://git-wip-us.apache.org/repos/asf/flink/commit/760eea8a>*) >>>>>>> >>>>>>> Branch: >>>>>>> release-1.3.0-rc3 >>>>>>> >>>>>>> The release artifacts to be voted on can be found at: >>>>>>> http://people.apache.org/~rmetzger/flink-1.3.0-rc3 >>>>>>> >>>>>>> >>>>>>> The release artifacts are signed with the key with fingerprint >>>>> D9839159: >>>>>>> http://www.apache.org/dist/flink/KEYS >>>>>>> >>>>>>> The staging repository for this release can be found at: >>>>>>> *https://repository.apache.org/content/repositories/orgapach >>>>> eflink-1122 >>>>>>> <https://repository.apache.org/content/repositories/orgapach >>>>> eflink-1122 >>>>>>> * >>>>>>> >>>>>>> ------------------------------------------------------------- >>>>>>> >>>>>>> >>>>>>> The vote ends on Tuesday (May 30th), 7pm CET. >>>>>>> >>>>>>> [ ] +1 Release this package as Apache Flink 1.3.0 >>>>>>> [ ] -1 Do not release this package, because ... >>>>>> >>>> |
«
Return to (DEPRECATED) Apache Flink Mailing List archive.
|
1 view|%1 views
| Free forum by Nabble | Edit this page |