[VOTE] Release Apache Flink 1.0.1 (RC1)

[Ufuk Celebi-2]

Dear Flink community,

Please vote on releasing the following candidate as Apache Flink version
1.0.1.

The commit to be voted on:
4afa401ab3c2b53de115d17a3157e8b80431dd10

Branch:
release-1.0.1-rc1 (see
https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git;a=shortlog;h=refs/heads/release-1.0.1-rc1)

The release artifacts to be voted on can be found at:
http://home.apache.org/~uce/flink-1.0.1-rc1/

The release artifacts are signed with the key with fingerprint 9D403309:
http://www.apache.org/dist/flink/KEYS

The staging repository for this release can be found at:
https://repository.apache.org/content/repositories/orgapacheflink-1089

-------------------------------------------------------------

The vote is open for the next 72 hours and passes if a majority of at least
three +1 PMC votes are cast.

The vote ends on Tuesday April 5, 2016 (not counting the weekend).

[ ] +1 Release this package as Apache Flink 1.0.1
[ ] -1 Do not release this package because ...

===================================

The following commits have been added since the 1.0.0 release, most
notably a fix for the rolling HDFS file sink and support for
RichFunctions in Scala.

* 974c66e - [FLINK-3383] Backport 'Move snapshot deployment from
Travis CI to ASF Jenkins' (6 hours ago) <Ufuk Celebi>
* 630e77f - [FLINK-3684] [cep] Add proper watermark emission to CEP
operators (6 hours ago) <Till Rohrmann>
* dae29b4 - [FLINK-3682] [cep] Assign processing timestamp in CEP
operators (23 hours ago) <Till Rohrmann>
* a96e1a6 - [FLINK-3681] [cep, typeextractor] Generalize TypeExtractor
to support more lambdas (23 hours ago) <Till Rohrmann>
* ce448cd - [tools] Update copy files function in release script (25
hours ago) <Ufuk Celebi>
* 245f0d8 - [hotfix] [cep] Add sanity check for erroneously pruned
elements (26 hours ago) <Till Rohrmann>
* 2089029 - [FLINK-3651] Fix faulty RollingSink Restore (2 days ago)
<Aljoscha Krettek>
* 875cb44 - [FLINK-3676][docs] sync docs with the WebClient removal (2
days ago) <Maximilian Michels>
* 085f7b2 - [FLINK-3663] [kafka] Fix logPartitionInfo log statement (7
days ago) <Niels Zeilemaker>
* 5357ebe - [FLINK-3653] [docs] Add recovery.zookeeper.storageDir docs
to config page (7 days ago) <Stefano Baghino>
* 1ca4f36 - [FLINK-2444] Add tests for HadoopInputFormats (8 days ago)
<Martin Liesenberg>
* da989c4 - [FLINK-2445] Improve HadoopOutputFormatTests (8 days ago)
<Martin Liesenberg>
* edf343a - [FLINK-2445] Add tests for HadoopOutputFormats (8 days
ago) <Ajay Bhat>
* 1909bdb - [FLINK-3129] Bring infrastructure for ensuring interface
stability in place (8 days ago) <Robert Metzger>
* cd5773e - [FLINK-3179] [dataSet][optimizer] Log a WARN message if
combiner is not added in front of PartitionOperator (9 days ago)
<ramkrishna>
* 0880c59 - [FLINK-3602] Fix TypeExtractor and add support for
recursive types (9 days ago) <twalthr>
* 954cdc1 - [hotfix] Fix ContinuousProcessingTimeTrigger (10 days ago)
<Aljoscha Krettek>
* 2c78be3 - [FLINK-3629] Fix quick start description for the
".timeWindow()" function call (2 weeks ago) <Li Fanxi>
* 6749874 - [FLINK-3621] [docs] Improve documentation of memory
configuration parameters (2 weeks ago) <Fabian Hueske>
* 165065c - [FLINK-3333] [docs] Improve documentation of DataSet
object-reuse modes. (2 weeks ago) <Fabian Hueske>
* 3d8c7c1 - [FLINK-3472] [jdbc] Give a better exception if jdbc column
has a null value (3 weeks ago) <zentol>
* 43e95f2 - [FLINK-2671] [tests] Fix test instability in
StreamCheckpointNotifierITCase (3 weeks ago) <Stephan Ewen>
* f905503 - [FLINK-3594] [runtime] Make sure exceptions during
checkpoints are handled properly (3 weeks ago) <Stephan Ewen>
* a405b55 - [hotfix] [runtime] Guard async recovery operation in
try-catch (3 weeks ago) <Ufuk Celebi>
* 5f35d13 - [quickstart] fix links to documentation (3 weeks ago)
<Maximilian Michels>
* dc675f2 - [docs] Remove 'Working with Time' page (3 weeks ago) <Ufuk Celebi>
* 95cd07c - [docs] Add description and illustration about Watermarks
in streams (3 weeks ago) <Stephan Ewen>
* 2831b7d - [docs] Add first steps to docs start page (3 weeks ago)
<Ufuk Celebi>
* a709f0a - [docs] Update stack figure on docs start page (3 weeks
ago) <Ufuk Celebi>
* bb9c1fa - [FLINK-3592] [docs] Update setup quickstart (3 weeks ago)
<Ufuk Celebi>
* d4c2a47 - [FLINK-3591] Replace Quickstart K-Means Example by
Streaming Example (3 weeks ago) <Aljoscha Krettek>
* 2f3711b - [docs] Move connectors page to batch guide (3 weeks ago)
<Ufuk Celebi>
* db860e4 - Update version and remove unused variables (3 weeks ago)
<Ufuk Celebi>
* 4f6a92d - [docs] update "build from source" page (3 weeks ago)
<Maximilian Michels>
* a08242f - [FLINK-3533] [docs] fix broken links to examples and
cluster execution in Gelly guide (4 weeks ago) <vasia>
* b376540 - [FLINK-3566] [FLINK-3563] [core] TypeExtraction input type
validation fixes (4 weeks ago) <twalthr>
* 2cde19b - [FLINK-3495] [tests] Disable RocksDB tests on Windows (4
weeks ago) <zentol>
* 5a63cbf - [FLINK-3491] [tests] Prevent URIException in HDFSCopyTest
and disable HDFSCopyUtilitiesTest on Windows (4 weeks ago) <zentol>
* 0e61ffc - [docs] Add documentation about Event Time, Timestamp
Assigners, Watermark Generation (4 weeks ago) <Stephan Ewen>
* 5c3c734 - [FLINK-3575] [docs] Update 'Working With State' section in
docs (4 weeks ago) <Aljoscha Krettek>
* 9158789 - [FLINK-3578] [streaming scala] Support RichFunctions for
Scala WindowFunction and AllWindowFunction (4 weeks ago) <Stephan
Ewen>
* fd0830e - [FLINK-3569] [build] Adjust test cases due to shading
plugin base directory changes (4 weeks ago) <Maximilian Michels>
* b289311 - [FLINK-3570] [runtime] Use InetAddress.getLocalHost() as
heuristic to find local address (4 weeks ago) <Till Rohrmann>
* f856855 - [FLINK-3484] Add setSlotSharingGroup documentation (4
weeks ago) <Aljo

[Aljoscha Krettek-2]

I ran the usual tests and the release seems fine. A user, however, found
this bug which seems to be a blocker:
https://issues.apache.org/jira/browse/FLINK-3688?jql=project%20%3D%20FLINK

Should we maybe wait for the fix and then to another RC?

On Thu, 31 Mar 2016 at 18:10 Ufuk Celebi <[hidden email]> wrote:

> Dear Flink community,
>
> Please vote on releasing the following candidate as Apache Flink version
> 1.0.1.
>
> The commit to be voted on:
> 4afa401ab3c2b53de115d17a3157e8b80431dd10
>
> Branch:
> release-1.0.1-rc1 (see
>
> https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git;a=shortlog;h=refs/heads/release-1.0.1-rc1
> )
>
> The release artifacts to be voted on can be found at:
> http://home.apache.org/~uce/flink-1.0.1-rc1/
>
> The release artifacts are signed with the key with fingerprint 9D403309:
> http://www.apache.org/dist/flink/KEYS
>
> The staging repository for this release can be found at:
> https://repository.apache.org/content/repositories/orgapacheflink-1089
>
> -------------------------------------------------------------
>
> The vote is open for the next 72 hours and passes if a majority of at least
> three +1 PMC votes are cast.
>
> The vote ends on Tuesday April 5, 2016 (not counting the weekend).
>
> [ ] +1 Release this package as Apache Flink 1.0.1
> [ ] -1 Do not release this package because ...
>
> ===================================
>
> The following commits have been added since the 1.0.0 release, most
> notably a fix for the rolling HDFS file sink and support for
> RichFunctions in Scala.
>
> * 974c66e - [FLINK-3383] Backport 'Move snapshot deployment from
> Travis CI to ASF Jenkins' (6 hours ago) <Ufuk Celebi>
> * 630e77f - [FLINK-3684] [cep] Add proper watermark emission to CEP
> operators (6 hours ago) <Till Rohrmann>
> * dae29b4 - [FLINK-3682] [cep] Assign processing timestamp in CEP
> operators (23 hours ago) <Till Rohrmann>
> * a96e1a6 - [FLINK-3681] [cep, typeextractor] Generalize TypeExtractor
> to support more lambdas (23 hours ago) <Till Rohrmann>
> * ce448cd - [tools] Update copy files function in release script (25
> hours ago) <Ufuk Celebi>
> * 245f0d8 - [hotfix] [cep] Add sanity check for erroneously pruned
> elements (26 hours ago) <Till Rohrmann>
> * 2089029 - [FLINK-3651] Fix faulty RollingSink Restore (2 days ago)
> <Aljoscha Krettek>
> * 875cb44 - [FLINK-3676][docs] sync docs with the WebClient removal (2
> days ago) <Maximilian Michels>
> * 085f7b2 - [FLINK-3663] [kafka] Fix logPartitionInfo log statement (7
> days ago) <Niels Zeilemaker>
> * 5357ebe - [FLINK-3653] [docs] Add recovery.zookeeper.storageDir docs
> to config page (7 days ago) <Stefano Baghino>
> * 1ca4f36 - [FLINK-2444] Add tests for HadoopInputFormats (8 days ago)
> <Martin Liesenberg>
> * da989c4 - [FLINK-2445] Improve HadoopOutputFormatTests (8 days ago)
> <Martin Liesenberg>
> * edf343a - [FLINK-2445] Add tests for HadoopOutputFormats (8 days
> ago) <Ajay Bhat>
> * 1909bdb - [FLINK-3129] Bring infrastructure for ensuring interface
> stability in place (8 days ago) <Robert Metzger>
> * cd5773e - [FLINK-3179] [dataSet][optimizer] Log a WARN message if
> combiner is not added in front of PartitionOperator (9 days ago)
> <ramkrishna>
> * 0880c59 - [FLINK-3602] Fix TypeExtractor and add support for
> recursive types (9 days ago) <twalthr>
> * 954cdc1 - [hotfix] Fix ContinuousProcessingTimeTrigger (10 days ago)
> <Aljoscha Krettek>
> * 2c78be3 - [FLINK-3629] Fix quick start description for the
> ".timeWindow()" function call (2 weeks ago) <Li Fanxi>
> * 6749874 - [FLINK-3621] [docs] Improve documentation of memory
> configuration parameters (2 weeks ago) <Fabian Hueske>
> * 165065c - [FLINK-3333] [docs] Improve documentation of DataSet
> object-reuse modes. (2 weeks ago) <Fabian Hueske>
> * 3d8c7c1 - [FLINK-3472] [jdbc] Give a better exception if jdbc column
> has a null value (3 weeks ago) <zentol>
> * 43e95f2 - [FLINK-2671] [tests] Fix test instability in
> StreamCheckpointNotifierITCase (3 weeks ago) <Stephan Ewen>
> * f905503 - [FLINK-3594] [runtime] Make sure exceptions during
> checkpoints are handled properly (3 weeks ago) <Stephan Ewen>
> * a405b55 - [hotfix] [runtime] Guard async recovery operation in
> try-catch (3 weeks ago) <Ufuk Celebi>
> * 5f35d13 - [quickstart] fix links to documentation (3 weeks ago)
> <Maximilian Michels>
> * dc675f2 - [docs] Remove 'Working with Time' page (3 weeks ago) <Ufuk
> Celebi>
> * 95cd07c - [docs] Add description and illustration about Watermarks
> in streams (3 weeks ago) <Stephan Ewen>
> * 2831b7d - [docs] Add first steps to docs start page (3 weeks ago)
> <Ufuk Celebi>
> * a709f0a - [docs] Update stack figure on docs start page (3 weeks
> ago) <Ufuk Celebi>
> * bb9c1fa - [FLINK-3592] [docs] Update setup quickstart (3 weeks ago)
> <Ufuk Celebi>
> * d4c2a47 - [FLINK-3591] Replace Quickstart K-Means Example by
> Streaming Example (3 weeks ago) <Aljoscha Krettek>
> * 2f3711b - [docs] Move connectors page to batch guide (3 weeks ago)
> <Ufuk Celebi>
> * db860e4 - Update version and remove unused variables (3 weeks ago)
> <Ufuk Celebi>
> * 4f6a92d - [docs] update "build from source" page (3 weeks ago)
> <Maximilian Michels>
> * a08242f - [FLINK-3533] [docs] fix broken links to examples and
> cluster execution in Gelly guide (4 weeks ago) <vasia>
> * b376540 - [FLINK-3566] [FLINK-3563] [core] TypeExtraction input type
> validation fixes (4 weeks ago) <twalthr>
> * 2cde19b - [FLINK-3495] [tests] Disable RocksDB tests on Windows (4
> weeks ago) <zentol>
> * 5a63cbf - [FLINK-3491] [tests] Prevent URIException in HDFSCopyTest
> and disable HDFSCopyUtilitiesTest on Windows (4 weeks ago) <zentol>
> * 0e61ffc - [docs] Add documentation about Event Time, Timestamp
> Assigners, Watermark Generation (4 weeks ago) <Stephan Ewen>
> * 5c3c734 - [FLINK-3575] [docs] Update 'Working With State' section in
> docs (4 weeks ago) <Aljoscha Krettek>
> * 9158789 - [FLINK-3578] [streaming scala] Support RichFunctions for
> Scala WindowFunction and AllWindowFunction (4 weeks ago) <Stephan
> Ewen>
> * fd0830e - [FLINK-3569] [build] Adjust test cases due to shading
> plugin base directory changes (4 weeks ago) <Maximilian Michels>
> * b289311 - [FLINK-3570] [runtime] Use InetAddress.getLocalHost() as
> heuristic to find local address (4 weeks ago) <Till Rohrmann>
> * f856855 - [FLINK-3484] Add setSlotSharingGroup documentation (4
> weeks ago) <Aljo
>

[Ufuk Celebi-2]

Thanks for the initial tests.

I would say let's continue with this RC and wait for the user to
provide the fix, which we can then include in 1.0.2 soon.

On Fri, Apr 1, 2016 at 2:59 PM, Aljoscha Krettek <[hidden email]> wrote:

> I ran the usual tests and the release seems fine. A user, however, found
> this bug which seems to be a blocker:
> https://issues.apache.org/jira/browse/FLINK-3688?jql=project%20%3D%20FLINK
>
> Should we maybe wait for the fix and then to another RC?
>
> On Thu, 31 Mar 2016 at 18:10 Ufuk Celebi <[hidden email]> wrote:
>
>> Dear Flink community,
>>
>> Please vote on releasing the following candidate as Apache Flink version
>> 1.0.1.
>>
>> The commit to be voted on:
>> 4afa401ab3c2b53de115d17a3157e8b80431dd10
>>
>> Branch:
>> release-1.0.1-rc1 (see
>>
>> https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git;a=shortlog;h=refs/heads/release-1.0.1-rc1
>> )
>>
>> The release artifacts to be voted on can be found at:
>> http://home.apache.org/~uce/flink-1.0.1-rc1/
>>
>> The release artifacts are signed with the key with fingerprint 9D403309:
>> http://www.apache.org/dist/flink/KEYS
>>
>> The staging repository for this release can be found at:
>> https://repository.apache.org/content/repositories/orgapacheflink-1089
>>
>> -------------------------------------------------------------
>>
>> The vote is open for the next 72 hours and passes if a majority of at least
>> three +1 PMC votes are cast.
>>
>> The vote ends on Tuesday April 5, 2016 (not counting the weekend).
>>
>> [ ] +1 Release this package as Apache Flink 1.0.1
>> [ ] -1 Do not release this package because ...
>>
>> ===================================
>>
>> The following commits have been added since the 1.0.0 release, most
>> notably a fix for the rolling HDFS file sink and support for
>> RichFunctions in Scala.
>>
>> * 974c66e - [FLINK-3383] Backport 'Move snapshot deployment from
>> Travis CI to ASF Jenkins' (6 hours ago) <Ufuk Celebi>
>> * 630e77f - [FLINK-3684] [cep] Add proper watermark emission to CEP
>> operators (6 hours ago) <Till Rohrmann>
>> * dae29b4 - [FLINK-3682] [cep] Assign processing timestamp in CEP
>> operators (23 hours ago) <Till Rohrmann>
>> * a96e1a6 - [FLINK-3681] [cep, typeextractor] Generalize TypeExtractor
>> to support more lambdas (23 hours ago) <Till Rohrmann>
>> * ce448cd - [tools] Update copy files function in release script (25
>> hours ago) <Ufuk Celebi>
>> * 245f0d8 - [hotfix] [cep] Add sanity check for erroneously pruned
>> elements (26 hours ago) <Till Rohrmann>
>> * 2089029 - [FLINK-3651] Fix faulty RollingSink Restore (2 days ago)
>> <Aljoscha Krettek>
>> * 875cb44 - [FLINK-3676][docs] sync docs with the WebClient removal (2
>> days ago) <Maximilian Michels>
>> * 085f7b2 - [FLINK-3663] [kafka] Fix logPartitionInfo log statement (7
>> days ago) <Niels Zeilemaker>
>> * 5357ebe - [FLINK-3653] [docs] Add recovery.zookeeper.storageDir docs
>> to config page (7 days ago) <Stefano Baghino>
>> * 1ca4f36 - [FLINK-2444] Add tests for HadoopInputFormats (8 days ago)
>> <Martin Liesenberg>
>> * da989c4 - [FLINK-2445] Improve HadoopOutputFormatTests (8 days ago)
>> <Martin Liesenberg>
>> * edf343a - [FLINK-2445] Add tests for HadoopOutputFormats (8 days
>> ago) <Ajay Bhat>
>> * 1909bdb - [FLINK-3129] Bring infrastructure for ensuring interface
>> stability in place (8 days ago) <Robert Metzger>
>> * cd5773e - [FLINK-3179] [dataSet][optimizer] Log a WARN message if
>> combiner is not added in front of PartitionOperator (9 days ago)
>> <ramkrishna>
>> * 0880c59 - [FLINK-3602] Fix TypeExtractor and add support for
>> recursive types (9 days ago) <twalthr>
>> * 954cdc1 - [hotfix] Fix ContinuousProcessingTimeTrigger (10 days ago)
>> <Aljoscha Krettek>
>> * 2c78be3 - [FLINK-3629] Fix quick start description for the
>> ".timeWindow()" function call (2 weeks ago) <Li Fanxi>
>> * 6749874 - [FLINK-3621] [docs] Improve documentation of memory
>> configuration parameters (2 weeks ago) <Fabian Hueske>
>> * 165065c - [FLINK-3333] [docs] Improve documentation of DataSet
>> object-reuse modes. (2 weeks ago) <Fabian Hueske>
>> * 3d8c7c1 - [FLINK-3472] [jdbc] Give a better exception if jdbc column
>> has a null value (3 weeks ago) <zentol>
>> * 43e95f2 - [FLINK-2671] [tests] Fix test instability in
>> StreamCheckpointNotifierITCase (3 weeks ago) <Stephan Ewen>
>> * f905503 - [FLINK-3594] [runtime] Make sure exceptions during
>> checkpoints are handled properly (3 weeks ago) <Stephan Ewen>
>> * a405b55 - [hotfix] [runtime] Guard async recovery operation in
>> try-catch (3 weeks ago) <Ufuk Celebi>
>> * 5f35d13 - [quickstart] fix links to documentation (3 weeks ago)
>> <Maximilian Michels>
>> * dc675f2 - [docs] Remove 'Working with Time' page (3 weeks ago) <Ufuk
>> Celebi>
>> * 95cd07c - [docs] Add description and illustration about Watermarks
>> in streams (3 weeks ago) <Stephan Ewen>
>> * 2831b7d - [docs] Add first steps to docs start page (3 weeks ago)
>> <Ufuk Celebi>
>> * a709f0a - [docs] Update stack figure on docs start page (3 weeks
>> ago) <Ufuk Celebi>
>> * bb9c1fa - [FLINK-3592] [docs] Update setup quickstart (3 weeks ago)
>> <Ufuk Celebi>
>> * d4c2a47 - [FLINK-3591] Replace Quickstart K-Means Example by
>> Streaming Example (3 weeks ago) <Aljoscha Krettek>
>> * 2f3711b - [docs] Move connectors page to batch guide (3 weeks ago)
>> <Ufuk Celebi>
>> * db860e4 - Update version and remove unused variables (3 weeks ago)
>> <Ufuk Celebi>
>> * 4f6a92d - [docs] update "build from source" page (3 weeks ago)
>> <Maximilian Michels>
>> * a08242f - [FLINK-3533] [docs] fix broken links to examples and
>> cluster execution in Gelly guide (4 weeks ago) <vasia>
>> * b376540 - [FLINK-3566] [FLINK-3563] [core] TypeExtraction input type
>> validation fixes (4 weeks ago) <twalthr>
>> * 2cde19b - [FLINK-3495] [tests] Disable RocksDB tests on Windows (4
>> weeks ago) <zentol>
>> * 5a63cbf - [FLINK-3491] [tests] Prevent URIException in HDFSCopyTest
>> and disable HDFSCopyUtilitiesTest on Windows (4 weeks ago) <zentol>
>> * 0e61ffc - [docs] Add documentation about Event Time, Timestamp
>> Assigners, Watermark Generation (4 weeks ago) <Stephan Ewen>
>> * 5c3c734 - [FLINK-3575] [docs] Update 'Working With State' section in
>> docs (4 weeks ago) <Aljoscha Krettek>
>> * 9158789 - [FLINK-3578] [streaming scala] Support RichFunctions for
>> Scala WindowFunction and AllWindowFunction (4 weeks ago) <Stephan
>> Ewen>
>> * fd0830e - [FLINK-3569] [build] Adjust test cases due to shading
>> plugin base directory changes (4 weeks ago) <Maximilian Michels>
>> * b289311 - [FLINK-3570] [runtime] Use InetAddress.getLocalHost() as
>> heuristic to find local address (4 weeks ago) <Till Rohrmann>
>> * f856855 - [FLINK-3484] Add setSlotSharingGroup documentation (4
>> weeks ago) <Aljo
>>

[Aljoscha Krettek-2]

Yes, that seems reasonable.

On Sat, 2 Apr 2016 at 13:14 Ufuk Celebi <[hidden email]> wrote:

> Thanks for the initial tests.
>
> I would say let's continue with this RC and wait for the user to
> provide the fix, which we can then include in 1.0.2 soon.
>
> On Fri, Apr 1, 2016 at 2:59 PM, Aljoscha Krettek <[hidden email]>
> wrote:
> > I ran the usual tests and the release seems fine. A user, however, found
> > this bug which seems to be a blocker:
> >
> https://issues.apache.org/jira/browse/FLINK-3688?jql=project%20%3D%20FLINK
> >
> > Should we maybe wait for the fix and then to another RC?
> >
> > On Thu, 31 Mar 2016 at 18:10 Ufuk Celebi <[hidden email]> wrote:
> >
> >> Dear Flink community,
> >>
> >> Please vote on releasing the following candidate as Apache Flink version
> >> 1.0.1.
> >>
> >> The commit to be voted on:
> >> 4afa401ab3c2b53de115d17a3157e8b80431dd10
> >>
> >> Branch:
> >> release-1.0.1-rc1 (see
> >>
> >>
> https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git;a=shortlog;h=refs/heads/release-1.0.1-rc1
> >> )
> >>
> >> The release artifacts to be voted on can be found at:
> >> http://home.apache.org/~uce/flink-1.0.1-rc1/
> >>
> >> The release artifacts are signed with the key with fingerprint 9D403309:
> >> http://www.apache.org/dist/flink/KEYS
> >>
> >> The staging repository for this release can be found at:
> >> https://repository.apache.org/content/repositories/orgapacheflink-1089
> >>
> >> -------------------------------------------------------------
> >>
> >> The vote is open for the next 72 hours and passes if a majority of at
> least
> >> three +1 PMC votes are cast.
> >>
> >> The vote ends on Tuesday April 5, 2016 (not counting the weekend).
> >>
> >> [ ] +1 Release this package as Apache Flink 1.0.1
> >> [ ] -1 Do not release this package because ...
> >>
> >> ===================================
> >>
> >> The following commits have been added since the 1.0.0 release, most
> >> notably a fix for the rolling HDFS file sink and support for
> >> RichFunctions in Scala.
> >>
> >> * 974c66e - [FLINK-3383] Backport 'Move snapshot deployment from
> >> Travis CI to ASF Jenkins' (6 hours ago) <Ufuk Celebi>
> >> * 630e77f - [FLINK-3684] [cep] Add proper watermark emission to CEP
> >> operators (6 hours ago) <Till Rohrmann>
> >> * dae29b4 - [FLINK-3682] [cep] Assign processing timestamp in CEP
> >> operators (23 hours ago) <Till Rohrmann>
> >> * a96e1a6 - [FLINK-3681] [cep, typeextractor] Generalize TypeExtractor
> >> to support more lambdas (23 hours ago) <Till Rohrmann>
> >> * ce448cd - [tools] Update copy files function in release script (25
> >> hours ago) <Ufuk Celebi>
> >> * 245f0d8 - [hotfix] [cep] Add sanity check for erroneously pruned
> >> elements (26 hours ago) <Till Rohrmann>
> >> * 2089029 - [FLINK-3651] Fix faulty RollingSink Restore (2 days ago)
> >> <Aljoscha Krettek>
> >> * 875cb44 - [FLINK-3676][docs] sync docs with the WebClient removal (2
> >> days ago) <Maximilian Michels>
> >> * 085f7b2 - [FLINK-3663] [kafka] Fix logPartitionInfo log statement (7
> >> days ago) <Niels Zeilemaker>
> >> * 5357ebe - [FLINK-3653] [docs] Add recovery.zookeeper.storageDir docs
> >> to config page (7 days ago) <Stefano Baghino>
> >> * 1ca4f36 - [FLINK-2444] Add tests for HadoopInputFormats (8 days ago)
> >> <Martin Liesenberg>
> >> * da989c4 - [FLINK-2445] Improve HadoopOutputFormatTests (8 days ago)
> >> <Martin Liesenberg>
> >> * edf343a - [FLINK-2445] Add tests for HadoopOutputFormats (8 days
> >> ago) <Ajay Bhat>
> >> * 1909bdb - [FLINK-3129] Bring infrastructure for ensuring interface
> >> stability in place (8 days ago) <Robert Metzger>
> >> * cd5773e - [FLINK-3179] [dataSet][optimizer] Log a WARN message if
> >> combiner is not added in front of PartitionOperator (9 days ago)
> >> <ramkrishna>
> >> * 0880c59 - [FLINK-3602] Fix TypeExtractor and add support for
> >> recursive types (9 days ago) <twalthr>
> >> * 954cdc1 - [hotfix] Fix ContinuousProcessingTimeTrigger (10 days ago)
> >> <Aljoscha Krettek>
> >> * 2c78be3 - [FLINK-3629] Fix quick start description for the
> >> ".timeWindow()" function call (2 weeks ago) <Li Fanxi>
> >> * 6749874 - [FLINK-3621] [docs] Improve documentation of memory
> >> configuration parameters (2 weeks ago) <Fabian Hueske>
> >> * 165065c - [FLINK-3333] [docs] Improve documentation of DataSet
> >> object-reuse modes. (2 weeks ago) <Fabian Hueske>
> >> * 3d8c7c1 - [FLINK-3472] [jdbc] Give a better exception if jdbc column
> >> has a null value (3 weeks ago) <zentol>
> >> * 43e95f2 - [FLINK-2671] [tests] Fix test instability in
> >> StreamCheckpointNotifierITCase (3 weeks ago) <Stephan Ewen>
> >> * f905503 - [FLINK-3594] [runtime] Make sure exceptions during
> >> checkpoints are handled properly (3 weeks ago) <Stephan Ewen>
> >> * a405b55 - [hotfix] [runtime] Guard async recovery operation in
> >> try-catch (3 weeks ago) <Ufuk Celebi>
> >> * 5f35d13 - [quickstart] fix links to documentation (3 weeks ago)
> >> <Maximilian Michels>
> >> * dc675f2 - [docs] Remove 'Working with Time' page (3 weeks ago) <Ufuk
> >> Celebi>
> >> * 95cd07c - [docs] Add description and illustration about Watermarks
> >> in streams (3 weeks ago) <Stephan Ewen>
> >> * 2831b7d - [docs] Add first steps to docs start page (3 weeks ago)
> >> <Ufuk Celebi>
> >> * a709f0a - [docs] Update stack figure on docs start page (3 weeks
> >> ago) <Ufuk Celebi>
> >> * bb9c1fa - [FLINK-3592] [docs] Update setup quickstart (3 weeks ago)
> >> <Ufuk Celebi>
> >> * d4c2a47 - [FLINK-3591] Replace Quickstart K-Means Example by
> >> Streaming Example (3 weeks ago) <Aljoscha Krettek>
> >> * 2f3711b - [docs] Move connectors page to batch guide (3 weeks ago)
> >> <Ufuk Celebi>
> >> * db860e4 - Update version and remove unused variables (3 weeks ago)
> >> <Ufuk Celebi>
> >> * 4f6a92d - [docs] update "build from source" page (3 weeks ago)
> >> <Maximilian Michels>
> >> * a08242f - [FLINK-3533] [docs] fix broken links to examples and
> >> cluster execution in Gelly guide (4 weeks ago) <vasia>
> >> * b376540 - [FLINK-3566] [FLINK-3563] [core] TypeExtraction input type
> >> validation fixes (4 weeks ago) <twalthr>
> >> * 2cde19b - [FLINK-3495] [tests] Disable RocksDB tests on Windows (4
> >> weeks ago) <zentol>
> >> * 5a63cbf - [FLINK-3491] [tests] Prevent URIException in HDFSCopyTest
> >> and disable HDFSCopyUtilitiesTest on Windows (4 weeks ago) <zentol>
> >> * 0e61ffc - [docs] Add documentation about Event Time, Timestamp
> >> Assigners, Watermark Generation (4 weeks ago) <Stephan Ewen>
> >> * 5c3c734 - [FLINK-3575] [docs] Update 'Working With State' section in
> >> docs (4 weeks ago) <Aljoscha Krettek>
> >> * 9158789 - [FLINK-3578] [streaming scala] Support RichFunctions for
> >> Scala WindowFunction and AllWindowFunction (4 weeks ago) <Stephan
> >> Ewen>
> >> * fd0830e - [FLINK-3569] [build] Adjust test cases due to shading
> >> plugin base directory changes (4 weeks ago) <Maximilian Michels>
> >> * b289311 - [FLINK-3570] [runtime] Use InetAddress.getLocalHost() as
> >> heuristic to find local address (4 weeks ago) <Till Rohrmann>
> >> * f856855 - [FLINK-3484] Add setSlotSharingGroup documentation (4
> >> weeks ago) <Aljo
> >>
>

[Robert Metzger]

One quick question regarding the release:
Are you intentionally releasing a 1.0.1 version of the force-shading module?

Since it is really a work around, I wounder if we should not release the
force-shading anymore and always depend on force-shading:1.0.0.


On Sat, Apr 2, 2016 at 9:25 PM, Aljoscha Krettek <[hidden email]>
wrote:

> Yes, that seems reasonable.
>
> On Sat, 2 Apr 2016 at 13:14 Ufuk Celebi <[hidden email]> wrote:
>
> > Thanks for the initial tests.
> >
> > I would say let's continue with this RC and wait for the user to
> > provide the fix, which we can then include in 1.0.2 soon.
> >
> > On Fri, Apr 1, 2016 at 2:59 PM, Aljoscha Krettek <[hidden email]>
> > wrote:
> > > I ran the usual tests and the release seems fine. A user, however,
> found
> > > this bug which seems to be a blocker:
> > >
> >
> https://issues.apache.org/jira/browse/FLINK-3688?jql=project%20%3D%20FLINK
> > >
> > > Should we maybe wait for the fix and then to another RC?
> > >
> > > On Thu, 31 Mar 2016 at 18:10 Ufuk Celebi <[hidden email]> wrote:
> > >
> > >> Dear Flink community,
> > >>
> > >> Please vote on releasing the following candidate as Apache Flink
> version
> > >> 1.0.1.
> > >>
> > >> The commit to be voted on:
> > >> 4afa401ab3c2b53de115d17a3157e8b80431dd10
> > >>
> > >> Branch:
> > >> release-1.0.1-rc1 (see
> > >>
> > >>
> >
> https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git;a=shortlog;h=refs/heads/release-1.0.1-rc1
> > >> )
> > >>
> > >> The release artifacts to be voted on can be found at:
> > >> http://home.apache.org/~uce/flink-1.0.1-rc1/
> > >>
> > >> The release artifacts are signed with the key with fingerprint
> 9D403309:
> > >> http://www.apache.org/dist/flink/KEYS
> > >>
> > >> The staging repository for this release can be found at:
> > >>
> https://repository.apache.org/content/repositories/orgapacheflink-1089
> > >>
> > >> -------------------------------------------------------------
> > >>
> > >> The vote is open for the next 72 hours and passes if a majority of at
> > least
> > >> three +1 PMC votes are cast.
> > >>
> > >> The vote ends on Tuesday April 5, 2016 (not counting the weekend).
> > >>
> > >> [ ] +1 Release this package as Apache Flink 1.0.1
> > >> [ ] -1 Do not release this package because ...
> > >>
> > >> ===================================
> > >>
> > >> The following commits have been added since the 1.0.0 release, most
> > >> notably a fix for the rolling HDFS file sink and support for
> > >> RichFunctions in Scala.
> > >>
> > >> * 974c66e - [FLINK-3383] Backport 'Move snapshot deployment from
> > >> Travis CI to ASF Jenkins' (6 hours ago) <Ufuk Celebi>
> > >> * 630e77f - [FLINK-3684] [cep] Add proper watermark emission to CEP
> > >> operators (6 hours ago) <Till Rohrmann>
> > >> * dae29b4 - [FLINK-3682] [cep] Assign processing timestamp in CEP
> > >> operators (23 hours ago) <Till Rohrmann>
> > >> * a96e1a6 - [FLINK-3681] [cep, typeextractor] Generalize TypeExtractor
> > >> to support more lambdas (23 hours ago) <Till Rohrmann>
> > >> * ce448cd - [tools] Update copy files function in release script (25
> > >> hours ago) <Ufuk Celebi>
> > >> * 245f0d8 - [hotfix] [cep] Add sanity check for erroneously pruned
> > >> elements (26 hours ago) <Till Rohrmann>
> > >> * 2089029 - [FLINK-3651] Fix faulty RollingSink Restore (2 days ago)
> > >> <Aljoscha Krettek>
> > >> * 875cb44 - [FLINK-3676][docs] sync docs with the WebClient removal (2
> > >> days ago) <Maximilian Michels>
> > >> * 085f7b2 - [FLINK-3663] [kafka] Fix logPartitionInfo log statement (7
> > >> days ago) <Niels Zeilemaker>
> > >> * 5357ebe - [FLINK-3653] [docs] Add recovery.zookeeper.storageDir docs
> > >> to config page (7 days ago) <Stefano Baghino>
> > >> * 1ca4f36 - [FLINK-2444] Add tests for HadoopInputFormats (8 days ago)
> > >> <Martin Liesenberg>
> > >> * da989c4 - [FLINK-2445] Improve HadoopOutputFormatTests (8 days ago)
> > >> <Martin Liesenberg>
> > >> * edf343a - [FLINK-2445] Add tests for HadoopOutputFormats (8 days
> > >> ago) <Ajay Bhat>
> > >> * 1909bdb - [FLINK-3129] Bring infrastructure for ensuring interface
> > >> stability in place (8 days ago) <Robert Metzger>
> > >> * cd5773e - [FLINK-3179] [dataSet][optimizer] Log a WARN message if
> > >> combiner is not added in front of PartitionOperator (9 days ago)
> > >> <ramkrishna>
> > >> * 0880c59 - [FLINK-3602] Fix TypeExtractor and add support for
> > >> recursive types (9 days ago) <twalthr>
> > >> * 954cdc1 - [hotfix] Fix ContinuousProcessingTimeTrigger (10 days ago)
> > >> <Aljoscha Krettek>
> > >> * 2c78be3 - [FLINK-3629] Fix quick start description for the
> > >> ".timeWindow()" function call (2 weeks ago) <Li Fanxi>
> > >> * 6749874 - [FLINK-3621] [docs] Improve documentation of memory
> > >> configuration parameters (2 weeks ago) <Fabian Hueske>
> > >> * 165065c - [FLINK-3333] [docs] Improve documentation of DataSet
> > >> object-reuse modes. (2 weeks ago) <Fabian Hueske>
> > >> * 3d8c7c1 - [FLINK-3472] [jdbc] Give a better exception if jdbc column
> > >> has a null value (3 weeks ago) <zentol>
> > >> * 43e95f2 - [FLINK-2671] [tests] Fix test instability in
> > >> StreamCheckpointNotifierITCase (3 weeks ago) <Stephan Ewen>
> > >> * f905503 - [FLINK-3594] [runtime] Make sure exceptions during
> > >> checkpoints are handled properly (3 weeks ago) <Stephan Ewen>
> > >> * a405b55 - [hotfix] [runtime] Guard async recovery operation in
> > >> try-catch (3 weeks ago) <Ufuk Celebi>
> > >> * 5f35d13 - [quickstart] fix links to documentation (3 weeks ago)
> > >> <Maximilian Michels>
> > >> * dc675f2 - [docs] Remove 'Working with Time' page (3 weeks ago) <Ufuk
> > >> Celebi>
> > >> * 95cd07c - [docs] Add description and illustration about Watermarks
> > >> in streams (3 weeks ago) <Stephan Ewen>
> > >> * 2831b7d - [docs] Add first steps to docs start page (3 weeks ago)
> > >> <Ufuk Celebi>
> > >> * a709f0a - [docs] Update stack figure on docs start page (3 weeks
> > >> ago) <Ufuk Celebi>
> > >> * bb9c1fa - [FLINK-3592] [docs] Update setup quickstart (3 weeks ago)
> > >> <Ufuk Celebi>
> > >> * d4c2a47 - [FLINK-3591] Replace Quickstart K-Means Example by
> > >> Streaming Example (3 weeks ago) <Aljoscha Krettek>
> > >> * 2f3711b - [docs] Move connectors page to batch guide (3 weeks ago)
> > >> <Ufuk Celebi>
> > >> * db860e4 - Update version and remove unused variables (3 weeks ago)
> > >> <Ufuk Celebi>
> > >> * 4f6a92d - [docs] update "build from source" page (3 weeks ago)
> > >> <Maximilian Michels>
> > >> * a08242f - [FLINK-3533] [docs] fix broken links to examples and
> > >> cluster execution in Gelly guide (4 weeks ago) <vasia>
> > >> * b376540 - [FLINK-3566] [FLINK-3563] [core] TypeExtraction input type
> > >> validation fixes (4 weeks ago) <twalthr>
> > >> * 2cde19b - [FLINK-3495] [tests] Disable RocksDB tests on Windows (4
> > >> weeks ago) <zentol>
> > >> * 5a63cbf - [FLINK-3491] [tests] Prevent URIException in HDFSCopyTest
> > >> and disable HDFSCopyUtilitiesTest on Windows (4 weeks ago) <zentol>
> > >> * 0e61ffc - [docs] Add documentation about Event Time, Timestamp
> > >> Assigners, Watermark Generation (4 weeks ago) <Stephan Ewen>
> > >> * 5c3c734 - [FLINK-3575] [docs] Update 'Working With State' section in
> > >> docs (4 weeks ago) <Aljoscha Krettek>
> > >> * 9158789 - [FLINK-3578] [streaming scala] Support RichFunctions for
> > >> Scala WindowFunction and AllWindowFunction (4 weeks ago) <Stephan
> > >> Ewen>
> > >> * fd0830e - [FLINK-3569] [build] Adjust test cases due to shading
> > >> plugin base directory changes (4 weeks ago) <Maximilian Michels>
> > >> * b289311 - [FLINK-3570] [runtime] Use InetAddress.getLocalHost() as
> > >> heuristic to find local address (4 weeks ago) <Till Rohrmann>
> > >> * f856855 - [FLINK-3484] Add setSlotSharingGroup documentation (4
> > >> weeks ago) <Aljo
> > >>
> >
>

[mxm]

The version of force-shading had to be a snapshot version, otherwise
the nightly deployment of snapshots wouldn't work. However, since we
have 1.0.0 already in place, we could revert the version to 1.0.0
again and skip the deployment from now on. I don't think it makes much
of a difference but it would reduce the number of deployed artifacts.
I could open a PR to make the changes.

On Mon, Apr 4, 2016 at 11:29 AM, Robert Metzger <[hidden email]> wrote:

> One quick question regarding the release:
> Are you intentionally releasing a 1.0.1 version of the force-shading module?
>
> Since it is really a work around, I wounder if we should not release the
> force-shading anymore and always depend on force-shading:1.0.0.
>
>
> On Sat, Apr 2, 2016 at 9:25 PM, Aljoscha Krettek <[hidden email]>
> wrote:
>
>> Yes, that seems reasonable.
>>
>> On Sat, 2 Apr 2016 at 13:14 Ufuk Celebi <[hidden email]> wrote:
>>
>> > Thanks for the initial tests.
>> >
>> > I would say let's continue with this RC and wait for the user to
>> > provide the fix, which we can then include in 1.0.2 soon.
>> >
>> > On Fri, Apr 1, 2016 at 2:59 PM, Aljoscha Krettek <[hidden email]>
>> > wrote:
>> > > I ran the usual tests and the release seems fine. A user, however,
>> found
>> > > this bug which seems to be a blocker:
>> > >
>> >
>> https://issues.apache.org/jira/browse/FLINK-3688?jql=project%20%3D%20FLINK
>> > >
>> > > Should we maybe wait for the fix and then to another RC?
>> > >
>> > > On Thu, 31 Mar 2016 at 18:10 Ufuk Celebi <[hidden email]> wrote:
>> > >
>> > >> Dear Flink community,
>> > >>
>> > >> Please vote on releasing the following candidate as Apache Flink
>> version
>> > >> 1.0.1.
>> > >>
>> > >> The commit to be voted on:
>> > >> 4afa401ab3c2b53de115d17a3157e8b80431dd10
>> > >>
>> > >> Branch:
>> > >> release-1.0.1-rc1 (see
>> > >>
>> > >>
>> >
>> https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git;a=shortlog;h=refs/heads/release-1.0.1-rc1
>> > >> )
>> > >>
>> > >> The release artifacts to be voted on can be found at:
>> > >> http://home.apache.org/~uce/flink-1.0.1-rc1/
>> > >>
>> > >> The release artifacts are signed with the key with fingerprint
>> 9D403309:
>> > >> http://www.apache.org/dist/flink/KEYS
>> > >>
>> > >> The staging repository for this release can be found at:
>> > >>
>> https://repository.apache.org/content/repositories/orgapacheflink-1089
>> > >>
>> > >> -------------------------------------------------------------
>> > >>
>> > >> The vote is open for the next 72 hours and passes if a majority of at
>> > least
>> > >> three +1 PMC votes are cast.
>> > >>
>> > >> The vote ends on Tuesday April 5, 2016 (not counting the weekend).
>> > >>
>> > >> [ ] +1 Release this package as Apache Flink 1.0.1
>> > >> [ ] -1 Do not release this package because ...
>> > >>
>> > >> ===================================
>> > >>
>> > >> The following commits have been added since the 1.0.0 release, most
>> > >> notably a fix for the rolling HDFS file sink and support for
>> > >> RichFunctions in Scala.
>> > >>
>> > >> * 974c66e - [FLINK-3383] Backport 'Move snapshot deployment from
>> > >> Travis CI to ASF Jenkins' (6 hours ago) <Ufuk Celebi>
>> > >> * 630e77f - [FLINK-3684] [cep] Add proper watermark emission to CEP
>> > >> operators (6 hours ago) <Till Rohrmann>
>> > >> * dae29b4 - [FLINK-3682] [cep] Assign processing timestamp in CEP
>> > >> operators (23 hours ago) <Till Rohrmann>
>> > >> * a96e1a6 - [FLINK-3681] [cep, typeextractor] Generalize TypeExtractor
>> > >> to support more lambdas (23 hours ago) <Till Rohrmann>
>> > >> * ce448cd - [tools] Update copy files function in release script (25
>> > >> hours ago) <Ufuk Celebi>
>> > >> * 245f0d8 - [hotfix] [cep] Add sanity check for erroneously pruned
>> > >> elements (26 hours ago) <Till Rohrmann>
>> > >> * 2089029 - [FLINK-3651] Fix faulty RollingSink Restore (2 days ago)
>> > >> <Aljoscha Krettek>
>> > >> * 875cb44 - [FLINK-3676][docs] sync docs with the WebClient removal (2
>> > >> days ago) <Maximilian Michels>
>> > >> * 085f7b2 - [FLINK-3663] [kafka] Fix logPartitionInfo log statement (7
>> > >> days ago) <Niels Zeilemaker>
>> > >> * 5357ebe - [FLINK-3653] [docs] Add recovery.zookeeper.storageDir docs
>> > >> to config page (7 days ago) <Stefano Baghino>
>> > >> * 1ca4f36 - [FLINK-2444] Add tests for HadoopInputFormats (8 days ago)
>> > >> <Martin Liesenberg>
>> > >> * da989c4 - [FLINK-2445] Improve HadoopOutputFormatTests (8 days ago)
>> > >> <Martin Liesenberg>
>> > >> * edf343a - [FLINK-2445] Add tests for HadoopOutputFormats (8 days
>> > >> ago) <Ajay Bhat>
>> > >> * 1909bdb - [FLINK-3129] Bring infrastructure for ensuring interface
>> > >> stability in place (8 days ago) <Robert Metzger>
>> > >> * cd5773e - [FLINK-3179] [dataSet][optimizer] Log a WARN message if
>> > >> combiner is not added in front of PartitionOperator (9 days ago)
>> > >> <ramkrishna>
>> > >> * 0880c59 - [FLINK-3602] Fix TypeExtractor and add support for
>> > >> recursive types (9 days ago) <twalthr>
>> > >> * 954cdc1 - [hotfix] Fix ContinuousProcessingTimeTrigger (10 days ago)
>> > >> <Aljoscha Krettek>
>> > >> * 2c78be3 - [FLINK-3629] Fix quick start description for the
>> > >> ".timeWindow()" function call (2 weeks ago) <Li Fanxi>
>> > >> * 6749874 - [FLINK-3621] [docs] Improve documentation of memory
>> > >> configuration parameters (2 weeks ago) <Fabian Hueske>
>> > >> * 165065c - [FLINK-3333] [docs] Improve documentation of DataSet
>> > >> object-reuse modes. (2 weeks ago) <Fabian Hueske>
>> > >> * 3d8c7c1 - [FLINK-3472] [jdbc] Give a better exception if jdbc column
>> > >> has a null value (3 weeks ago) <zentol>
>> > >> * 43e95f2 - [FLINK-2671] [tests] Fix test instability in
>> > >> StreamCheckpointNotifierITCase (3 weeks ago) <Stephan Ewen>
>> > >> * f905503 - [FLINK-3594] [runtime] Make sure exceptions during
>> > >> checkpoints are handled properly (3 weeks ago) <Stephan Ewen>
>> > >> * a405b55 - [hotfix] [runtime] Guard async recovery operation in
>> > >> try-catch (3 weeks ago) <Ufuk Celebi>
>> > >> * 5f35d13 - [quickstart] fix links to documentation (3 weeks ago)
>> > >> <Maximilian Michels>
>> > >> * dc675f2 - [docs] Remove 'Working with Time' page (3 weeks ago) <Ufuk
>> > >> Celebi>
>> > >> * 95cd07c - [docs] Add description and illustration about Watermarks
>> > >> in streams (3 weeks ago) <Stephan Ewen>
>> > >> * 2831b7d - [docs] Add first steps to docs start page (3 weeks ago)
>> > >> <Ufuk Celebi>
>> > >> * a709f0a - [docs] Update stack figure on docs start page (3 weeks
>> > >> ago) <Ufuk Celebi>
>> > >> * bb9c1fa - [FLINK-3592] [docs] Update setup quickstart (3 weeks ago)
>> > >> <Ufuk Celebi>
>> > >> * d4c2a47 - [FLINK-3591] Replace Quickstart K-Means Example by
>> > >> Streaming Example (3 weeks ago) <Aljoscha Krettek>
>> > >> * 2f3711b - [docs] Move connectors page to batch guide (3 weeks ago)
>> > >> <Ufuk Celebi>
>> > >> * db860e4 - Update version and remove unused variables (3 weeks ago)
>> > >> <Ufuk Celebi>
>> > >> * 4f6a92d - [docs] update "build from source" page (3 weeks ago)
>> > >> <Maximilian Michels>
>> > >> * a08242f - [FLINK-3533] [docs] fix broken links to examples and
>> > >> cluster execution in Gelly guide (4 weeks ago) <vasia>
>> > >> * b376540 - [FLINK-3566] [FLINK-3563] [core] TypeExtraction input type
>> > >> validation fixes (4 weeks ago) <twalthr>
>> > >> * 2cde19b - [FLINK-3495] [tests] Disable RocksDB tests on Windows (4
>> > >> weeks ago) <zentol>
>> > >> * 5a63cbf - [FLINK-3491] [tests] Prevent URIException in HDFSCopyTest
>> > >> and disable HDFSCopyUtilitiesTest on Windows (4 weeks ago) <zentol>
>> > >> * 0e61ffc - [docs] Add documentation about Event Time, Timestamp
>> > >> Assigners, Watermark Generation (4 weeks ago) <Stephan Ewen>
>> > >> * 5c3c734 - [FLINK-3575] [docs] Update 'Working With State' section in
>> > >> docs (4 weeks ago) <Aljoscha Krettek>
>> > >> * 9158789 - [FLINK-3578] [streaming scala] Support RichFunctions for
>> > >> Scala WindowFunction and AllWindowFunction (4 weeks ago) <Stephan
>> > >> Ewen>
>> > >> * fd0830e - [FLINK-3569] [build] Adjust test cases due to shading
>> > >> plugin base directory changes (4 weeks ago) <Maximilian Michels>
>> > >> * b289311 - [FLINK-3570] [runtime] Use InetAddress.getLocalHost() as
>> > >> heuristic to find local address (4 weeks ago) <Till Rohrmann>
>> > >> * f856855 - [FLINK-3484] Add setSlotSharingGroup documentation (4
>> > >> weeks ago) <Aljo
>> > >>
>> >
>>

[Ufuk Celebi-2]

The scripts in master and release-1.0 had different behaviour and I
went with the behaviour in master (e.g. version X-SNAPSHOT for
force-shading, which gets updated by the change version script).

I think that we can decide this independently of this release. No one
has this as a dependency anyways.

– Ufuk


On Mon, Apr 4, 2016 at 11:29 AM, Robert Metzger <[hidden email]> wrote:

> One quick question regarding the release:
> Are you intentionally releasing a 1.0.1 version of the force-shading module?
>
> Since it is really a work around, I wounder if we should not release the
> force-shading anymore and always depend on force-shading:1.0.0.
>
>
> On Sat, Apr 2, 2016 at 9:25 PM, Aljoscha Krettek <[hidden email]>
> wrote:
>
>> Yes, that seems reasonable.
>>
>> On Sat, 2 Apr 2016 at 13:14 Ufuk Celebi <[hidden email]> wrote:
>>
>> > Thanks for the initial tests.
>> >
>> > I would say let's continue with this RC and wait for the user to
>> > provide the fix, which we can then include in 1.0.2 soon.
>> >
>> > On Fri, Apr 1, 2016 at 2:59 PM, Aljoscha Krettek <[hidden email]>
>> > wrote:
>> > > I ran the usual tests and the release seems fine. A user, however,
>> found
>> > > this bug which seems to be a blocker:
>> > >
>> >
>> https://issues.apache.org/jira/browse/FLINK-3688?jql=project%20%3D%20FLINK
>> > >
>> > > Should we maybe wait for the fix and then to another RC?
>> > >
>> > > On Thu, 31 Mar 2016 at 18:10 Ufuk Celebi <[hidden email]> wrote:
>> > >
>> > >> Dear Flink community,
>> > >>
>> > >> Please vote on releasing the following candidate as Apache Flink
>> version
>> > >> 1.0.1.
>> > >>
>> > >> The commit to be voted on:
>> > >> 4afa401ab3c2b53de115d17a3157e8b80431dd10
>> > >>
>> > >> Branch:
>> > >> release-1.0.1-rc1 (see
>> > >>
>> > >>
>> >
>> https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git;a=shortlog;h=refs/heads/release-1.0.1-rc1
>> > >> )
>> > >>
>> > >> The release artifacts to be voted on can be found at:
>> > >> http://home.apache.org/~uce/flink-1.0.1-rc1/
>> > >>
>> > >> The release artifacts are signed with the key with fingerprint
>> 9D403309:
>> > >> http://www.apache.org/dist/flink/KEYS
>> > >>
>> > >> The staging repository for this release can be found at:
>> > >>
>> https://repository.apache.org/content/repositories/orgapacheflink-1089
>> > >>
>> > >> -------------------------------------------------------------
>> > >>
>> > >> The vote is open for the next 72 hours and passes if a majority of at
>> > least
>> > >> three +1 PMC votes are cast.
>> > >>
>> > >> The vote ends on Tuesday April 5, 2016 (not counting the weekend).
>> > >>
>> > >> [ ] +1 Release this package as Apache Flink 1.0.1
>> > >> [ ] -1 Do not release this package because ...
>> > >>
>> > >> ===================================
>> > >>
>> > >> The following commits have been added since the 1.0.0 release, most
>> > >> notably a fix for the rolling HDFS file sink and support for
>> > >> RichFunctions in Scala.
>> > >>
>> > >> * 974c66e - [FLINK-3383] Backport 'Move snapshot deployment from
>> > >> Travis CI to ASF Jenkins' (6 hours ago) <Ufuk Celebi>
>> > >> * 630e77f - [FLINK-3684] [cep] Add proper watermark emission to CEP
>> > >> operators (6 hours ago) <Till Rohrmann>
>> > >> * dae29b4 - [FLINK-3682] [cep] Assign processing timestamp in CEP
>> > >> operators (23 hours ago) <Till Rohrmann>
>> > >> * a96e1a6 - [FLINK-3681] [cep, typeextractor] Generalize TypeExtractor
>> > >> to support more lambdas (23 hours ago) <Till Rohrmann>
>> > >> * ce448cd - [tools] Update copy files function in release script (25
>> > >> hours ago) <Ufuk Celebi>
>> > >> * 245f0d8 - [hotfix] [cep] Add sanity check for erroneously pruned
>> > >> elements (26 hours ago) <Till Rohrmann>
>> > >> * 2089029 - [FLINK-3651] Fix faulty RollingSink Restore (2 days ago)
>> > >> <Aljoscha Krettek>
>> > >> * 875cb44 - [FLINK-3676][docs] sync docs with the WebClient removal (2
>> > >> days ago) <Maximilian Michels>
>> > >> * 085f7b2 - [FLINK-3663] [kafka] Fix logPartitionInfo log statement (7
>> > >> days ago) <Niels Zeilemaker>
>> > >> * 5357ebe - [FLINK-3653] [docs] Add recovery.zookeeper.storageDir docs
>> > >> to config page (7 days ago) <Stefano Baghino>
>> > >> * 1ca4f36 - [FLINK-2444] Add tests for HadoopInputFormats (8 days ago)
>> > >> <Martin Liesenberg>
>> > >> * da989c4 - [FLINK-2445] Improve HadoopOutputFormatTests (8 days ago)
>> > >> <Martin Liesenberg>
>> > >> * edf343a - [FLINK-2445] Add tests for HadoopOutputFormats (8 days
>> > >> ago) <Ajay Bhat>
>> > >> * 1909bdb - [FLINK-3129] Bring infrastructure for ensuring interface
>> > >> stability in place (8 days ago) <Robert Metzger>
>> > >> * cd5773e - [FLINK-3179] [dataSet][optimizer] Log a WARN message if
>> > >> combiner is not added in front of PartitionOperator (9 days ago)
>> > >> <ramkrishna>
>> > >> * 0880c59 - [FLINK-3602] Fix TypeExtractor and add support for
>> > >> recursive types (9 days ago) <twalthr>
>> > >> * 954cdc1 - [hotfix] Fix ContinuousProcessingTimeTrigger (10 days ago)
>> > >> <Aljoscha Krettek>
>> > >> * 2c78be3 - [FLINK-3629] Fix quick start description for the
>> > >> ".timeWindow()" function call (2 weeks ago) <Li Fanxi>
>> > >> * 6749874 - [FLINK-3621] [docs] Improve documentation of memory
>> > >> configuration parameters (2 weeks ago) <Fabian Hueske>
>> > >> * 165065c - [FLINK-3333] [docs] Improve documentation of DataSet
>> > >> object-reuse modes. (2 weeks ago) <Fabian Hueske>
>> > >> * 3d8c7c1 - [FLINK-3472] [jdbc] Give a better exception if jdbc column
>> > >> has a null value (3 weeks ago) <zentol>
>> > >> * 43e95f2 - [FLINK-2671] [tests] Fix test instability in
>> > >> StreamCheckpointNotifierITCase (3 weeks ago) <Stephan Ewen>
>> > >> * f905503 - [FLINK-3594] [runtime] Make sure exceptions during
>> > >> checkpoints are handled properly (3 weeks ago) <Stephan Ewen>
>> > >> * a405b55 - [hotfix] [runtime] Guard async recovery operation in
>> > >> try-catch (3 weeks ago) <Ufuk Celebi>
>> > >> * 5f35d13 - [quickstart] fix links to documentation (3 weeks ago)
>> > >> <Maximilian Michels>
>> > >> * dc675f2 - [docs] Remove 'Working with Time' page (3 weeks ago) <Ufuk
>> > >> Celebi>
>> > >> * 95cd07c - [docs] Add description and illustration about Watermarks
>> > >> in streams (3 weeks ago) <Stephan Ewen>
>> > >> * 2831b7d - [docs] Add first steps to docs start page (3 weeks ago)
>> > >> <Ufuk Celebi>
>> > >> * a709f0a - [docs] Update stack figure on docs start page (3 weeks
>> > >> ago) <Ufuk Celebi>
>> > >> * bb9c1fa - [FLINK-3592] [docs] Update setup quickstart (3 weeks ago)
>> > >> <Ufuk Celebi>
>> > >> * d4c2a47 - [FLINK-3591] Replace Quickstart K-Means Example by
>> > >> Streaming Example (3 weeks ago) <Aljoscha Krettek>
>> > >> * 2f3711b - [docs] Move connectors page to batch guide (3 weeks ago)
>> > >> <Ufuk Celebi>
>> > >> * db860e4 - Update version and remove unused variables (3 weeks ago)
>> > >> <Ufuk Celebi>
>> > >> * 4f6a92d - [docs] update "build from source" page (3 weeks ago)
>> > >> <Maximilian Michels>
>> > >> * a08242f - [FLINK-3533] [docs] fix broken links to examples and
>> > >> cluster execution in Gelly guide (4 weeks ago) <vasia>
>> > >> * b376540 - [FLINK-3566] [FLINK-3563] [core] TypeExtraction input type
>> > >> validation fixes (4 weeks ago) <twalthr>
>> > >> * 2cde19b - [FLINK-3495] [tests] Disable RocksDB tests on Windows (4
>> > >> weeks ago) <zentol>
>> > >> * 5a63cbf - [FLINK-3491] [tests] Prevent URIException in HDFSCopyTest
>> > >> and disable HDFSCopyUtilitiesTest on Windows (4 weeks ago) <zentol>
>> > >> * 0e61ffc - [docs] Add documentation about Event Time, Timestamp
>> > >> Assigners, Watermark Generation (4 weeks ago) <Stephan Ewen>
>> > >> * 5c3c734 - [FLINK-3575] [docs] Update 'Working With State' section in
>> > >> docs (4 weeks ago) <Aljoscha Krettek>
>> > >> * 9158789 - [FLINK-3578] [streaming scala] Support RichFunctions for
>> > >> Scala WindowFunction and AllWindowFunction (4 weeks ago) <Stephan
>> > >> Ewen>
>> > >> * fd0830e - [FLINK-3569] [build] Adjust test cases due to shading
>> > >> plugin base directory changes (4 weeks ago) <Maximilian Michels>
>> > >> * b289311 - [FLINK-3570] [runtime] Use InetAddress.getLocalHost() as
>> > >> heuristic to find local address (4 weeks ago) <Till Rohrmann>
>> > >> * f856855 - [FLINK-3484] Add setSlotSharingGroup documentation (4
>> > >> weeks ago) <Aljo
>> > >>
>> >
>>

[Robert Metzger]

We can probably move the force shading module into a (deactivated) build
profile and set the dependency to 1.0.0, so that it just looks like a
regular dependency.

On Mon, Apr 4, 2016 at 12:12 PM, Maximilian Michels <[hidden email]> wrote:

> The version of force-shading had to be a snapshot version, otherwise
> the nightly deployment of snapshots wouldn't work. However, since we
> have 1.0.0 already in place, we could revert the version to 1.0.0
> again and skip the deployment from now on. I don't think it makes much
> of a difference but it would reduce the number of deployed artifacts.
> I could open a PR to make the changes.
>
> On Mon, Apr 4, 2016 at 11:29 AM, Robert Metzger <[hidden email]>
> wrote:
> > One quick question regarding the release:
> > Are you intentionally releasing a 1.0.1 version of the force-shading
> module?
> >
> > Since it is really a work around, I wounder if we should not release the
> > force-shading anymore and always depend on force-shading:1.0.0.
> >
> >
> > On Sat, Apr 2, 2016 at 9:25 PM, Aljoscha Krettek <[hidden email]>
> > wrote:
> >
> >> Yes, that seems reasonable.
> >>
> >> On Sat, 2 Apr 2016 at 13:14 Ufuk Celebi <[hidden email]> wrote:
> >>
> >> > Thanks for the initial tests.
> >> >
> >> > I would say let's continue with this RC and wait for the user to
> >> > provide the fix, which we can then include in 1.0.2 soon.
> >> >
> >> > On Fri, Apr 1, 2016 at 2:59 PM, Aljoscha Krettek <[hidden email]
> >
> >> > wrote:
> >> > > I ran the usual tests and the release seems fine. A user, however,
> >> found
> >> > > this bug which seems to be a blocker:
> >> > >
> >> >
> >>
> https://issues.apache.org/jira/browse/FLINK-3688?jql=project%20%3D%20FLINK
> >> > >
> >> > > Should we maybe wait for the fix and then to another RC?
> >> > >
> >> > > On Thu, 31 Mar 2016 at 18:10 Ufuk Celebi <[hidden email]> wrote:
> >> > >
> >> > >> Dear Flink community,
> >> > >>
> >> > >> Please vote on releasing the following candidate as Apache Flink
> >> version
> >> > >> 1.0.1.
> >> > >>
> >> > >> The commit to be voted on:
> >> > >> 4afa401ab3c2b53de115d17a3157e8b80431dd10
> >> > >>
> >> > >> Branch:
> >> > >> release-1.0.1-rc1 (see
> >> > >>
> >> > >>
> >> >
> >>
> https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git;a=shortlog;h=refs/heads/release-1.0.1-rc1
> >> > >> )
> >> > >>
> >> > >> The release artifacts to be voted on can be found at:
> >> > >> http://home.apache.org/~uce/flink-1.0.1-rc1/
> >> > >>
> >> > >> The release artifacts are signed with the key with fingerprint
> >> 9D403309:
> >> > >> http://www.apache.org/dist/flink/KEYS
> >> > >>
> >> > >> The staging repository for this release can be found at:
> >> > >>
> >> https://repository.apache.org/content/repositories/orgapacheflink-1089
> >> > >>
> >> > >> -------------------------------------------------------------
> >> > >>
> >> > >> The vote is open for the next 72 hours and passes if a majority of
> at
> >> > least
> >> > >> three +1 PMC votes are cast.
> >> > >>
> >> > >> The vote ends on Tuesday April 5, 2016 (not counting the weekend).
> >> > >>
> >> > >> [ ] +1 Release this package as Apache Flink 1.0.1
> >> > >> [ ] -1 Do not release this package because ...
> >> > >>
> >> > >> ===================================
> >> > >>
> >> > >> The following commits have been added since the 1.0.0 release, most
> >> > >> notably a fix for the rolling HDFS file sink and support for
> >> > >> RichFunctions in Scala.
> >> > >>
> >> > >> * 974c66e - [FLINK-3383] Backport 'Move snapshot deployment from
> >> > >> Travis CI to ASF Jenkins' (6 hours ago) <Ufuk Celebi>
> >> > >> * 630e77f - [FLINK-3684] [cep] Add proper watermark emission to CEP
> >> > >> operators (6 hours ago) <Till Rohrmann>
> >> > >> * dae29b4 - [FLINK-3682] [cep] Assign processing timestamp in CEP
> >> > >> operators (23 hours ago) <Till Rohrmann>
> >> > >> * a96e1a6 - [FLINK-3681] [cep, typeextractor] Generalize
> TypeExtractor
> >> > >> to support more lambdas (23 hours ago) <Till Rohrmann>
> >> > >> * ce448cd - [tools] Update copy files function in release script
> (25
> >> > >> hours ago) <Ufuk Celebi>
> >> > >> * 245f0d8 - [hotfix] [cep] Add sanity check for erroneously pruned
> >> > >> elements (26 hours ago) <Till Rohrmann>
> >> > >> * 2089029 - [FLINK-3651] Fix faulty RollingSink Restore (2 days
> ago)
> >> > >> <Aljoscha Krettek>
> >> > >> * 875cb44 - [FLINK-3676][docs] sync docs with the WebClient
> removal (2
> >> > >> days ago) <Maximilian Michels>
> >> > >> * 085f7b2 - [FLINK-3663] [kafka] Fix logPartitionInfo log
> statement (7
> >> > >> days ago) <Niels Zeilemaker>
> >> > >> * 5357ebe - [FLINK-3653] [docs] Add recovery.zookeeper.storageDir
> docs
> >> > >> to config page (7 days ago) <Stefano Baghino>
> >> > >> * 1ca4f36 - [FLINK-2444] Add tests for HadoopInputFormats (8 days
> ago)
> >> > >> <Martin Liesenberg>
> >> > >> * da989c4 - [FLINK-2445] Improve HadoopOutputFormatTests (8 days
> ago)
> >> > >> <Martin Liesenberg>
> >> > >> * edf343a - [FLINK-2445] Add tests for HadoopOutputFormats (8 days
> >> > >> ago) <Ajay Bhat>
> >> > >> * 1909bdb - [FLINK-3129] Bring infrastructure for ensuring
> interface
> >> > >> stability in place (8 days ago) <Robert Metzger>
> >> > >> * cd5773e - [FLINK-3179] [dataSet][optimizer] Log a WARN message if
> >> > >> combiner is not added in front of PartitionOperator (9 days ago)
> >> > >> <ramkrishna>
> >> > >> * 0880c59 - [FLINK-3602] Fix TypeExtractor and add support for
> >> > >> recursive types (9 days ago) <twalthr>
> >> > >> * 954cdc1 - [hotfix] Fix ContinuousProcessingTimeTrigger (10 days
> ago)
> >> > >> <Aljoscha Krettek>
> >> > >> * 2c78be3 - [FLINK-3629] Fix quick start description for the
> >> > >> ".timeWindow()" function call (2 weeks ago) <Li Fanxi>
> >> > >> * 6749874 - [FLINK-3621] [docs] Improve documentation of memory
> >> > >> configuration parameters (2 weeks ago) <Fabian Hueske>
> >> > >> * 165065c - [FLINK-3333] [docs] Improve documentation of DataSet
> >> > >> object-reuse modes. (2 weeks ago) <Fabian Hueske>
> >> > >> * 3d8c7c1 - [FLINK-3472] [jdbc] Give a better exception if jdbc
> column
> >> > >> has a null value (3 weeks ago) <zentol>
> >> > >> * 43e95f2 - [FLINK-2671] [tests] Fix test instability in
> >> > >> StreamCheckpointNotifierITCase (3 weeks ago) <Stephan Ewen>
> >> > >> * f905503 - [FLINK-3594] [runtime] Make sure exceptions during
> >> > >> checkpoints are handled properly (3 weeks ago) <Stephan Ewen>
> >> > >> * a405b55 - [hotfix] [runtime] Guard async recovery operation in
> >> > >> try-catch (3 weeks ago) <Ufuk Celebi>
> >> > >> * 5f35d13 - [quickstart] fix links to documentation (3 weeks ago)
> >> > >> <Maximilian Michels>
> >> > >> * dc675f2 - [docs] Remove 'Working with Time' page (3 weeks ago)
> <Ufuk
> >> > >> Celebi>
> >> > >> * 95cd07c - [docs] Add description and illustration about
> Watermarks
> >> > >> in streams (3 weeks ago) <Stephan Ewen>
> >> > >> * 2831b7d - [docs] Add first steps to docs start page (3 weeks ago)
> >> > >> <Ufuk Celebi>
> >> > >> * a709f0a - [docs] Update stack figure on docs start page (3 weeks
> >> > >> ago) <Ufuk Celebi>
> >> > >> * bb9c1fa - [FLINK-3592] [docs] Update setup quickstart (3 weeks
> ago)
> >> > >> <Ufuk Celebi>
> >> > >> * d4c2a47 - [FLINK-3591] Replace Quickstart K-Means Example by
> >> > >> Streaming Example (3 weeks ago) <Aljoscha Krettek>
> >> > >> * 2f3711b - [docs] Move connectors page to batch guide (3 weeks
> ago)
> >> > >> <Ufuk Celebi>
> >> > >> * db860e4 - Update version and remove unused variables (3 weeks
> ago)
> >> > >> <Ufuk Celebi>
> >> > >> * 4f6a92d - [docs] update "build from source" page (3 weeks ago)
> >> > >> <Maximilian Michels>
> >> > >> * a08242f - [FLINK-3533] [docs] fix broken links to examples and
> >> > >> cluster execution in Gelly guide (4 weeks ago) <vasia>
> >> > >> * b376540 - [FLINK-3566] [FLINK-3563] [core] TypeExtraction input
> type
> >> > >> validation fixes (4 weeks ago) <twalthr>
> >> > >> * 2cde19b - [FLINK-3495] [tests] Disable RocksDB tests on Windows
> (4
> >> > >> weeks ago) <zentol>
> >> > >> * 5a63cbf - [FLINK-3491] [tests] Prevent URIException in
> HDFSCopyTest
> >> > >> and disable HDFSCopyUtilitiesTest on Windows (4 weeks ago) <zentol>
> >> > >> * 0e61ffc - [docs] Add documentation about Event Time, Timestamp
> >> > >> Assigners, Watermark Generation (4 weeks ago) <Stephan Ewen>
> >> > >> * 5c3c734 - [FLINK-3575] [docs] Update 'Working With State'
> section in
> >> > >> docs (4 weeks ago) <Aljoscha Krettek>
> >> > >> * 9158789 - [FLINK-3578] [streaming scala] Support RichFunctions
> for
> >> > >> Scala WindowFunction and AllWindowFunction (4 weeks ago) <Stephan
> >> > >> Ewen>
> >> > >> * fd0830e - [FLINK-3569] [build] Adjust test cases due to shading
> >> > >> plugin base directory changes (4 weeks ago) <Maximilian Michels>
> >> > >> * b289311 - [FLINK-3570] [runtime] Use InetAddress.getLocalHost()
> as
> >> > >> heuristic to find local address (4 weeks ago) <Till Rohrmann>
> >> > >> * f856855 - [FLINK-3484] Add setSlotSharingGroup documentation (4
> >> > >> weeks ago) <Aljo
> >> > >>
> >> >
> >>
>

[Robert Metzger]

+1 for the 1.0.1 release:

- I checked the staged files for maven. The quickstarts look good, other
modules seem to have correct scala versions
- I ran the Kafka examples (locally, against Kafka 0.8)
- Started a yarn session on a CDH 5.4.4 cluster (6 nodes) & ran a job with
rocksdb state, watermarks and event time (build from the staging repo)

On Mon, Apr 4, 2016 at 12:15 PM, Ufuk Celebi <[hidden email]> wrote:

> The scripts in master and release-1.0 had different behaviour and I
> went with the behaviour in master (e.g. version X-SNAPSHOT for
> force-shading, which gets updated by the change version script).
>
> I think that we can decide this independently of this release. No one
> has this as a dependency anyways.
>
> – Ufuk
>
>
> On Mon, Apr 4, 2016 at 11:29 AM, Robert Metzger <[hidden email]>
> wrote:
> > One quick question regarding the release:
> > Are you intentionally releasing a 1.0.1 version of the force-shading
> module?
> >
> > Since it is really a work around, I wounder if we should not release the
> > force-shading anymore and always depend on force-shading:1.0.0.
> >
> >
> > On Sat, Apr 2, 2016 at 9:25 PM, Aljoscha Krettek <[hidden email]>
> > wrote:
> >
> >> Yes, that seems reasonable.
> >>
> >> On Sat, 2 Apr 2016 at 13:14 Ufuk Celebi <[hidden email]> wrote:
> >>
> >> > Thanks for the initial tests.
> >> >
> >> > I would say let's continue with this RC and wait for the user to
> >> > provide the fix, which we can then include in 1.0.2 soon.
> >> >
> >> > On Fri, Apr 1, 2016 at 2:59 PM, Aljoscha Krettek <[hidden email]
> >
> >> > wrote:
> >> > > I ran the usual tests and the release seems fine. A user, however,
> >> found
> >> > > this bug which seems to be a blocker:
> >> > >
> >> >
> >>
> https://issues.apache.org/jira/browse/FLINK-3688?jql=project%20%3D%20FLINK
> >> > >
> >> > > Should we maybe wait for the fix and then to another RC?
> >> > >
> >> > > On Thu, 31 Mar 2016 at 18:10 Ufuk Celebi <[hidden email]> wrote:
> >> > >
> >> > >> Dear Flink community,
> >> > >>
> >> > >> Please vote on releasing the following candidate as Apache Flink
> >> version
> >> > >> 1.0.1.
> >> > >>
> >> > >> The commit to be voted on:
> >> > >> 4afa401ab3c2b53de115d17a3157e8b80431dd10
> >> > >>
> >> > >> Branch:
> >> > >> release-1.0.1-rc1 (see
> >> > >>
> >> > >>
> >> >
> >>
> https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git;a=shortlog;h=refs/heads/release-1.0.1-rc1
> >> > >> )
> >> > >>
> >> > >> The release artifacts to be voted on can be found at:
> >> > >> http://home.apache.org/~uce/flink-1.0.1-rc1/
> >> > >>
> >> > >> The release artifacts are signed with the key with fingerprint
> >> 9D403309:
> >> > >> http://www.apache.org/dist/flink/KEYS
> >> > >>
> >> > >> The staging repository for this release can be found at:
> >> > >>
> >> https://repository.apache.org/content/repositories/orgapacheflink-1089
> >> > >>
> >> > >> -------------------------------------------------------------
> >> > >>
> >> > >> The vote is open for the next 72 hours and passes if a majority of
> at
> >> > least
> >> > >> three +1 PMC votes are cast.
> >> > >>
> >> > >> The vote ends on Tuesday April 5, 2016 (not counting the weekend).
> >> > >>
> >> > >> [ ] +1 Release this package as Apache Flink 1.0.1
> >> > >> [ ] -1 Do not release this package because ...
> >> > >>
> >> > >> ===================================
> >> > >>
> >> > >> The following commits have been added since the 1.0.0 release, most
> >> > >> notably a fix for the rolling HDFS file sink and support for
> >> > >> RichFunctions in Scala.
> >> > >>
> >> > >> * 974c66e - [FLINK-3383] Backport 'Move snapshot deployment from
> >> > >> Travis CI to ASF Jenkins' (6 hours ago) <Ufuk Celebi>
> >> > >> * 630e77f - [FLINK-3684] [cep] Add proper watermark emission to CEP
> >> > >> operators (6 hours ago) <Till Rohrmann>
> >> > >> * dae29b4 - [FLINK-3682] [cep] Assign processing timestamp in CEP
> >> > >> operators (23 hours ago) <Till Rohrmann>
> >> > >> * a96e1a6 - [FLINK-3681] [cep, typeextractor] Generalize
> TypeExtractor
> >> > >> to support more lambdas (23 hours ago) <Till Rohrmann>
> >> > >> * ce448cd - [tools] Update copy files function in release script
> (25
> >> > >> hours ago) <Ufuk Celebi>
> >> > >> * 245f0d8 - [hotfix] [cep] Add sanity check for erroneously pruned
> >> > >> elements (26 hours ago) <Till Rohrmann>
> >> > >> * 2089029 - [FLINK-3651] Fix faulty RollingSink Restore (2 days
> ago)
> >> > >> <Aljoscha Krettek>
> >> > >> * 875cb44 - [FLINK-3676][docs] sync docs with the WebClient
> removal (2
> >> > >> days ago) <Maximilian Michels>
> >> > >> * 085f7b2 - [FLINK-3663] [kafka] Fix logPartitionInfo log
> statement (7
> >> > >> days ago) <Niels Zeilemaker>
> >> > >> * 5357ebe - [FLINK-3653] [docs] Add recovery.zookeeper.storageDir
> docs
> >> > >> to config page (7 days ago) <Stefano Baghino>
> >> > >> * 1ca4f36 - [FLINK-2444] Add tests for HadoopInputFormats (8 days
> ago)
> >> > >> <Martin Liesenberg>
> >> > >> * da989c4 - [FLINK-2445] Improve HadoopOutputFormatTests (8 days
> ago)
> >> > >> <Martin Liesenberg>
> >> > >> * edf343a - [FLINK-2445] Add tests for HadoopOutputFormats (8 days
> >> > >> ago) <Ajay Bhat>
> >> > >> * 1909bdb - [FLINK-3129] Bring infrastructure for ensuring
> interface
> >> > >> stability in place (8 days ago) <Robert Metzger>
> >> > >> * cd5773e - [FLINK-3179] [dataSet][optimizer] Log a WARN message if
> >> > >> combiner is not added in front of PartitionOperator (9 days ago)
> >> > >> <ramkrishna>
> >> > >> * 0880c59 - [FLINK-3602] Fix TypeExtractor and add support for
> >> > >> recursive types (9 days ago) <twalthr>
> >> > >> * 954cdc1 - [hotfix] Fix ContinuousProcessingTimeTrigger (10 days
> ago)
> >> > >> <Aljoscha Krettek>
> >> > >> * 2c78be3 - [FLINK-3629] Fix quick start description for the
> >> > >> ".timeWindow()" function call (2 weeks ago) <Li Fanxi>
> >> > >> * 6749874 - [FLINK-3621] [docs] Improve documentation of memory
> >> > >> configuration parameters (2 weeks ago) <Fabian Hueske>
> >> > >> * 165065c - [FLINK-3333] [docs] Improve documentation of DataSet
> >> > >> object-reuse modes. (2 weeks ago) <Fabian Hueske>
> >> > >> * 3d8c7c1 - [FLINK-3472] [jdbc] Give a better exception if jdbc
> column
> >> > >> has a null value (3 weeks ago) <zentol>
> >> > >> * 43e95f2 - [FLINK-2671] [tests] Fix test instability in
> >> > >> StreamCheckpointNotifierITCase (3 weeks ago) <Stephan Ewen>
> >> > >> * f905503 - [FLINK-3594] [runtime] Make sure exceptions during
> >> > >> checkpoints are handled properly (3 weeks ago) <Stephan Ewen>
> >> > >> * a405b55 - [hotfix] [runtime] Guard async recovery operation in
> >> > >> try-catch (3 weeks ago) <Ufuk Celebi>
> >> > >> * 5f35d13 - [quickstart] fix links to documentation (3 weeks ago)
> >> > >> <Maximilian Michels>
> >> > >> * dc675f2 - [docs] Remove 'Working with Time' page (3 weeks ago)
> <Ufuk
> >> > >> Celebi>
> >> > >> * 95cd07c - [docs] Add description and illustration about
> Watermarks
> >> > >> in streams (3 weeks ago) <Stephan Ewen>
> >> > >> * 2831b7d - [docs] Add first steps to docs start page (3 weeks ago)
> >> > >> <Ufuk Celebi>
> >> > >> * a709f0a - [docs] Update stack figure on docs start page (3 weeks
> >> > >> ago) <Ufuk Celebi>
> >> > >> * bb9c1fa - [FLINK-3592] [docs] Update setup quickstart (3 weeks
> ago)
> >> > >> <Ufuk Celebi>
> >> > >> * d4c2a47 - [FLINK-3591] Replace Quickstart K-Means Example by
> >> > >> Streaming Example (3 weeks ago) <Aljoscha Krettek>
> >> > >> * 2f3711b - [docs] Move connectors page to batch guide (3 weeks
> ago)
> >> > >> <Ufuk Celebi>
> >> > >> * db860e4 - Update version and remove unused variables (3 weeks
> ago)
> >> > >> <Ufuk Celebi>
> >> > >> * 4f6a92d - [docs] update "build from source" page (3 weeks ago)
> >> > >> <Maximilian Michels>
> >> > >> * a08242f - [FLINK-3533] [docs] fix broken links to examples and
> >> > >> cluster execution in Gelly guide (4 weeks ago) <vasia>
> >> > >> * b376540 - [FLINK-3566] [FLINK-3563] [core] TypeExtraction input
> type
> >> > >> validation fixes (4 weeks ago) <twalthr>
> >> > >> * 2cde19b - [FLINK-3495] [tests] Disable RocksDB tests on Windows
> (4
> >> > >> weeks ago) <zentol>
> >> > >> * 5a63cbf - [FLINK-3491] [tests] Prevent URIException in
> HDFSCopyTest
> >> > >> and disable HDFSCopyUtilitiesTest on Windows (4 weeks ago) <zentol>
> >> > >> * 0e61ffc - [docs] Add documentation about Event Time, Timestamp
> >> > >> Assigners, Watermark Generation (4 weeks ago) <Stephan Ewen>
> >> > >> * 5c3c734 - [FLINK-3575] [docs] Update 'Working With State'
> section in
> >> > >> docs (4 weeks ago) <Aljoscha Krettek>
> >> > >> * 9158789 - [FLINK-3578] [streaming scala] Support RichFunctions
> for
> >> > >> Scala WindowFunction and AllWindowFunction (4 weeks ago) <Stephan
> >> > >> Ewen>
> >> > >> * fd0830e - [FLINK-3569] [build] Adjust test cases due to shading
> >> > >> plugin base directory changes (4 weeks ago) <Maximilian Michels>
> >> > >> * b289311 - [FLINK-3570] [runtime] Use InetAddress.getLocalHost()
> as
> >> > >> heuristic to find local address (4 weeks ago) <Till Rohrmann>
> >> > >> * f856855 - [FLINK-3484] Add setSlotSharingGroup documentation (4
> >> > >> weeks ago) <Aljo
> >> > >>
> >> >
> >>
>

[mxm]

On Mon, Apr 4, 2016 at 12:16 PM, Robert Metzger <[hidden email]> wrote:
> We can probably move the force shading module into a (deactivated) build
> profile and set the dependency to 1.0.0, so that it just looks like a
> regular dependency.

That's what I suggested. It's not a blocker for the release. Just a
minor improvement.

On Mon, Apr 4, 2016 at 12:16 PM, Robert Metzger <[hidden email]> wrote:

> We can probably move the force shading module into a (deactivated) build
> profile and set the dependency to 1.0.0, so that it just looks like a
> regular dependency.
>
> On Mon, Apr 4, 2016 at 12:12 PM, Maximilian Michels <[hidden email]> wrote:
>
>> The version of force-shading had to be a snapshot version, otherwise
>> the nightly deployment of snapshots wouldn't work. However, since we
>> have 1.0.0 already in place, we could revert the version to 1.0.0
>> again and skip the deployment from now on. I don't think it makes much
>> of a difference but it would reduce the number of deployed artifacts.
>> I could open a PR to make the changes.
>>
>> On Mon, Apr 4, 2016 at 11:29 AM, Robert Metzger <[hidden email]>
>> wrote:
>> > One quick question regarding the release:
>> > Are you intentionally releasing a 1.0.1 version of the force-shading
>> module?
>> >
>> > Since it is really a work around, I wounder if we should not release the
>> > force-shading anymore and always depend on force-shading:1.0.0.
>> >
>> >
>> > On Sat, Apr 2, 2016 at 9:25 PM, Aljoscha Krettek <[hidden email]>
>> > wrote:
>> >
>> >> Yes, that seems reasonable.
>> >>
>> >> On Sat, 2 Apr 2016 at 13:14 Ufuk Celebi <[hidden email]> wrote:
>> >>
>> >> > Thanks for the initial tests.
>> >> >
>> >> > I would say let's continue with this RC and wait for the user to
>> >> > provide the fix, which we can then include in 1.0.2 soon.
>> >> >
>> >> > On Fri, Apr 1, 2016 at 2:59 PM, Aljoscha Krettek <[hidden email]
>> >
>> >> > wrote:
>> >> > > I ran the usual tests and the release seems fine. A user, however,
>> >> found
>> >> > > this bug which seems to be a blocker:
>> >> > >
>> >> >
>> >>
>> https://issues.apache.org/jira/browse/FLINK-3688?jql=project%20%3D%20FLINK
>> >> > >
>> >> > > Should we maybe wait for the fix and then to another RC?
>> >> > >
>> >> > > On Thu, 31 Mar 2016 at 18:10 Ufuk Celebi <[hidden email]> wrote:
>> >> > >
>> >> > >> Dear Flink community,
>> >> > >>
>> >> > >> Please vote on releasing the following candidate as Apache Flink
>> >> version
>> >> > >> 1.0.1.
>> >> > >>
>> >> > >> The commit to be voted on:
>> >> > >> 4afa401ab3c2b53de115d17a3157e8b80431dd10
>> >> > >>
>> >> > >> Branch:
>> >> > >> release-1.0.1-rc1 (see
>> >> > >>
>> >> > >>
>> >> >
>> >>
>> https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git;a=shortlog;h=refs/heads/release-1.0.1-rc1
>> >> > >> )
>> >> > >>
>> >> > >> The release artifacts to be voted on can be found at:
>> >> > >> http://home.apache.org/~uce/flink-1.0.1-rc1/
>> >> > >>
>> >> > >> The release artifacts are signed with the key with fingerprint
>> >> 9D403309:
>> >> > >> http://www.apache.org/dist/flink/KEYS
>> >> > >>
>> >> > >> The staging repository for this release can be found at:
>> >> > >>
>> >> https://repository.apache.org/content/repositories/orgapacheflink-1089
>> >> > >>
>> >> > >> -------------------------------------------------------------
>> >> > >>
>> >> > >> The vote is open for the next 72 hours and passes if a majority of
>> at
>> >> > least
>> >> > >> three +1 PMC votes are cast.
>> >> > >>
>> >> > >> The vote ends on Tuesday April 5, 2016 (not counting the weekend).
>> >> > >>
>> >> > >> [ ] +1 Release this package as Apache Flink 1.0.1
>> >> > >> [ ] -1 Do not release this package because ...
>> >> > >>
>> >> > >> ===================================
>> >> > >>
>> >> > >> The following commits have been added since the 1.0.0 release, most
>> >> > >> notably a fix for the rolling HDFS file sink and support for
>> >> > >> RichFunctions in Scala.
>> >> > >>
>> >> > >> * 974c66e - [FLINK-3383] Backport 'Move snapshot deployment from
>> >> > >> Travis CI to ASF Jenkins' (6 hours ago) <Ufuk Celebi>
>> >> > >> * 630e77f - [FLINK-3684] [cep] Add proper watermark emission to CEP
>> >> > >> operators (6 hours ago) <Till Rohrmann>
>> >> > >> * dae29b4 - [FLINK-3682] [cep] Assign processing timestamp in CEP
>> >> > >> operators (23 hours ago) <Till Rohrmann>
>> >> > >> * a96e1a6 - [FLINK-3681] [cep, typeextractor] Generalize
>> TypeExtractor
>> >> > >> to support more lambdas (23 hours ago) <Till Rohrmann>
>> >> > >> * ce448cd - [tools] Update copy files function in release script
>> (25
>> >> > >> hours ago) <Ufuk Celebi>
>> >> > >> * 245f0d8 - [hotfix] [cep] Add sanity check for erroneously pruned
>> >> > >> elements (26 hours ago) <Till Rohrmann>
>> >> > >> * 2089029 - [FLINK-3651] Fix faulty RollingSink Restore (2 days
>> ago)
>> >> > >> <Aljoscha Krettek>
>> >> > >> * 875cb44 - [FLINK-3676][docs] sync docs with the WebClient
>> removal (2
>> >> > >> days ago) <Maximilian Michels>
>> >> > >> * 085f7b2 - [FLINK-3663] [kafka] Fix logPartitionInfo log
>> statement (7
>> >> > >> days ago) <Niels Zeilemaker>
>> >> > >> * 5357ebe - [FLINK-3653] [docs] Add recovery.zookeeper.storageDir
>> docs
>> >> > >> to config page (7 days ago) <Stefano Baghino>
>> >> > >> * 1ca4f36 - [FLINK-2444] Add tests for HadoopInputFormats (8 days
>> ago)
>> >> > >> <Martin Liesenberg>
>> >> > >> * da989c4 - [FLINK-2445] Improve HadoopOutputFormatTests (8 days
>> ago)
>> >> > >> <Martin Liesenberg>
>> >> > >> * edf343a - [FLINK-2445] Add tests for HadoopOutputFormats (8 days
>> >> > >> ago) <Ajay Bhat>
>> >> > >> * 1909bdb - [FLINK-3129] Bring infrastructure for ensuring
>> interface
>> >> > >> stability in place (8 days ago) <Robert Metzger>
>> >> > >> * cd5773e - [FLINK-3179] [dataSet][optimizer] Log a WARN message if
>> >> > >> combiner is not added in front of PartitionOperator (9 days ago)
>> >> > >> <ramkrishna>
>> >> > >> * 0880c59 - [FLINK-3602] Fix TypeExtractor and add support for
>> >> > >> recursive types (9 days ago) <twalthr>
>> >> > >> * 954cdc1 - [hotfix] Fix ContinuousProcessingTimeTrigger (10 days
>> ago)
>> >> > >> <Aljoscha Krettek>
>> >> > >> * 2c78be3 - [FLINK-3629] Fix quick start description for the
>> >> > >> ".timeWindow()" function call (2 weeks ago) <Li Fanxi>
>> >> > >> * 6749874 - [FLINK-3621] [docs] Improve documentation of memory
>> >> > >> configuration parameters (2 weeks ago) <Fabian Hueske>
>> >> > >> * 165065c - [FLINK-3333] [docs] Improve documentation of DataSet
>> >> > >> object-reuse modes. (2 weeks ago) <Fabian Hueske>
>> >> > >> * 3d8c7c1 - [FLINK-3472] [jdbc] Give a better exception if jdbc
>> column
>> >> > >> has a null value (3 weeks ago) <zentol>
>> >> > >> * 43e95f2 - [FLINK-2671] [tests] Fix test instability in
>> >> > >> StreamCheckpointNotifierITCase (3 weeks ago) <Stephan Ewen>
>> >> > >> * f905503 - [FLINK-3594] [runtime] Make sure exceptions during
>> >> > >> checkpoints are handled properly (3 weeks ago) <Stephan Ewen>
>> >> > >> * a405b55 - [hotfix] [runtime] Guard async recovery operation in
>> >> > >> try-catch (3 weeks ago) <Ufuk Celebi>
>> >> > >> * 5f35d13 - [quickstart] fix links to documentation (3 weeks ago)
>> >> > >> <Maximilian Michels>
>> >> > >> * dc675f2 - [docs] Remove 'Working with Time' page (3 weeks ago)
>> <Ufuk
>> >> > >> Celebi>
>> >> > >> * 95cd07c - [docs] Add description and illustration about
>> Watermarks
>> >> > >> in streams (3 weeks ago) <Stephan Ewen>
>> >> > >> * 2831b7d - [docs] Add first steps to docs start page (3 weeks ago)
>> >> > >> <Ufuk Celebi>
>> >> > >> * a709f0a - [docs] Update stack figure on docs start page (3 weeks
>> >> > >> ago) <Ufuk Celebi>
>> >> > >> * bb9c1fa - [FLINK-3592] [docs] Update setup quickstart (3 weeks
>> ago)
>> >> > >> <Ufuk Celebi>
>> >> > >> * d4c2a47 - [FLINK-3591] Replace Quickstart K-Means Example by
>> >> > >> Streaming Example (3 weeks ago) <Aljoscha Krettek>
>> >> > >> * 2f3711b - [docs] Move connectors page to batch guide (3 weeks
>> ago)
>> >> > >> <Ufuk Celebi>
>> >> > >> * db860e4 - Update version and remove unused variables (3 weeks
>> ago)
>> >> > >> <Ufuk Celebi>
>> >> > >> * 4f6a92d - [docs] update "build from source" page (3 weeks ago)
>> >> > >> <Maximilian Michels>
>> >> > >> * a08242f - [FLINK-3533] [docs] fix broken links to examples and
>> >> > >> cluster execution in Gelly guide (4 weeks ago) <vasia>
>> >> > >> * b376540 - [FLINK-3566] [FLINK-3563] [core] TypeExtraction input
>> type
>> >> > >> validation fixes (4 weeks ago) <twalthr>
>> >> > >> * 2cde19b - [FLINK-3495] [tests] Disable RocksDB tests on Windows
>> (4
>> >> > >> weeks ago) <zentol>
>> >> > >> * 5a63cbf - [FLINK-3491] [tests] Prevent URIException in
>> HDFSCopyTest
>> >> > >> and disable HDFSCopyUtilitiesTest on Windows (4 weeks ago) <zentol>
>> >> > >> * 0e61ffc - [docs] Add documentation about Event Time, Timestamp
>> >> > >> Assigners, Watermark Generation (4 weeks ago) <Stephan Ewen>
>> >> > >> * 5c3c734 - [FLINK-3575] [docs] Update 'Working With State'
>> section in
>> >> > >> docs (4 weeks ago) <Aljoscha Krettek>
>> >> > >> * 9158789 - [FLINK-3578] [streaming scala] Support RichFunctions
>> for
>> >> > >> Scala WindowFunction and AllWindowFunction (4 weeks ago) <Stephan
>> >> > >> Ewen>
>> >> > >> * fd0830e - [FLINK-3569] [build] Adjust test cases due to shading
>> >> > >> plugin base directory changes (4 weeks ago) <Maximilian Michels>
>> >> > >> * b289311 - [FLINK-3570] [runtime] Use InetAddress.getLocalHost()
>> as
>> >> > >> heuristic to find local address (4 weeks ago) <Till Rohrmann>
>> >> > >> * f856855 - [FLINK-3484] Add setSlotSharingGroup documentation (4
>> >> > >> weeks ago) <Aljo
>> >> > >>
>> >> >
>> >>
>>

[Aljoscha Krettek-2]

+1

I ran "mvn clean verify" on the source. Dowloaded binary, ran example
programs in cluster mode.

On Mon, 4 Apr 2016 at 15:08 Maximilian Michels <[hidden email]> wrote:

> On Mon, Apr 4, 2016 at 12:16 PM, Robert Metzger <[hidden email]>
> wrote:
> > We can probably move the force shading module into a (deactivated) build
> > profile and set the dependency to 1.0.0, so that it just looks like a
> > regular dependency.
>
> That's what I suggested. It's not a blocker for the release. Just a
> minor improvement.
>
> On Mon, Apr 4, 2016 at 12:16 PM, Robert Metzger <[hidden email]>
> wrote:
> > We can probably move the force shading module into a (deactivated) build
> > profile and set the dependency to 1.0.0, so that it just looks like a
> > regular dependency.
> >
> > On Mon, Apr 4, 2016 at 12:12 PM, Maximilian Michels <[hidden email]>
> wrote:
> >
> >> The version of force-shading had to be a snapshot version, otherwise
> >> the nightly deployment of snapshots wouldn't work. However, since we
> >> have 1.0.0 already in place, we could revert the version to 1.0.0
> >> again and skip the deployment from now on. I don't think it makes much
> >> of a difference but it would reduce the number of deployed artifacts.
> >> I could open a PR to make the changes.
> >>
> >> On Mon, Apr 4, 2016 at 11:29 AM, Robert Metzger <[hidden email]>
> >> wrote:
> >> > One quick question regarding the release:
> >> > Are you intentionally releasing a 1.0.1 version of the force-shading
> >> module?
> >> >
> >> > Since it is really a work around, I wounder if we should not release
> the
> >> > force-shading anymore and always depend on force-shading:1.0.0.
> >> >
> >> >
> >> > On Sat, Apr 2, 2016 at 9:25 PM, Aljoscha Krettek <[hidden email]
> >
> >> > wrote:
> >> >
> >> >> Yes, that seems reasonable.
> >> >>
> >> >> On Sat, 2 Apr 2016 at 13:14 Ufuk Celebi <[hidden email]> wrote:
> >> >>
> >> >> > Thanks for the initial tests.
> >> >> >
> >> >> > I would say let's continue with this RC and wait for the user to
> >> >> > provide the fix, which we can then include in 1.0.2 soon.
> >> >> >
> >> >> > On Fri, Apr 1, 2016 at 2:59 PM, Aljoscha Krettek <
> [hidden email]
> >> >
> >> >> > wrote:
> >> >> > > I ran the usual tests and the release seems fine. A user,
> however,
> >> >> found
> >> >> > > this bug which seems to be a blocker:
> >> >> > >
> >> >> >
> >> >>
> >>
> https://issues.apache.org/jira/browse/FLINK-3688?jql=project%20%3D%20FLINK
> >> >> > >
> >> >> > > Should we maybe wait for the fix and then to another RC?
> >> >> > >
> >> >> > > On Thu, 31 Mar 2016 at 18:10 Ufuk Celebi <[hidden email]> wrote:
> >> >> > >
> >> >> > >> Dear Flink community,
> >> >> > >>
> >> >> > >> Please vote on releasing the following candidate as Apache Flink
> >> >> version
> >> >> > >> 1.0.1.
> >> >> > >>
> >> >> > >> The commit to be voted on:
> >> >> > >> 4afa401ab3c2b53de115d17a3157e8b80431dd10
> >> >> > >>
> >> >> > >> Branch:
> >> >> > >> release-1.0.1-rc1 (see
> >> >> > >>
> >> >> > >>
> >> >> >
> >> >>
> >>
> https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git;a=shortlog;h=refs/heads/release-1.0.1-rc1
> >> >> > >> )
> >> >> > >>
> >> >> > >> The release artifacts to be voted on can be found at:
> >> >> > >> http://home.apache.org/~uce/flink-1.0.1-rc1/
> >> >> > >>
> >> >> > >> The release artifacts are signed with the key with fingerprint
> >> >> 9D403309:
> >> >> > >> http://www.apache.org/dist/flink/KEYS
> >> >> > >>
> >> >> > >> The staging repository for this release can be found at:
> >> >> > >>
> >> >>
> https://repository.apache.org/content/repositories/orgapacheflink-1089
> >> >> > >>
> >> >> > >> -------------------------------------------------------------
> >> >> > >>
> >> >> > >> The vote is open for the next 72 hours and passes if a majority
> of
> >> at
> >> >> > least
> >> >> > >> three +1 PMC votes are cast.
> >> >> > >>
> >> >> > >> The vote ends on Tuesday April 5, 2016 (not counting the
> weekend).
> >> >> > >>
> >> >> > >> [ ] +1 Release this package as Apache Flink 1.0.1
> >> >> > >> [ ] -1 Do not release this package because ...
> >> >> > >>
> >> >> > >> ===================================
> >> >> > >>
> >> >> > >> The following commits have been added since the 1.0.0 release,
> most
> >> >> > >> notably a fix for the rolling HDFS file sink and support for
> >> >> > >> RichFunctions in Scala.
> >> >> > >>
> >> >> > >> * 974c66e - [FLINK-3383] Backport 'Move snapshot deployment from
> >> >> > >> Travis CI to ASF Jenkins' (6 hours ago) <Ufuk Celebi>
> >> >> > >> * 630e77f - [FLINK-3684] [cep] Add proper watermark emission to
> CEP
> >> >> > >> operators (6 hours ago) <Till Rohrmann>
> >> >> > >> * dae29b4 - [FLINK-3682] [cep] Assign processing timestamp in
> CEP
> >> >> > >> operators (23 hours ago) <Till Rohrmann>
> >> >> > >> * a96e1a6 - [FLINK-3681] [cep, typeextractor] Generalize
> >> TypeExtractor
> >> >> > >> to support more lambdas (23 hours ago) <Till Rohrmann>
> >> >> > >> * ce448cd - [tools] Update copy files function in release script
> >> (25
> >> >> > >> hours ago) <Ufuk Celebi>
> >> >> > >> * 245f0d8 - [hotfix] [cep] Add sanity check for erroneously
> pruned
> >> >> > >> elements (26 hours ago) <Till Rohrmann>
> >> >> > >> * 2089029 - [FLINK-3651] Fix faulty RollingSink Restore (2 days
> >> ago)
> >> >> > >> <Aljoscha Krettek>
> >> >> > >> * 875cb44 - [FLINK-3676][docs] sync docs with the WebClient
> >> removal (2
> >> >> > >> days ago) <Maximilian Michels>
> >> >> > >> * 085f7b2 - [FLINK-3663] [kafka] Fix logPartitionInfo log
> >> statement (7
> >> >> > >> days ago) <Niels Zeilemaker>
> >> >> > >> * 5357ebe - [FLINK-3653] [docs] Add
> recovery.zookeeper.storageDir
> >> docs
> >> >> > >> to config page (7 days ago) <Stefano Baghino>
> >> >> > >> * 1ca4f36 - [FLINK-2444] Add tests for HadoopInputFormats (8
> days
> >> ago)
> >> >> > >> <Martin Liesenberg>
> >> >> > >> * da989c4 - [FLINK-2445] Improve HadoopOutputFormatTests (8 days
> >> ago)
> >> >> > >> <Martin Liesenberg>
> >> >> > >> * edf343a - [FLINK-2445] Add tests for HadoopOutputFormats (8
> days
> >> >> > >> ago) <Ajay Bhat>
> >> >> > >> * 1909bdb - [FLINK-3129] Bring infrastructure for ensuring
> >> interface
> >> >> > >> stability in place (8 days ago) <Robert Metzger>
> >> >> > >> * cd5773e - [FLINK-3179] [dataSet][optimizer] Log a WARN
> message if
> >> >> > >> combiner is not added in front of PartitionOperator (9 days ago)
> >> >> > >> <ramkrishna>
> >> >> > >> * 0880c59 - [FLINK-3602] Fix TypeExtractor and add support for
> >> >> > >> recursive types (9 days ago) <twalthr>
> >> >> > >> * 954cdc1 - [hotfix] Fix ContinuousProcessingTimeTrigger (10
> days
> >> ago)
> >> >> > >> <Aljoscha Krettek>
> >> >> > >> * 2c78be3 - [FLINK-3629] Fix quick start description for the
> >> >> > >> ".timeWindow()" function call (2 weeks ago) <Li Fanxi>
> >> >> > >> * 6749874 - [FLINK-3621] [docs] Improve documentation of memory
> >> >> > >> configuration parameters (2 weeks ago) <Fabian Hueske>
> >> >> > >> * 165065c - [FLINK-3333] [docs] Improve documentation of DataSet
> >> >> > >> object-reuse modes. (2 weeks ago) <Fabian Hueske>
> >> >> > >> * 3d8c7c1 - [FLINK-3472] [jdbc] Give a better exception if jdbc
> >> column
> >> >> > >> has a null value (3 weeks ago) <zentol>
> >> >> > >> * 43e95f2 - [FLINK-2671] [tests] Fix test instability in
> >> >> > >> StreamCheckpointNotifierITCase (3 weeks ago) <Stephan Ewen>
> >> >> > >> * f905503 - [FLINK-3594] [runtime] Make sure exceptions during
> >> >> > >> checkpoints are handled properly (3 weeks ago) <Stephan Ewen>
> >> >> > >> * a405b55 - [hotfix] [runtime] Guard async recovery operation in
> >> >> > >> try-catch (3 weeks ago) <Ufuk Celebi>
> >> >> > >> * 5f35d13 - [quickstart] fix links to documentation (3 weeks
> ago)
> >> >> > >> <Maximilian Michels>
> >> >> > >> * dc675f2 - [docs] Remove 'Working with Time' page (3 weeks ago)
> >> <Ufuk
> >> >> > >> Celebi>
> >> >> > >> * 95cd07c - [docs] Add description and illustration about
> >> Watermarks
> >> >> > >> in streams (3 weeks ago) <Stephan Ewen>
> >> >> > >> * 2831b7d - [docs] Add first steps to docs start page (3 weeks
> ago)
> >> >> > >> <Ufuk Celebi>
> >> >> > >> * a709f0a - [docs] Update stack figure on docs start page (3
> weeks
> >> >> > >> ago) <Ufuk Celebi>
> >> >> > >> * bb9c1fa - [FLINK-3592] [docs] Update setup quickstart (3 weeks
> >> ago)
> >> >> > >> <Ufuk Celebi>
> >> >> > >> * d4c2a47 - [FLINK-3591] Replace Quickstart K-Means Example by
> >> >> > >> Streaming Example (3 weeks ago) <Aljoscha Krettek>
> >> >> > >> * 2f3711b - [docs] Move connectors page to batch guide (3 weeks
> >> ago)
> >> >> > >> <Ufuk Celebi>
> >> >> > >> * db860e4 - Update version and remove unused variables (3 weeks
> >> ago)
> >> >> > >> <Ufuk Celebi>
> >> >> > >> * 4f6a92d - [docs] update "build from source" page (3 weeks ago)
> >> >> > >> <Maximilian Michels>
> >> >> > >> * a08242f - [FLINK-3533] [docs] fix broken links to examples and
> >> >> > >> cluster execution in Gelly guide (4 weeks ago) <vasia>
> >> >> > >> * b376540 - [FLINK-3566] [FLINK-3563] [core] TypeExtraction
> input
> >> type
> >> >> > >> validation fixes (4 weeks ago) <twalthr>
> >> >> > >> * 2cde19b - [FLINK-3495] [tests] Disable RocksDB tests on
> Windows
> >> (4
> >> >> > >> weeks ago) <zentol>
> >> >> > >> * 5a63cbf - [FLINK-3491] [tests] Prevent URIException in
> >> HDFSCopyTest
> >> >> > >> and disable HDFSCopyUtilitiesTest on Windows (4 weeks ago)
> <zentol>
> >> >> > >> * 0e61ffc - [docs] Add documentation about Event Time, Timestamp
> >> >> > >> Assigners, Watermark Generation (4 weeks ago) <Stephan Ewen>
> >> >> > >> * 5c3c734 - [FLINK-3575] [docs] Update 'Working With State'
> >> section in
> >> >> > >> docs (4 weeks ago) <Aljoscha Krettek>
> >> >> > >> * 9158789 - [FLINK-3578] [streaming scala] Support RichFunctions
> >> for
> >> >> > >> Scala WindowFunction and AllWindowFunction (4 weeks ago)
> <Stephan
> >> >> > >> Ewen>
> >> >> > >> * fd0830e - [FLINK-3569] [build] Adjust test cases due to
> shading
> >> >> > >> plugin base directory changes (4 weeks ago) <Maximilian Michels>
> >> >> > >> * b289311 - [FLINK-3570] [runtime] Use
> InetAddress.getLocalHost()
> >> as
> >> >> > >> heuristic to find local address (4 weeks ago) <Till Rohrmann>
> >> >> > >> * f856855 - [FLINK-3484] Add setSlotSharingGroup documentation
> (4
> >> >> > >> weeks ago) <Aljo
> >> >> > >>
> >> >> >
> >> >>
> >>
>

[Ufuk Celebi-2]

+1

- Check if checksums and GPG files match the corresponding release files
- Verify that the source archives do not contains any binaries (no
changes in commits since 1.0.0)
- Check if the source release is building properly with Maven (for
Hadoop 2.4.1 and Scala 2.10)
- Verify that the LICENSE and NOTICE file is correct for the binary
and source release (no changes in commits since 1.0.0)
- Check that all POM files point to the same version
- README unchanged
- Run examples on a YARN cluster
- Run job with HDFS sink and kill TaskManagers
- Checked Quickstarts against staging repository
- Checked that dist jars are free of Guava (they contain
META-INF/maven/com.google.guava/*, but not the actual classes)

– Ufuk

On Mon, Apr 4, 2016 at 3:32 PM, Aljoscha Krettek <[hidden email]> wrote:

> +1
>
> I ran "mvn clean verify" on the source. Dowloaded binary, ran example
> programs in cluster mode.
>
> On Mon, 4 Apr 2016 at 15:08 Maximilian Michels <[hidden email]> wrote:
>
>> On Mon, Apr 4, 2016 at 12:16 PM, Robert Metzger <[hidden email]>
>> wrote:
>> > We can probably move the force shading module into a (deactivated) build
>> > profile and set the dependency to 1.0.0, so that it just looks like a
>> > regular dependency.
>>
>> That's what I suggested. It's not a blocker for the release. Just a
>> minor improvement.
>>
>> On Mon, Apr 4, 2016 at 12:16 PM, Robert Metzger <[hidden email]>
>> wrote:
>> > We can probably move the force shading module into a (deactivated) build
>> > profile and set the dependency to 1.0.0, so that it just looks like a
>> > regular dependency.
>> >
>> > On Mon, Apr 4, 2016 at 12:12 PM, Maximilian Michels <[hidden email]>
>> wrote:
>> >
>> >> The version of force-shading had to be a snapshot version, otherwise
>> >> the nightly deployment of snapshots wouldn't work. However, since we
>> >> have 1.0.0 already in place, we could revert the version to 1.0.0
>> >> again and skip the deployment from now on. I don't think it makes much
>> >> of a difference but it would reduce the number of deployed artifacts.
>> >> I could open a PR to make the changes.
>> >>
>> >> On Mon, Apr 4, 2016 at 11:29 AM, Robert Metzger <[hidden email]>
>> >> wrote:
>> >> > One quick question regarding the release:
>> >> > Are you intentionally releasing a 1.0.1 version of the force-shading
>> >> module?
>> >> >
>> >> > Since it is really a work around, I wounder if we should not release
>> the
>> >> > force-shading anymore and always depend on force-shading:1.0.0.
>> >> >
>> >> >
>> >> > On Sat, Apr 2, 2016 at 9:25 PM, Aljoscha Krettek <[hidden email]
>> >
>> >> > wrote:
>> >> >
>> >> >> Yes, that seems reasonable.
>> >> >>
>> >> >> On Sat, 2 Apr 2016 at 13:14 Ufuk Celebi <[hidden email]> wrote:
>> >> >>
>> >> >> > Thanks for the initial tests.
>> >> >> >
>> >> >> > I would say let's continue with this RC and wait for the user to
>> >> >> > provide the fix, which we can then include in 1.0.2 soon.
>> >> >> >
>> >> >> > On Fri, Apr 1, 2016 at 2:59 PM, Aljoscha Krettek <
>> [hidden email]
>> >> >
>> >> >> > wrote:
>> >> >> > > I ran the usual tests and the release seems fine. A user,
>> however,
>> >> >> found
>> >> >> > > this bug which seems to be a blocker:
>> >> >> > >
>> >> >> >
>> >> >>
>> >>
>> https://issues.apache.org/jira/browse/FLINK-3688?jql=project%20%3D%20FLINK
>> >> >> > >
>> >> >> > > Should we maybe wait for the fix and then to another RC?
>> >> >> > >
>> >> >> > > On Thu, 31 Mar 2016 at 18:10 Ufuk Celebi <[hidden email]> wrote:
>> >> >> > >
>> >> >> > >> Dear Flink community,
>> >> >> > >>
>> >> >> > >> Please vote on releasing the following candidate as Apache Flink
>> >> >> version
>> >> >> > >> 1.0.1.
>> >> >> > >>
>> >> >> > >> The commit to be voted on:
>> >> >> > >> 4afa401ab3c2b53de115d17a3157e8b80431dd10
>> >> >> > >>
>> >> >> > >> Branch:
>> >> >> > >> release-1.0.1-rc1 (see
>> >> >> > >>
>> >> >> > >>
>> >> >> >
>> >> >>
>> >>
>> https://git1-us-west.apache.org/repos/asf/flink/?p=flink.git;a=shortlog;h=refs/heads/release-1.0.1-rc1
>> >> >> > >> )
>> >> >> > >>
>> >> >> > >> The release artifacts to be voted on can be found at:
>> >> >> > >> http://home.apache.org/~uce/flink-1.0.1-rc1/
>> >> >> > >>
>> >> >> > >> The release artifacts are signed with the key with fingerprint
>> >> >> 9D403309:
>> >> >> > >> http://www.apache.org/dist/flink/KEYS
>> >> >> > >>
>> >> >> > >> The staging repository for this release can be found at:
>> >> >> > >>
>> >> >>
>> https://repository.apache.org/content/repositories/orgapacheflink-1089
>> >> >> > >>
>> >> >> > >> -------------------------------------------------------------
>> >> >> > >>
>> >> >> > >> The vote is open for the next 72 hours and passes if a majority
>> of
>> >> at
>> >> >> > least
>> >> >> > >> three +1 PMC votes are cast.
>> >> >> > >>
>> >> >> > >> The vote ends on Tuesday April 5, 2016 (not counting the
>> weekend).
>> >> >> > >>
>> >> >> > >> [ ] +1 Release this package as Apache Flink 1.0.1
>> >> >> > >> [ ] -1 Do not release this package because ...
>> >> >> > >>
>> >> >> > >> ===================================
>> >> >> > >>
>> >> >> > >> The following commits have been added since the 1.0.0 release,
>> most
>> >> >> > >> notably a fix for the rolling HDFS file sink and support for
>> >> >> > >> RichFunctions in Scala.
>> >> >> > >>
>> >> >> > >> * 974c66e - [FLINK-3383] Backport 'Move snapshot deployment from
>> >> >> > >> Travis CI to ASF Jenkins' (6 hours ago) <Ufuk Celebi>
>> >> >> > >> * 630e77f - [FLINK-3684] [cep] Add proper watermark emission to
>> CEP
>> >> >> > >> operators (6 hours ago) <Till Rohrmann>
>> >> >> > >> * dae29b4 - [FLINK-3682] [cep] Assign processing timestamp in
>> CEP
>> >> >> > >> operators (23 hours ago) <Till Rohrmann>
>> >> >> > >> * a96e1a6 - [FLINK-3681] [cep, typeextractor] Generalize
>> >> TypeExtractor
>> >> >> > >> to support more lambdas (23 hours ago) <Till Rohrmann>
>> >> >> > >> * ce448cd - [tools] Update copy files function in release script
>> >> (25
>> >> >> > >> hours ago) <Ufuk Celebi>
>> >> >> > >> * 245f0d8 - [hotfix] [cep] Add sanity check for erroneously
>> pruned
>> >> >> > >> elements (26 hours ago) <Till Rohrmann>
>> >> >> > >> * 2089029 - [FLINK-3651] Fix faulty RollingSink Restore (2 days
>> >> ago)
>> >> >> > >> <Aljoscha Krettek>
>> >> >> > >> * 875cb44 - [FLINK-3676][docs] sync docs with the WebClient
>> >> removal (2
>> >> >> > >> days ago) <Maximilian Michels>
>> >> >> > >> * 085f7b2 - [FLINK-3663] [kafka] Fix logPartitionInfo log
>> >> statement (7
>> >> >> > >> days ago) <Niels Zeilemaker>
>> >> >> > >> * 5357ebe - [FLINK-3653] [docs] Add
>> recovery.zookeeper.storageDir
>> >> docs
>> >> >> > >> to config page (7 days ago) <Stefano Baghino>
>> >> >> > >> * 1ca4f36 - [FLINK-2444] Add tests for HadoopInputFormats (8
>> days
>> >> ago)
>> >> >> > >> <Martin Liesenberg>
>> >> >> > >> * da989c4 - [FLINK-2445] Improve HadoopOutputFormatTests (8 days
>> >> ago)
>> >> >> > >> <Martin Liesenberg>
>> >> >> > >> * edf343a - [FLINK-2445] Add tests for HadoopOutputFormats (8
>> days
>> >> >> > >> ago) <Ajay Bhat>
>> >> >> > >> * 1909bdb - [FLINK-3129] Bring infrastructure for ensuring
>> >> interface
>> >> >> > >> stability in place (8 days ago) <Robert Metzger>
>> >> >> > >> * cd5773e - [FLINK-3179] [dataSet][optimizer] Log a WARN
>> message if
>> >> >> > >> combiner is not added in front of PartitionOperator (9 days ago)
>> >> >> > >> <ramkrishna>
>> >> >> > >> * 0880c59 - [FLINK-3602] Fix TypeExtractor and add support for
>> >> >> > >> recursive types (9 days ago) <twalthr>
>> >> >> > >> * 954cdc1 - [hotfix] Fix ContinuousProcessingTimeTrigger (10
>> days
>> >> ago)
>> >> >> > >> <Aljoscha Krettek>
>> >> >> > >> * 2c78be3 - [FLINK-3629] Fix quick start description for the
>> >> >> > >> ".timeWindow()" function call (2 weeks ago) <Li Fanxi>
>> >> >> > >> * 6749874 - [FLINK-3621] [docs] Improve documentation of memory
>> >> >> > >> configuration parameters (2 weeks ago) <Fabian Hueske>
>> >> >> > >> * 165065c - [FLINK-3333] [docs] Improve documentation of DataSet
>> >> >> > >> object-reuse modes. (2 weeks ago) <Fabian Hueske>
>> >> >> > >> * 3d8c7c1 - [FLINK-3472] [jdbc] Give a better exception if jdbc
>> >> column
>> >> >> > >> has a null value (3 weeks ago) <zentol>
>> >> >> > >> * 43e95f2 - [FLINK-2671] [tests] Fix test instability in
>> >> >> > >> StreamCheckpointNotifierITCase (3 weeks ago) <Stephan Ewen>
>> >> >> > >> * f905503 - [FLINK-3594] [runtime] Make sure exceptions during
>> >> >> > >> checkpoints are handled properly (3 weeks ago) <Stephan Ewen>
>> >> >> > >> * a405b55 - [hotfix] [runtime] Guard async recovery operation in
>> >> >> > >> try-catch (3 weeks ago) <Ufuk Celebi>
>> >> >> > >> * 5f35d13 - [quickstart] fix links to documentation (3 weeks
>> ago)
>> >> >> > >> <Maximilian Michels>
>> >> >> > >> * dc675f2 - [docs] Remove 'Working with Time' page (3 weeks ago)
>> >> <Ufuk
>> >> >> > >> Celebi>
>> >> >> > >> * 95cd07c - [docs] Add description and illustration about
>> >> Watermarks
>> >> >> > >> in streams (3 weeks ago) <Stephan Ewen>
>> >> >> > >> * 2831b7d - [docs] Add first steps to docs start page (3 weeks
>> ago)
>> >> >> > >> <Ufuk Celebi>
>> >> >> > >> * a709f0a - [docs] Update stack figure on docs start page (3
>> weeks
>> >> >> > >> ago) <Ufuk Celebi>
>> >> >> > >> * bb9c1fa - [FLINK-3592] [docs] Update setup quickstart (3 weeks
>> >> ago)
>> >> >> > >> <Ufuk Celebi>
>> >> >> > >> * d4c2a47 - [FLINK-3591] Replace Quickstart K-Means Example by
>> >> >> > >> Streaming Example (3 weeks ago) <Aljoscha Krettek>
>> >> >> > >> * 2f3711b - [docs] Move connectors page to batch guide (3 weeks
>> >> ago)
>> >> >> > >> <Ufuk Celebi>
>> >> >> > >> * db860e4 - Update version and remove unused variables (3 weeks
>> >> ago)
>> >> >> > >> <Ufuk Celebi>
>> >> >> > >> * 4f6a92d - [docs] update "build from source" page (3 weeks ago)
>> >> >> > >> <Maximilian Michels>
>> >> >> > >> * a08242f - [FLINK-3533] [docs] fix broken links to examples and
>> >> >> > >> cluster execution in Gelly guide (4 weeks ago) <vasia>
>> >> >> > >> * b376540 - [FLINK-3566] [FLINK-3563] [core] TypeExtraction
>> input
>> >> type
>> >> >> > >> validation fixes (4 weeks ago) <twalthr>
>> >> >> > >> * 2cde19b - [FLINK-3495] [tests] Disable RocksDB tests on
>> Windows
>> >> (4
>> >> >> > >> weeks ago) <zentol>
>> >> >> > >> * 5a63cbf - [FLINK-3491] [tests] Prevent URIException in
>> >> HDFSCopyTest
>> >> >> > >> and disable HDFSCopyUtilitiesTest on Windows (4 weeks ago)
>> <zentol>
>> >> >> > >> * 0e61ffc - [docs] Add documentation about Event Time, Timestamp
>> >> >> > >> Assigners, Watermark Generation (4 weeks ago) <Stephan Ewen>
>> >> >> > >> * 5c3c734 - [FLINK-3575] [docs] Update 'Working With State'
>> >> section in
>> >> >> > >> docs (4 weeks ago) <Aljoscha Krettek>
>> >> >> > >> * 9158789 - [FLINK-3578] [streaming scala] Support RichFunctions
>> >> for
>> >> >> > >> Scala WindowFunction and AllWindowFunction (4 weeks ago)
>> <Stephan
>> >> >> > >> Ewen>
>> >> >> > >> * fd0830e - [FLINK-3569] [build] Adjust test cases due to
>> shading
>> >> >> > >> plugin base directory changes (4 weeks ago) <Maximilian Michels>
>> >> >> > >> * b289311 - [FLINK-3570] [runtime] Use
>> InetAddress.getLocalHost()
>> >> as
>> >> >> > >> heuristic to find local address (4 weeks ago) <Till Rohrmann>
>> >> >> > >> * f856855 - [FLINK-3484] Add setSlotSharingGroup documentation
>> (4
>> >> >> > >> weeks ago) <Aljo
>> >> >> > >>
>> >> >> >
>> >> >>
>> >>
>>