Testing for FLINK-3839

[THORMAN, ROBERT D]

I’ve made some code changes for this ticket and need some coaching on how to test/verify before I commit/push.


·         How to I build and installation package locally?

·         What verification(s) do I need to do other than my own test case?

·         Is there a code review process before the PR?

Thanks in advance for the help.


Bob Thorman
Principal – Technology Security
AT&T Chief Security Organization
208 S Akard, 14th Floor
Dallas, TX 75075
[phone]

There are only two hard things in Computer Science: cache invalidation and naming things. -- Phil Karlton

This e-mail and any files transmitted with it are the property of the AT&T companies, are confidential, and are intended solely for the use of the individual or entity to whom this e-mail is addressed. If you are not one of the named recipients or otherwise have reason to believe that you have received this message in error, please notify the sender and delete this message immediately from your computer. Any other use, retention, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited.

[Chesnay Schepler-3]

1:
https://ci.apache.org/projects/flink/flink-docs-release-1.0/setup/building.html
2: Generally none, provided the test cases are good.
     Certain features require a test run on a cluster.
3: The code review will be done as part of the PR review.

On 15.06.2016 19:50, THORMAN, ROBERT D wrote:

> I’ve made some code changes for this ticket and need some coaching on how to test/verify before I commit/push.
>
>
> ·         How to I build and installation package locally?
>
> ·         What verification(s) do I need to do other than my own test case?
>
> ·         Is there a code review process before the PR?
>
> Thanks in advance for the help.
>
>
> Bob Thorman
> Principal – Technology Security
> AT&T Chief Security Organization
> 208 S Akard, 14th Floor
> Dallas, TX 75075
> [phone]
>
> There are only two hard things in Computer Science: cache invalidation and naming things. -- Phil Karlton
>
> This e-mail and any files transmitted with it are the property of the AT&T companies, are confidential, and are intended solely for the use of the individual or entity to whom this e-mail is addressed. If you are not one of the named recipients or otherwise have reason to believe that you have received this message in error, please notify the sender and delete this message immediately from your computer. Any other use, retention, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited.

[THORMAN, ROBERT D]

Is there a way to check for code format violations in IntelliJ.  I keep failing the build on one format violation.  

On 6/15/16, 1:21 PM, "Chesnay Schepler" <[hidden email]> wrote:

1:
https://ci.apache.org/projects/flink/flink-docs-release-1.0/setup/building.html
2: Generally none, provided the test cases are good.
     Certain features require a test run on a cluster.
3: The code review will be done as part of the PR review.

On 15.06.2016 19:50, THORMAN, ROBERT D wrote:

> I’ve made some code changes for this ticket and need some coaching on how to test/verify before I commit/push.
>
>
> ·         How to I build and installation package locally?
>
> ·         What verification(s) do I need to do other than my own test case?
>
> ·         Is there a code review process before the PR?
>
> Thanks in advance for the help.
>
>
> Bob Thorman
> Principal – Technology Security
> AT&T Chief Security Organization
> 208 S Akard, 14th Floor
> Dallas, TX 75075
> [phone]
>
> There are only two hard things in Computer Science: cache invalidation and naming things. -- Phil Karlton
>
> This e-mail and any files transmitted with it are the property of the AT&T companies, are confidential, and are intended solely for the use of the individual or entity to whom this e-mail is addressed. If you are not one of the named recipients or otherwise have reason to believe that you have received this message in error, please notify the sender and delete this message immediately from your computer. Any other use, retention, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited.

[Chesnay Schepler-3]

You can run mvn checkstyle:check in the flink to search for codestyle
violations.
You should be able to define a maven build in intelliJ that does that.
(Run -> Edit configurations -> Maven)

On 15.06.2016 20:53, THORMAN, ROBERT D wrote:

> Is there a way to check for code format violations in IntelliJ.  I keep failing the build on one format violation.
>
> On 6/15/16, 1:21 PM, "Chesnay Schepler" <[hidden email]> wrote:
>
> 1:
> https://ci.apache.org/projects/flink/flink-docs-release-1.0/setup/building.html
> 2: Generally none, provided the test cases are good.
>       Certain features require a test run on a cluster.
> 3: The code review will be done as part of the PR review.
>
> On 15.06.2016 19:50, THORMAN, ROBERT D wrote:
>> I’ve made some code changes for this ticket and need some coaching on how to test/verify before I commit/push.
>>
>>
>> ·         How to I build and installation package locally?
>>
>> ·         What verification(s) do I need to do other than my own test case?
>>
>> ·         Is there a code review process before the PR?
>>
>> Thanks in advance for the help.
>>
>>
>> Bob Thorman
>> Principal – Technology Security
>> AT&T Chief Security Organization
>> 208 S Akard, 14th Floor
>> Dallas, TX 75075
>> [phone]
>>
>> There are only two hard things in Computer Science: cache invalidation and naming things. -- Phil Karlton
>>
>> This e-mail and any files transmitted with it are the property of the AT&T companies, are confidential, and are intended solely for the use of the individual or entity to whom this e-mail is addressed. If you are not one of the named recipients or otherwise have reason to believe that you have received this message in error, please notify the sender and delete this message immediately from your computer. Any other use, retention, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited.
>
>

[Robert Metzger]

Hi,

there is a Checkstyle Plugin for IntelliJ that allows you to load our
checkstyle configuration file. This will then show errors like parser
errors.

Regards,
Robert

On Wed, Jun 15, 2016 at 8:53 PM, THORMAN, ROBERT D <[hidden email]> wrote:

> Is there a way to check for code format violations in IntelliJ.  I keep
> failing the build on one format violation.
>
> On 6/15/16, 1:21 PM, "Chesnay Schepler" <[hidden email]> wrote:
>
> 1:
>
> https://ci.apache.org/projects/flink/flink-docs-release-1.0/setup/building.html
> 2: Generally none, provided the test cases are good.
>      Certain features require a test run on a cluster.
> 3: The code review will be done as part of the PR review.
>
> On 15.06.2016 19:50, THORMAN, ROBERT D wrote:
> > I’ve made some code changes for this ticket and need some coaching on
> how to test/verify before I commit/push.
> >
> >
> > ·         How to I build and installation package locally?
> >
> > ·         What verification(s) do I need to do other than my own test
> case?
> >
> > ·         Is there a code review process before the PR?
> >
> > Thanks in advance for the help.
> >
> >
> > Bob Thorman
> > Principal – Technology Security
> > AT&T Chief Security Organization
> > 208 S Akard, 14th Floor
> > Dallas, TX 75075
> > [phone]
> >
> > There are only two hard things in Computer Science: cache invalidation
> and naming things. -- Phil Karlton
> >
> > This e-mail and any files transmitted with it are the property of the
> AT&T companies, are confidential, and are intended solely for the use of
> the individual or entity to whom this e-mail is addressed. If you are not
> one of the named recipients or otherwise have reason to believe that you
> have received this message in error, please notify the sender and delete
> this message immediately from your computer. Any other use, retention,
> dissemination, forwarding, printing, or copying of this e-mail is strictly
> prohibited.
>
>
>
>