[GitHub] incubator-flink pull request: New Webclient

[zentol]

GitHub user JonathanH5 opened a pull request:

    https://github.com/apache/incubator-flink/pull/15

    New Webclient

    I changed the webclient to a new layout. All frameworks work with the apache license.
    @rmetzger

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JonathanH5/incubator-flink flink_webclient

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15
   
----
commit c260666685ab02855adb17ba678c7a37e17b1fa3
Author: Jonathan <[hidden email]>
Date:   2014-06-02T10:34:03Z

    New Webclient

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user rmetzger commented on the pull request:

    https://github.com/apache/incubator-flink/pull/15#issuecomment-46041318
 
    Thank you for the pull request.
    I spend quite some time today to debug it and to get it to run. Everything seems fine, except for one thing: I can not get a plan preview for the Java K-Means example.
    I don't know if I'm doing anything wrong, and I spend quite some time with the debugger. Our system is able to generate a JSON plan, its also sent it to the browser, but still, the plan does not show up.
    
    There is no JavaScript error. The standalone tool is able to visualize it (the file that is also located in the file system).
    Can you try and see if you can reproduce it?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user JonathanH5 commented on the pull request:

    https://github.com/apache/incubator-flink/pull/15#issuecomment-46086799
 
    Hi, thank you for your time ... .
    I checked it and found out that the json file created by the system is corrupted
    
    The comma under the step-function line is wrong. That is why jquery does not recognize this file as a json and the ajax request ends with an error. I will try to fix it, but I wonder how the old webclient is able to handle this, because the error occures in code I did not changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user JonathanH5 commented on the pull request:

    https://github.com/apache/incubator-flink/pull/15#issuecomment-46086894
 
    By the way, the tool is able to work with the json, when you don't use the ajax request (where jquery checks whether it is a json):
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user rmetzger commented on the pull request:

    https://github.com/apache/incubator-flink/pull/15#issuecomment-46086997
 
    Cool. Good catch.
    I think we have already a JSON parser in the Maven dependencies ("jackson-core-asl"), can you add a test case for the `PlanJSONDumpGenerator` that verifies that the JSON is valid (without parse errors).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user JonathanH5 commented on the pull request:

    https://github.com/apache/incubator-flink/pull/15#issuecomment-46087212
 
    Yes, of course. But this has nothing to do with the webclient, is there anything buggy left that I need to check before you can merge it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user rmetzger commented on the pull request:

    https://github.com/apache/incubator-flink/pull/15#issuecomment-46087316
 
    I have not found any other issues


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user mariemayadi commented on the pull request:

    https://github.com/apache/incubator-flink/pull/15#issuecomment-46150199
 
    Great that you brought up the subject. I was having the same issue.
    At the moment I still am unable to see the preview. I'll work on it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user JonathanH5 commented on the pull request:

    https://github.com/apache/incubator-flink/pull/15#issuecomment-46175909
 
    Ok, that sounds good, because the JSON creation seems to be a little bit tricky :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user JonathanH5 commented on the pull request:

    https://github.com/apache/incubator-flink/pull/15#issuecomment-46329129
 
    @mariemayadi , see #23 . I fixed the bug.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-flink/pull/15


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---