[GitHub] incubator-flink pull request: [FLINK-949] Properly report GlobalBu...

[zentol]

GitHub user uce opened a pull request:

    https://github.com/apache/incubator-flink/pull/28

    [FLINK-949] Properly report GlobalBufferPool OutOfMemoryError to TaskManager

    This is [FLINK-949](https://issues.apache.org/jira/browse/FLINK-949).
   
    Travis seems to have problems with downloading dependencies from Maven central and hence the [builds fail/timeout](https://travis-ci.org/uce/incubator-flink/builds/27917216).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/incubator-flink FLINK-949

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/28.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #28
   
----
commit be9f132ec538fba72f9f80cb7aaadf67d845504a
Author: uce <[hidden email]>
Date:   2014-06-19T00:42:03Z

    [FLINK-949] Properly report GlobalBufferPool OutOfMemoryError to TaskManager

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user rmetzger commented on the pull request:

    https://github.com/apache/incubator-flink/pull/28#issuecomment-46550620
 
    Looks good.
    Have you tested if the exceptions are properly thrown?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user uce commented on the pull request:

    https://github.com/apache/incubator-flink/pull/28#issuecomment-46550964
 
    This is what you get:
   
    ```java
    java.lang.Exception: Cannot instantiate local instance manager: Failed to instantiate ChannelManager.
    at eu.stratosphere.nephele.jobmanager.JobManager.<init>(JobManager.java:223)
    at eu.stratosphere.client.minicluster.NepheleMiniCluster.start(NepheleMiniCluster.java:197)
    at eu.stratosphere.test.util.AbstractTestBase.startCluster(AbstractTestBase.java:96)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
    at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:27)
    at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
    at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
    at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:74)
    at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:202)
    at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:65)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at com.intellij.rt.execution.application.AppMain.main(AppMain.java:120)
    Caused by: java.lang.Exception: Failed to instantiate ChannelManager.
    at eu.stratosphere.nephele.taskmanager.TaskManager.<init>(TaskManager.java:328)
    at eu.stratosphere.nephele.instance.local.LocalInstanceManager.<init>(LocalInstanceManager.java:170)
    at eu.stratosphere.nephele.jobmanager.JobManager.<init>(JobManager.java:221)
    ... 28 more
    Caused by: java.io.IOException: Failed to instantiate GlobalBufferPool.
    at eu.stratosphere.runtime.io.network.ChannelManager.<init>(ChannelManager.java:85)
    at eu.stratosphere.nephele.taskmanager.TaskManager.<init>(TaskManager.java:325)
    ... 30 more
    Caused by: java.lang.OutOfMemoryError: Tried to allocate 32768 buffers of size 32768 bytes each (total: 1024 MB) and ran out of memory after 30009 buffers (937 MB).
    at eu.stratosphere.runtime.io.network.bufferprovider.GlobalBufferPool.<init>(GlobalBufferPool.java:70)
    at eu.stratosphere.runtime.io.network.ChannelManager.<init>(ChannelManager.java:83)
    ... 31 more
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user rmetzger commented on the pull request:

    https://github.com/apache/incubator-flink/pull/28#issuecomment-46552826
 
    Very nice. Thank you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-flink/pull/28


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---