[GitHub] incubator-flink pull request: [FLINK-943] Remove leading and endin...

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-flink pull request: [FLINK-943] Remove leading and endin...

zentol
GitHub user uce opened a pull request:

    https://github.com/apache/incubator-flink/pull/26

    [FLINK-943] Remove leading and ending double quotes from 'env.java.opts' config value

    This is [FLINK-943](https://issues.apache.org/jira/browse/FLINK-943).
   
    The parsing works correctly but the leading/ending double quotes need to be removed before the value is given to the `java` run command, e.g. `java -Xmx1g "-D ..."` does not work.
   
    I've tested: 1. with double quotes, 2. without double quotes, and 3. not set.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/incubator-flink FLINK-943

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
   
----
commit c29e74399d4c02ac613bb3811afd44e23fd73786
Author: uce <[hidden email]>
Date:   2014-06-17T22:48:15Z

    [FLINK-943] Remove leading and ending double quotes from 'env.java.opts' config value in startup scripts

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-flink pull request: [FLINK-943] Remove leading and endin...

zentol
Github user StephanEwen commented on the pull request:

    https://github.com/apache/incubator-flink/pull/26#issuecomment-46462311
 
    Good to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-flink pull request: [FLINK-943] Remove leading and endin...

zentol
In reply to this post by zentol
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-flink/pull/26


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---