[GitHub] incubator-flink pull request: [FLINK-938] Automatically configure ...

[zentol]

GitHub user qmlmoon opened a pull request:

    https://github.com/apache/incubator-flink/pull/48

    [FLINK-938] Automatically configure the jobmanager address when using start-cluster.sh

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/qmlmoon/incubator-flink hostname

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #48
   
----
commit 7fe43529293e7867525a4b3b14ba6009ab69a322
Author: mingliang <[hidden email]>
Date:   2014-06-25T21:04:14Z

    [FLINK-938] Automatically configure the jobmanager address when using start-cluster.sh

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user rmetzger commented on the pull request:

    https://github.com/apache/incubator-flink/pull/48#issuecomment-47200290
 
    I guess the rewrite of the yaml file works well with this pull request. But I think this approach is not always working.
    This approach assumes that the configuration file is shared among all cluster nodes (for example via NFS).
    I would implement this by passing (via the cli invocation) the Jobmanager's hostname (or ip address) to the TaskManagers when starting them and leave the yaml file untouched.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user qmlmoon commented on the pull request:

    https://github.com/apache/incubator-flink/pull/48#issuecomment-47317996
 
    I would like to rewrite at least the yaml file on the master node. Because when you run stratosphere, it also reads config file to get the jobmanager address. And `CliFrontend` already has an option -m to pass jobmanager address, which requires host:port. I think it won't be nice to add another option like default jobmanager address.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user qmlmoon commented on the pull request:

    https://github.com/apache/incubator-flink/pull/48#issuecomment-47510044
 
    The newest commit using cli invocation to pass jobmanager's hostname to `JobManager` and `TaskManager`. It still try to rewrite the config file on master node since `CliFrontend` also reads config to get jobmanager address.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user rmetzger commented on the pull request:

    https://github.com/apache/incubator-flink/pull/48#issuecomment-47510600
 
    I agree. Rewriting the config for the `CliFrontend` is good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---