[GitHub] incubator-flink pull request: [FLINK-917] Rename netty IO thread c...

[zentol]

GitHub user uce opened a pull request:

    https://github.com/apache/incubator-flink/pull/5

    [FLINK-917] Rename netty IO thread count parameters

    Renames config parameters introduced in 4cd4a13415d609a2979c8fa3cf4b797c990ee8c2:
    - `taskmanager.netty.numInThreads => taskmanager.io.numInThreads`, and
    - `taskmanager.netty.numOutThreads => taskmanager.io.numOutThreads`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/incubator-flink FLINK-917

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5
   
----
commit 96dc4bb8f3bdb5a959a769f14e2d9d1262588cf5
Author: uce <[hidden email]>
Date:   2014-06-10T22:22:11Z

    [FLINK-917] Rename netty IO thread count parameters

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user StephanEwen commented on the pull request:

    https://github.com/apache/incubator-flink/pull/5#issuecomment-45892412
 
    `taskmanager.io.numInThreads` is a bit ambiguous with respect to disk I/O versus net I/O threads?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[Ufuk Celebi]

Yes, I agree. I was unsure with zeromq. What would you propose?

Sent from my iPhone

> On 12 Jun 2014, at 15:41, StephanEwen <[hidden email]> wrote:
>
> Github user StephanEwen commented on the pull request:
>
>    https://github.com/apache/incubator-flink/pull/5#issuecomment-45892412
>
>    `taskmanager.io.numInThreads` is a bit ambiguous with respect to disk I/O versus net I/O threads?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at [hidden email] or file a JIRA ticket
> with INFRA.
> ---

[Stephan Ewen]

Maybe " taskmanager.net.numInThreads" ?

[Ufuk Celebi]

Ok perfect this was my other contender as well ;)

Sent from my iPhone

> On 12 Jun 2014, at 18:27, Stephan Ewen <[hidden email]> wrote:
>
> Maybe " taskmanager.net.numInThreads" ?

[Ufuk Celebi]

I've updated the PR accordingly.

On 12 Jun 2014, at 19:33, Ufuk Celebi <[hidden email]> wrote:

> Ok perfect this was my other contender as well ;)
>
> Sent from my iPhone
>
>> On 12 Jun 2014, at 18:27, Stephan Ewen <[hidden email]> wrote:
>>
>> Maybe " taskmanager.net.numInThreads" ?

[zentol]

Github user StephanEwen commented on the pull request:

    https://github.com/apache/incubator-flink/pull/5#issuecomment-45997480
 
    Looks good, will merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[zentol]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-flink/pull/5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---