[GitHub] [flink-shaded] piyushnarang opened a new pull request #85: [FLINK-16955] Bump Zookeeper 3.4.X to 3.4.14

[GitBox]

piyushnarang opened a new pull request #85:
URL: https://github.com/apache/flink-shaded/pull/85


   Follow up from https://github.com/apache/flink/pull/11938 to commit in the right project.
   Picking up the updated zk dependency allows us to get around an issue in the `StaticHostProvider` in the current zk where if 1 of n configured zk hosts is unreachable the Flink job manager is not able to start up.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

piyushnarang commented on pull request #85:
URL: https://github.com/apache/flink-shaded/pull/85#issuecomment-621507875


   cc @zentol - I tried using this version on Flink and I hit the issues that were captured in https://issues.apache.org/jira/browse/FLINK-11259
   We need to make a minor tweak to the `SecureTestEnvironment.prepare(..)` to get around this - https://github.com/piyushnarang/flink/commit/fd6cc0311d0ef20606ba4566a54315a186889304


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

zentol commented on a change in pull request #85:
URL: https://github.com/apache/flink-shaded/pull/85#discussion_r417859654



##########
File path: flink-shaded-zookeeper-parent/flink-shaded-zookeeper-34/pom.xml
##########
@@ -128,4 +128,4 @@ under the License.
             </dependency>
         </dependencies>
     </dependencyManagement>
-</project>

Review comment:
       could you revert this tiny change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

piyushnarang commented on a change in pull request #85:
URL: https://github.com/apache/flink-shaded/pull/85#discussion_r418035841



##########
File path: flink-shaded-zookeeper-parent/flink-shaded-zookeeper-34/pom.xml
##########
@@ -128,4 +128,4 @@ under the License.
             </dependency>
         </dependencies>
     </dependencyManagement>
-</project>

Review comment:
       yes, will do. Missed this when I put it up




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

piyushnarang commented on pull request #85:
URL: https://github.com/apache/flink-shaded/pull/85#issuecomment-621874740


   Yeah, let me double check if things continue to work after the excludes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

piyushnarang commented on pull request #85:
URL: https://github.com/apache/flink-shaded/pull/85#issuecomment-622144494


   @zentol added the updates you requested. I did some basic sanity checking / testing after excluding the spotbugs and jsr305 and it seems to work ok. Do you know if there's a way to trigger the Flink full CI run for flink-shaded changes?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

zentol commented on pull request #85:
URL: https://github.com/apache/flink-shaded/pull/85#issuecomment-623430510


   @piyushnarang There is unfortunately no _easy_ way of doing that.
   I'd suggest to modify `tools/ci/maven-utils.sh` in the Flink project to checkout your branch, install it, and modifying the version property of Flink.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

piyushnarang commented on pull request #85:
URL: https://github.com/apache/flink-shaded/pull/85#issuecomment-623458136


   Ok, I've already done that degree of sanity checking and ran a few of the tests on my machine locally.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]