Admin access to github.com/apache/incubator-fl
Locked
Admin access to github.com/apache/incubator-fl
 
|
Hi all!
We are using pull requests against the github mirror. Once we merged the patch represented by the pull request, we cannot close the pull request, or change any status. We need to wait the user that opened the pull request to close it. This will probably lead to a lot of lingering pull requests and we need to manually cross check with jira to figure out whether pull requests are merged or not. It would be nice if committers had the permission to close pull requests against the github mirror repository. Has anyone experiences with that? Thanks, Stephan |
Re: Admin access to github.com/apache/incubator-fl
|
If you look at Apache Spark (which is using the GitHub integration for
quite some time now), it seems that they have exactly the situation you've described: A lot of lingering pull requests: https://github.com/apache/spark/pulls?direction=desc&page=8&sort=created&state=open Github has support for specifying administrators for individual repositories. If you want, I can ask INFRA if there is a way to solve the problem. On Fri, Jun 13, 2014 at 12:10 AM, Stephan Ewen <[hidden email]> wrote: > Hi all! > > We are using pull requests against the github mirror. > > Once we merged the patch represented by the pull request, we cannot close > the pull request, or change any status. We need to wait the user that > opened the pull request to close it. > > This will probably lead to a lot of lingering pull requests and we need to > manually cross check with jira to figure out whether pull requests are > merged or not. > > It would be nice if committers had the permission to close pull requests > against the github mirror repository. > > Has anyone experiences with that? > > Thanks, > Stephan > |
Re: Admin access to github.com/apache/incubator-fl
|
|
On 13 Jun 2014, at 09:54, Robert Metzger <[hidden email]> wrote: > If you look at Apache Spark (which is using the GitHub integration for > quite some time now), it seems that they have exactly the situation you've > described: A lot of lingering pull requests: > https://github.com/apache/spark/pulls?direction=desc&page=8&sort=created&state=open > Github has support for specifying administrators for individual > repositories. If you want, I can ask INFRA if there is a way to solve the > problem. +1 for asking INFRA ;) |
|
|
In reply to this post by Robert Metzger
The lingering pull requests are just backlog. I know that the asfgit
user can automatically close PRs too, since it does in Spark. I remember it can't close PRs opened against branches other than master though, and neither can committers / administrators. In fact I don't think anyone except asfgit can close a PR someone else opened, and it will close things only on a merge. I don't know the details of how this is set up -- are you already in contact with INFRA? But I know some degree of automation is available. On Fri, Jun 13, 2014 at 3:54 AM, Robert Metzger <[hidden email]> wrote: > If you look at Apache Spark (which is using the GitHub integration for > quite some time now), it seems that they have exactly the situation you've > described: A lot of lingering pull requests: > https://github.com/apache/spark/pulls?direction=desc&page=8&sort=created&state=open > Github has support for specifying administrators for individual > repositories. If you want, I can ask INFRA if there is a way to solve the > problem. > > > On Fri, Jun 13, 2014 at 12:10 AM, Stephan Ewen <[hidden email]> wrote: > >> Hi all! >> >> We are using pull requests against the github mirror. >> >> Once we merged the patch represented by the pull request, we cannot close >> the pull request, or change any status. We need to wait the user that >> opened the pull request to close it. >> >> This will probably lead to a lot of lingering pull requests and we need to >> manually cross check with jira to figure out whether pull requests are >> merged or not. >> >> It would be nice if committers had the permission to close pull requests >> against the github mirror repository. >> >> Has anyone experiences with that? >> >> Thanks, >> Stephan >> |
Re: Admin access to github.com/apache/incubator-fl
|
|
Very often we manually merge/rebase pull requests, which gives the commits
different hashes. In those cases, GitHub did not recognize pull requests as merged. Does that mean that all those Pull requests will remain open? |
Re: Admin access to github.com/apache/incubator-fl
|
|
No, as Sean said, that there is a mechanism for the "asfgit" user that it
closes the pull request. I'm not sure if it is parsing the commit messages, but the Spark commits contain the following *additional* text (for example:) Author: Henry Saputra > Closes #1060 from hsaputra/cleanup_connection_classes and squashes the > following commits: > 245fd09 [Henry Saputra] Cleanup on Connection and ConnectionManager to > make IDE happy while working of issue: 1. Replace var with var 2. Add > parentheses to Queue#dequeu to be consistent with side-effects. 3. Remove > return on final line of a method. I'll soon merge a pull request and try if adding "Closes #xxx" lets the bot close the PR. In addition to that, I've asked in the #asfinfra IRC channel. On Fri, Jun 13, 2014 at 2:17 PM, Stephan Ewen <[hidden email]> wrote: > Very often we manually merge/rebase pull requests, which gives the commits > different hashes. > In those cases, GitHub did not recognize pull requests as merged. > > Does that mean that all those Pull requests will remain open? > |
Re: Admin access to github.com/apache/incubator-fl
|
|
Ah, and reading the emails from the bot also helps. It says:
To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > This closes #16 With the next pull request I'm merging, I'll close all pull requests we want to be closed. On Fri, Jun 13, 2014 at 2:24 PM, Robert Metzger <[hidden email]> wrote: > No, as Sean said, that there is a mechanism for the "asfgit" user that it > closes the pull request. > I'm not sure if it is parsing the commit messages, but the Spark commits > contain the following *additional* text (for example:) > > Author: Henry Saputra >> Closes #1060 from hsaputra/cleanup_connection_classes and squashes the >> following commits: >> 245fd09 [Henry Saputra] Cleanup on Connection and ConnectionManager to >> make IDE happy while working of issue: 1. Replace var with var 2. Add >> parentheses to Queue#dequeu to be consistent with side-effects. 3. Remove >> return on final line of a method. > > > I'll soon merge a pull request and try if adding "Closes #xxx" lets the > bot close the PR. > In addition to that, I've asked in the #asfinfra IRC channel. > > > > On Fri, Jun 13, 2014 at 2:17 PM, Stephan Ewen <[hidden email]> wrote: > >> Very often we manually merge/rebase pull requests, which gives the commits >> different hashes. >> In those cases, GitHub did not recognize pull requests as merged. >> >> Does that mean that all those Pull requests will remain open? >> > > |
Re: Admin access to github.com/apache/incubator-fl
|
|
Dmitriy did a nice writeup for the new github integration of Mahout,
that could be helpful here: https://mahout.apache.org/developers/github.html --sebastian On 06/13/2014 02:26 PM, Robert Metzger wrote: > Ah, and reading the emails from the bot also helps. It says: > > To close this pull request, make a commit to your master/trunk branch >> with (at least) the following in the commit message: >> This closes #16 > > > With the next pull request I'm merging, I'll close all pull requests we > want to be closed. > > > > On Fri, Jun 13, 2014 at 2:24 PM, Robert Metzger <[hidden email]> wrote: > >> No, as Sean said, that there is a mechanism for the "asfgit" user that it >> closes the pull request. >> I'm not sure if it is parsing the commit messages, but the Spark commits >> contain the following *additional* text (for example:) >> >> Author: Henry Saputra >>> Closes #1060 from hsaputra/cleanup_connection_classes and squashes the >>> following commits: >>> 245fd09 [Henry Saputra] Cleanup on Connection and ConnectionManager to >>> make IDE happy while working of issue: 1. Replace var with var 2. Add >>> parentheses to Queue#dequeu to be consistent with side-effects. 3. Remove >>> return on final line of a method. >> >> >> I'll soon merge a pull request and try if adding "Closes #xxx" lets the >> bot close the PR. >> In addition to that, I've asked in the #asfinfra IRC channel. >> >> >> >> On Fri, Jun 13, 2014 at 2:17 PM, Stephan Ewen <[hidden email]> wrote: >> >>> Very often we manually merge/rebase pull requests, which gives the commits >>> different hashes. >>> In those cases, GitHub did not recognize pull requests as merged. >>> >>> Does that mean that all those Pull requests will remain open? >>> >> >> > |
Re: Admin access to github.com/apache/incubator-fl
|
|
@ssc Very nice, thanks for the source!
|
Re: Admin access to github.com/apache/incubator-fl
|
|
In reply to this post by Sebastian Schelter
And then Pat did some additions that somewhat messed up contributors' and
committers roles. In initial edition, committers did not (and do not) have to fork apache/<repo> on github to be able to merge a PR. In fact, they don't even have to have a github account in order to be able to the merge -- but then they'd want to comment and review PRs -- so stat needs a github account, of course. On Fri, Jun 13, 2014 at 5:39 AM, Sebastian Schelter <[hidden email]> wrote: > Dmitriy did a nice writeup for the new github integration of Mahout, that > could be helpful here: > > https://mahout.apache.org/developers/github.html > > --sebastian > > > On 06/13/2014 02:26 PM, Robert Metzger wrote: > >> Ah, and reading the emails from the bot also helps. It says: >> >> To close this pull request, make a commit to your master/trunk branch >> >>> with (at least) the following in the commit message: >>> This closes #16 >>> >> >> >> With the next pull request I'm merging, I'll close all pull requests we >> want to be closed. >> >> >> >> On Fri, Jun 13, 2014 at 2:24 PM, Robert Metzger <[hidden email]> >> wrote: >> >> No, as Sean said, that there is a mechanism for the "asfgit" user that it >>> closes the pull request. >>> I'm not sure if it is parsing the commit messages, but the Spark commits >>> contain the following *additional* text (for example:) >>> >>> Author: Henry Saputra >>> >>>> Closes #1060 from hsaputra/cleanup_connection_classes and squashes the >>>> following commits: >>>> 245fd09 [Henry Saputra] Cleanup on Connection and ConnectionManager to >>>> make IDE happy while working of issue: 1. Replace var with var 2. Add >>>> parentheses to Queue#dequeu to be consistent with side-effects. 3. >>>> Remove >>>> return on final line of a method. >>>> >>> >>> >>> I'll soon merge a pull request and try if adding "Closes #xxx" lets the >>> bot close the PR. >>> In addition to that, I've asked in the #asfinfra IRC channel. >>> >>> >>> >>> On Fri, Jun 13, 2014 at 2:17 PM, Stephan Ewen <[hidden email]> wrote: >>> >>> Very often we manually merge/rebase pull requests, which gives the >>>> commits >>>> different hashes. >>>> In those cases, GitHub did not recognize pull requests as merged. >>>> >>>> Does that mean that all those Pull requests will remain open? >>>> >>>> >>> >>> >> > |
Re: Admin access to github.com/apache/incubator-fl
|
|
In reply to this post by Robert Metzger
Yes, please do include the statement to make asfgit close the PR.
We need to make good merge scripts for committer to help merging PRs from github. Sorry for late response, I am out of town with limited access to Internet. - Henry On Friday, June 13, 2014, Robert Metzger <[hidden email]> wrote: > Ah, and reading the emails from the bot also helps. It says: > > To close this pull request, make a commit to your master/trunk branch > > with (at least) the following in the commit message: > > This closes #16 > > > With the next pull request I'm merging, I'll close all pull requests we > want to be closed. > > > > On Fri, Jun 13, 2014 at 2:24 PM, Robert Metzger <[hidden email] > <javascript:;>> wrote: > > > No, as Sean said, that there is a mechanism for the "asfgit" user that it > > closes the pull request. > > I'm not sure if it is parsing the commit messages, but the Spark commits > > contain the following *additional* text (for example:) > > > > Author: Henry Saputra > >> Closes #1060 from hsaputra/cleanup_connection_classes and squashes the > >> following commits: > >> 245fd09 [Henry Saputra] Cleanup on Connection and ConnectionManager to > >> make IDE happy while working of issue: 1. Replace var with var 2. Add > >> parentheses to Queue#dequeu to be consistent with side-effects. 3. > Remove > >> return on final line of a method. > > > > > > I'll soon merge a pull request and try if adding "Closes #xxx" lets the > > bot close the PR. > > In addition to that, I've asked in the #asfinfra IRC channel. > > > > > > > > On Fri, Jun 13, 2014 at 2:17 PM, Stephan Ewen <[hidden email] > <javascript:;>> wrote: > > > >> Very often we manually merge/rebase pull requests, which gives the > commits > >> different hashes. > >> In those cases, GitHub did not recognize pull requests as merged. > >> > >> Does that mean that all those Pull requests will remain open? > >> > > > > > |
«
Return to (DEPRECATED) Apache Flink Mailing List archive.
|
1 view|%1 views
| Free forum by Nabble | Edit this page |