withParameters() for Streaming API

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

withParameters() for Streaming API

Timo Walther-2
Hi all,

I want to set the Configuration of a streaming operator and access it
via the open method of the RichFunction.
There is no possibility to set the Configuration of the open method at
the moment, right? Can I open an issue for a withParameters() equivalent
for the Stremaing API?

Regards,
Timo
Reply | Threaded
Open this post in threaded view
|

Re: withParameters() for Streaming API

Matthias J. Sax-2
We had this discussion a while ago.

If I recall correctly, "withParameters()" is not encourage to be used in
DataSet either.

This is the thread:
https://mail-archives.apache.org/mod_mbox/flink-dev/201509.mbox/%3C55EC69CD.1070003%40apache.org%3E

-Matthias

On 11/24/2015 02:14 PM, Timo Walther wrote:

> Hi all,
>
> I want to set the Configuration of a streaming operator and access it
> via the open method of the RichFunction.
> There is no possibility to set the Configuration of the open method at
> the moment, right? Can I open an issue for a withParameters() equivalent
> for the Stremaing API?
>
> Regards,
> Timo
>


signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: withParameters() for Streaming API

Timo Walther-2
Thanks for the hint Matthias.
So actually the parameter of the open() method is useless? IMHO that
does not look like a nice API design...
We should try to keep DataSet and DataStream API in sync.
Does it make sense to deprecate withParameters() for 1.0?

Timo

On 24.11.2015 14:31, Matthias J. Sax wrote:

> We had this discussion a while ago.
>
> If I recall correctly, "withParameters()" is not encourage to be used in
> DataSet either.
>
> This is the thread:
> https://mail-archives.apache.org/mod_mbox/flink-dev/201509.mbox/%3C55EC69CD.1070003%40apache.org%3E
>
> -Matthias
>
> On 11/24/2015 02:14 PM, Timo Walther wrote:
>> Hi all,
>>
>> I want to set the Configuration of a streaming operator and access it
>> via the open method of the RichFunction.
>> There is no possibility to set the Configuration of the open method at
>> the moment, right? Can I open an issue for a withParameters() equivalent
>> for the Stremaing API?
>>
>> Regards,
>> Timo
>>

Reply | Threaded
Open this post in threaded view
|

Re: withParameters() for Streaming API

Stephan Ewen
I was also thinking of deprecating that. With that, RichFunctions should
change "open(Configuration)" --> "open()".

Would be heavily API breaking, so bit hesitant there...

On Tue, Nov 24, 2015 at 2:48 PM, Timo Walther <[hidden email]> wrote:

> Thanks for the hint Matthias.
> So actually the parameter of the open() method is useless? IMHO that does
> not look like a nice API design...
> We should try to keep DataSet and DataStream API in sync.
> Does it make sense to deprecate withParameters() for 1.0?
>
> Timo
>
>
> On 24.11.2015 14:31, Matthias J. Sax wrote:
>
>> We had this discussion a while ago.
>>
>> If I recall correctly, "withParameters()" is not encourage to be used in
>> DataSet either.
>>
>> This is the thread:
>>
>> https://mail-archives.apache.org/mod_mbox/flink-dev/201509.mbox/%3C55EC69CD.1070003%40apache.org%3E
>>
>> -Matthias
>>
>> On 11/24/2015 02:14 PM, Timo Walther wrote:
>>
>>> Hi all,
>>>
>>> I want to set the Configuration of a streaming operator and access it
>>> via the open method of the RichFunction.
>>> There is no possibility to set the Configuration of the open method at
>>> the moment, right? Can I open an issue for a withParameters() equivalent
>>> for the Stremaing API?
>>>
>>> Regards,
>>> Timo
>>>
>>>
>
Reply | Threaded
Open this post in threaded view
|

Re: withParameters() for Streaming API

Till Rohrmann
If not API breaking before 1.0, then probably never?

On Tue, Nov 24, 2015 at 3:06 PM, Stephan Ewen <[hidden email]> wrote:

> I was also thinking of deprecating that. With that, RichFunctions should
> change "open(Configuration)" --> "open()".
>
> Would be heavily API breaking, so bit hesitant there...
>
> On Tue, Nov 24, 2015 at 2:48 PM, Timo Walther <[hidden email]> wrote:
>
> > Thanks for the hint Matthias.
> > So actually the parameter of the open() method is useless? IMHO that does
> > not look like a nice API design...
> > We should try to keep DataSet and DataStream API in sync.
> > Does it make sense to deprecate withParameters() for 1.0?
> >
> > Timo
> >
> >
> > On 24.11.2015 14:31, Matthias J. Sax wrote:
> >
> >> We had this discussion a while ago.
> >>
> >> If I recall correctly, "withParameters()" is not encourage to be used in
> >> DataSet either.
> >>
> >> This is the thread:
> >>
> >>
> https://mail-archives.apache.org/mod_mbox/flink-dev/201509.mbox/%3C55EC69CD.1070003%40apache.org%3E
> >>
> >> -Matthias
> >>
> >> On 11/24/2015 02:14 PM, Timo Walther wrote:
> >>
> >>> Hi all,
> >>>
> >>> I want to set the Configuration of a streaming operator and access it
> >>> via the open method of the RichFunction.
> >>> There is no possibility to set the Configuration of the open method at
> >>> the moment, right? Can I open an issue for a withParameters()
> equivalent
> >>> for the Stremaing API?
> >>>
> >>> Regards,
> >>> Timo
> >>>
> >>>
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: withParameters() for Streaming API

Suneel Marthi
Agree with @till +1 to change this now

On Tue, Nov 24, 2015 at 9:15 AM, Till Rohrmann <[hidden email]> wrote:

> If not API breaking before 1.0, then probably never?
>
> On Tue, Nov 24, 2015 at 3:06 PM, Stephan Ewen <[hidden email]> wrote:
>
> > I was also thinking of deprecating that. With that, RichFunctions should
> > change "open(Configuration)" --> "open()".
> >
> > Would be heavily API breaking, so bit hesitant there...
> >
> > On Tue, Nov 24, 2015 at 2:48 PM, Timo Walther <[hidden email]>
> wrote:
> >
> > > Thanks for the hint Matthias.
> > > So actually the parameter of the open() method is useless? IMHO that
> does
> > > not look like a nice API design...
> > > We should try to keep DataSet and DataStream API in sync.
> > > Does it make sense to deprecate withParameters() for 1.0?
> > >
> > > Timo
> > >
> > >
> > > On 24.11.2015 14:31, Matthias J. Sax wrote:
> > >
> > >> We had this discussion a while ago.
> > >>
> > >> If I recall correctly, "withParameters()" is not encourage to be used
> in
> > >> DataSet either.
> > >>
> > >> This is the thread:
> > >>
> > >>
> >
> https://mail-archives.apache.org/mod_mbox/flink-dev/201509.mbox/%3C55EC69CD.1070003%40apache.org%3E
> > >>
> > >> -Matthias
> > >>
> > >> On 11/24/2015 02:14 PM, Timo Walther wrote:
> > >>
> > >>> Hi all,
> > >>>
> > >>> I want to set the Configuration of a streaming operator and access it
> > >>> via the open method of the RichFunction.
> > >>> There is no possibility to set the Configuration of the open method
> at
> > >>> the moment, right? Can I open an issue for a withParameters()
> > equivalent
> > >>> for the Stremaing API?
> > >>>
> > >>> Regards,
> > >>> Timo
> > >>>
> > >>>
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: withParameters() for Streaming API

Chesnay Schepler-2
should we do the same for IOFormats to be consistent? after FLINK-2351
they aren't used by our formats.

On 24.11.2015 15:17, Suneel Marthi wrote:

> Agree with @till +1 to change this now
>
> On Tue, Nov 24, 2015 at 9:15 AM, Till Rohrmann <[hidden email]> wrote:
>
>> If not API breaking before 1.0, then probably never?
>>
>> On Tue, Nov 24, 2015 at 3:06 PM, Stephan Ewen <[hidden email]> wrote:
>>
>>> I was also thinking of deprecating that. With that, RichFunctions should
>>> change "open(Configuration)" --> "open()".
>>>
>>> Would be heavily API breaking, so bit hesitant there...
>>>
>>> On Tue, Nov 24, 2015 at 2:48 PM, Timo Walther <[hidden email]>
>> wrote:
>>>> Thanks for the hint Matthias.
>>>> So actually the parameter of the open() method is useless? IMHO that
>> does
>>>> not look like a nice API design...
>>>> We should try to keep DataSet and DataStream API in sync.
>>>> Does it make sense to deprecate withParameters() for 1.0?
>>>>
>>>> Timo
>>>>
>>>>
>>>> On 24.11.2015 14:31, Matthias J. Sax wrote:
>>>>
>>>>> We had this discussion a while ago.
>>>>>
>>>>> If I recall correctly, "withParameters()" is not encourage to be used
>> in
>>>>> DataSet either.
>>>>>
>>>>> This is the thread:
>>>>>
>>>>>
>> https://mail-archives.apache.org/mod_mbox/flink-dev/201509.mbox/%3C55EC69CD.1070003%40apache.org%3E
>>>>> -Matthias
>>>>>
>>>>> On 11/24/2015 02:14 PM, Timo Walther wrote:
>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> I want to set the Configuration of a streaming operator and access it
>>>>>> via the open method of the RichFunction.
>>>>>> There is no possibility to set the Configuration of the open method
>> at
>>>>>> the moment, right? Can I open an issue for a withParameters()
>>> equivalent
>>>>>> for the Stremaing API?
>>>>>>
>>>>>> Regards,
>>>>>> Timo
>>>>>>
>>>>>>