time format for akka status

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

time format for akka status

Alexey Demin
Hi

In ExecutionGraphMessages we have code

private val DATE_FORMATTER: SimpleDateFormat = new
SimpleDateFormat("MM/dd/yyyy HH:mm:ss")

But sometimes it cause confusion when main logger configured with
"dd/MM/yyyy".

What are you thinking about making this format configurable or maybe stay
only  HH:mm:ss

Thanks, Alexey
Reply | Threaded
Open this post in threaded view
|

Re: time format for akka status

Till Rohrmann
Hi Alexey,

this is a good proposal. Could you open a corresponding JIRA issue for this
change?

Cheers,
Till

On Sun, Jan 8, 2017 at 8:32 AM, Alexey Demin <[hidden email]> wrote:

> Hi
>
> In ExecutionGraphMessages we have code
>
> private val DATE_FORMATTER: SimpleDateFormat = new
> SimpleDateFormat("MM/dd/yyyy HH:mm:ss")
>
> But sometimes it cause confusion when main logger configured with
> "dd/MM/yyyy".
>
> What are you thinking about making this format configurable or maybe stay
> only  HH:mm:ss
>
> Thanks, Alexey
>
Reply | Threaded
Open this post in threaded view
|

Re: time format for akka status

Alexey Demin
Hi, Till

I created https://issues.apache.org/jira/browse/FLINK-5431

I prefer use "yyyy-MM-dd HH:mm:ss" because it's more similar to ISO date
format.
We can't stay only "HH:mm:ss" because this formatter are using for output
data on console (System.out )
and for longrunning applications print hours without date very
uninformative.

What do you think?

Thanks,
Alexey


2017-01-09 17:25 GMT+04:00 Till Rohrmann <[hidden email]>:

> Hi Alexey,
>
> this is a good proposal. Could you open a corresponding JIRA issue for this
> change?
>
> Cheers,
> Till
>
> On Sun, Jan 8, 2017 at 8:32 AM, Alexey Demin <[hidden email]> wrote:
>
> > Hi
> >
> > In ExecutionGraphMessages we have code
> >
> > private val DATE_FORMATTER: SimpleDateFormat = new
> > SimpleDateFormat("MM/dd/yyyy HH:mm:ss")
> >
> > But sometimes it cause confusion when main logger configured with
> > "dd/MM/yyyy".
> >
> > What are you thinking about making this format configurable or maybe stay
> > only  HH:mm:ss
> >
> > Thanks, Alexey
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: time format for akka status

Till Rohrmann
Hi Alexey,

I agree with your proposal to use "yyyy-MM-dd HH:mm:ss" or even
"yyyy-MM-ddTHH:mm:ss" to follow the ISO standard per default but still give
the user the possibility to configure it.

Cheers,
Till

On Mon, Jan 9, 2017 at 7:10 PM, Alexey Demin <[hidden email]> wrote:

> Hi, Till
>
> I created https://issues.apache.org/jira/browse/FLINK-5431
>
> I prefer use "yyyy-MM-dd HH:mm:ss" because it's more similar to ISO date
> format.
> We can't stay only "HH:mm:ss" because this formatter are using for output
> data on console (System.out )
> and for longrunning applications print hours without date very
> uninformative.
>
> What do you think?
>
> Thanks,
> Alexey
>
>
> 2017-01-09 17:25 GMT+04:00 Till Rohrmann <[hidden email]>:
>
> > Hi Alexey,
> >
> > this is a good proposal. Could you open a corresponding JIRA issue for
> this
> > change?
> >
> > Cheers,
> > Till
> >
> > On Sun, Jan 8, 2017 at 8:32 AM, Alexey Demin <[hidden email]> wrote:
> >
> > > Hi
> > >
> > > In ExecutionGraphMessages we have code
> > >
> > > private val DATE_FORMATTER: SimpleDateFormat = new
> > > SimpleDateFormat("MM/dd/yyyy HH:mm:ss")
> > >
> > > But sometimes it cause confusion when main logger configured with
> > > "dd/MM/yyyy".
> > >
> > > What are you thinking about making this format configurable or maybe
> stay
> > > only  HH:mm:ss
> > >
> > > Thanks, Alexey
> > >
> >
>