Re: Add customized "merge_spark_pr.py" script to Flink repo?

Posted by Robert Metzger on
URL: http://deprecated-apache-flink-mailing-list-archive.368.s1.nabble.com/Add-customized-merge-spark-pr-py-script-to-Flink-repo-tp619p628.html

The script includes this into the commit message.


On Fri, Jun 20, 2014 at 9:52 PM, Henry Saputra <[hidden email]>
wrote:

> +1
>
> Seems like good script. We may need to check for commit message if it has
> "This closes ..." To make asfgit bot to auto close Github PRs.
>
> - Henry
>
> On Friday, June 20, 2014, Robert Metzger <[hidden email]> wrote:
>
> > Hi,
> >
> > during our discussion on how to close the Github pull requests, Henry
> > suggested to create a script for merging pull requests (
> >
> >
> http://apache-flink-incubator-mailing-list-archive.1008284.n3.nabble.com/Admin-access-to-github-com-apache-incubator-flink-tp160p246.html
> > ).
> >
> > I found a nice python script in the Spark repository that does exactly
> > this. It assumes exactly our setup with the GitHub integration and can
> even
> > automatically close the JIRA if its ID is contained in the pull request
> > title.
> >
> > This shows how the tool works:
> > https://gist.github.com/rmetzger/cf4d2eba940483d704a2
> > So committers have to basically enter the pull request ID, press "y"
> three
> > times and everything is done. (You can still check if everything is
> correct
> > in another window).
> >
> > What do you think? Should I merge it into the "tools" directory?
> >
> > Robert
> >
>