Re: "Validate" (commons) versus "checkArgument" (guava)

Posted by Robert Metzger on Jun 02, 2015; 7:21pm
URL: http://deprecated-apache-flink-mailing-list-archive.368.s1.nabble.com/Validate-commons-versus-checkArgument-guava-tp4286p5996.html

Adding an entry here: http://flink.apache.org/coding-guidelines.html is
certainly good, yes.
You can contribute to the website here: https://github.com/apache/flink-web

We enforce coding guidelines using the maven checkstyle plugin. Maybe there
is a way of forbidding certain imports

On Tue, Jun 2, 2015 at 9:18 PM, Lokesh Rajaram <[hidden email]>
wrote:

> Hello Robert,
>
> I worked on that issue, if it's ok I can take this task.
>
> Btw, how is anything enforced in Flink? Do I have to update how to
> contribute guide or any thing else need to be done?
>
> Sent from my iPhone
>
> > On Jun 2, 2015, at 12:11 PM, Robert Metzger <[hidden email]> wrote:
> >
> > We have now replaced all commons validate calls with guava preconditions
> > but its not written down anywhere or enforced by anything.
> >
> > Who would like to take care of that?
> >
> > On Thu, Mar 26, 2015 at 11:03 AM, Robert Metzger <[hidden email]>
> > wrote:
> >
> >> I didn't know that there was already an issue for this. I closed
> >> FLINK-1787.
> >> The correct issue is this one:
> >> https://issues.apache.org/jira/browse/FLINK-1711
> >>
>