Login  Register

Re: "Validate" (commons) versus "checkArgument" (guava)

Posted by Robert Metzger on Mar 26, 2015; 9:49am
URL: http://deprecated-apache-flink-mailing-list-archive.368.s1.nabble.com/Validate-commons-versus-checkArgument-guava-tp4286p4734.html

I created a "starter" task JIRA for this.
https://issues.apache.org/jira/browse/FLINK-1787


On Sun, Mar 8, 2015 at 3:23 PM, Aljoscha Krettek <[hidden email]>
wrote:

> +1 I also tend to use guava.
>
> On Sun, Mar 8, 2015 at 3:21 PM, Ufuk Celebi <[hidden email]> wrote:
> >
> > On 08 Mar 2015, at 15:05, Stephan Ewen <[hidden email]> wrote:
> >
> >> Different parts of the code currently use different utilities to
> validate
> >> the arguments.
> >>
> >>  - Some parts use Guava (checkNotNull, checkArgument)
> >>  - Other parts use Validate from Apache commons-lang(3).
> >>
> >> How about we use one consistently, at least for all new code additions?
> >>
> >> In choosing one, I have a slight bias towards Guava, which has
> more/nicer
> >> methods and seems more popular in other projects (I have no source to
> back
> >> this up, it is a gut feeling from what I have seen in other projects
> that I
> >> looked into)
> >
> > +1 I'm always using Guava for the same reasons.
>