[GitHub] incubator-flink pull request: [FLINK-930] Netty Initialization is ...

Posted by zentol on Jun 17, 2014; 6:56am
URL: http://deprecated-apache-flink-mailing-list-archive.368.s1.nabble.com/GitHub-incubator-flink-pull-request-FLINK-930-Netty-Initialization-is-tp254p315.html

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/19#discussion_r13845310
 
    --- Diff: stratosphere-runtime/src/main/java/eu/stratosphere/runtime/io/network/netty/NettyConnectionManager.java ---
    @@ -108,9 +130,9 @@ public void initChannel(SocketChannel channel) throws Exception {
      .option(ChannelOption.SO_KEEPALIVE, true);
     
      try {
    - this.in.bind().sync();
    + in.bind().sync();
      } catch (InterruptedException e) {
    - throw new RuntimeException("Could not bind server socket for incoming connections.");
    + throw new IOException("Interrupted while trying to bind server socket.");
    --- End diff --
   
    I would also forward the exception here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---