Re: Admin access to github.com/apache/incubator-flink

Posted by Henry Saputra on Jun 15, 2014; 3:10am
URL: http://deprecated-apache-flink-mailing-list-archive.368.s1.nabble.com/Admin-access-to-github-com-apache-incubator-flink-tp160p246.html

Yes, please do include the statement to make asfgit close the PR.

We need to make good merge scripts for committer to help merging PRs from
github.

Sorry for late response, I am out of town with limited access to Internet.

- Henry

On Friday, June 13, 2014, Robert Metzger <[hidden email]> wrote:

> Ah, and reading the emails from the bot also helps. It says:
>
> To close this pull request, make a commit to your master/trunk branch
> > with (at least) the following in the commit message:
> >     This closes #16
>
>
> With the next pull request I'm merging, I'll close all pull requests we
> want to be closed.
>
>
>
> On Fri, Jun 13, 2014 at 2:24 PM, Robert Metzger <[hidden email]
> <javascript:;>> wrote:
>
> > No, as Sean said, that there is a mechanism for the "asfgit" user that it
> > closes the pull request.
> > I'm not sure if it is parsing the commit messages, but the Spark commits
> > contain the following *additional* text (for example:)
> >
> > Author: Henry Saputra
> >> Closes #1060 from hsaputra/cleanup_connection_classes and squashes the
> >> following commits:
> >> 245fd09 [Henry Saputra] Cleanup on Connection and ConnectionManager to
> >> make IDE happy while working of issue: 1. Replace var with var 2. Add
> >> parentheses to Queue#dequeu to be consistent with side-effects. 3.
> Remove
> >> return on final line of a method.
> >
> >
> > I'll soon merge a pull request and try if adding "Closes #xxx" lets the
> > bot close the PR.
> > In addition to that, I've asked in the #asfinfra IRC channel.
> >
> >
> >
> > On Fri, Jun 13, 2014 at 2:17 PM, Stephan Ewen <[hidden email]
> <javascript:;>> wrote:
> >
> >> Very often we manually merge/rebase pull requests, which gives the
> commits
> >> different hashes.
> >> In those cases, GitHub did not recognize pull requests as merged.
> >>
> >> Does that mean that all those Pull requests will remain open?
> >>
> >
> >
>