Posted by
Robert Metzger on
Jun 13, 2014; 12:24pm
URL: http://deprecated-apache-flink-mailing-list-archive.368.s1.nabble.com/Admin-access-to-github-com-apache-incubator-flink-tp160p209.html
No, as Sean said, that there is a mechanism for the "asfgit" user that it
closes the pull request.
I'm not sure if it is parsing the commit messages, but the Spark commits
contain the following *additional* text (for example:)
Author: Henry Saputra
> Closes #1060 from hsaputra/cleanup_connection_classes and squashes the
> following commits:
> 245fd09 [Henry Saputra] Cleanup on Connection and ConnectionManager to
> make IDE happy while working of issue: 1. Replace var with var 2. Add
> parentheses to Queue#dequeu to be consistent with side-effects. 3. Remove
> return on final line of a method.
I'll soon merge a pull request and try if adding "Closes #xxx" lets the bot
close the PR.
In addition to that, I've asked in the #asfinfra IRC channel.
On Fri, Jun 13, 2014 at 2:17 PM, Stephan Ewen <
[hidden email]> wrote:
> Very often we manually merge/rebase pull requests, which gives the commits
> different hashes.
> In those cases, GitHub did not recognize pull requests as merged.
>
> Does that mean that all those Pull requests will remain open?
>