https://flink.apache.org/contribute-code.html recommends running 'mvn clean verify', but when I do (on master), the build fails:
... [INFO] Parsing exclusions from C:\usr\git\flink\.gitignore ... [INFO] Rat check: Summary over all files. Unapproved: 2, unknown: 2, generated: 0, approved: 8064 licenses. ... [INFO] flink .............................................. FAILURE [ 20.726 s] Files with unapproved licenses: flink-runtime/src/test/resources/heap_keyed_statebackend_1_2.snapshot flink-runtime/src/test/resources/heap_keyed_statebackend_1_5_map.snapshot Do we need to update .gitignore? For these two files only, or for some new pattern? Thanks, Alex |
These files are automatically detected as binary files on unix and thus
automatically ignored by the RAT plugin, but not on Windows. Most Flink devs run unix and don't run into this problem, and thus don't define a proper exclusion. This happens regularly. It would be great if you could open a PR to add the missing exclusions. On 09.07.2018 21:47, NEKRASSOV, ALEXEI wrote: > https://flink.apache.org/contribute-code.html recommends running 'mvn clean verify', but when I do (on master), the build fails: > > ... > [INFO] Parsing exclusions from C:\usr\git\flink\.gitignore > ... > [INFO] Rat check: Summary over all files. Unapproved: 2, unknown: 2, generated: 0, approved: 8064 licenses. > ... > [INFO] flink .............................................. FAILURE [ 20.726 s] > > Files with unapproved licenses: > > flink-runtime/src/test/resources/heap_keyed_statebackend_1_2.snapshot > flink-runtime/src/test/resources/heap_keyed_statebackend_1_5_map.snapshot > > Do we need to update .gitignore? For these two files only, or for some new pattern? > > Thanks, > Alex > |
Does such a change require JIRA?
https://flink.apache.org/contribute-code.html says: "... with an exception for trivial hot fixes..." but when I go to create a pull request, I see: "Exceptions are made for typos in JavaDoc or documentation". I see inconsistency here... :) -----Original Message----- From: Chesnay Schepler [mailto:[hidden email]] Sent: Monday, July 09, 2018 4:24 PM To: [hidden email]; NEKRASSOV, ALEXEI <[hidden email]> Subject: Re: 'mvn verify' fails on rat plugin These files are automatically detected as binary files on unix and thus automatically ignored by the RAT plugin, but not on Windows. Most Flink devs run unix and don't run into this problem, and thus don't define a proper exclusion. This happens regularly. It would be great if you could open a PR to add the missing exclusions. On 09.07.2018 21:47, NEKRASSOV, ALEXEI wrote: > https://urldefense.proofpoint.com/v2/url?u=https-3A__flink.apache.org_contribute-2Dcode.html&d=DwIC3g&c=LFYZ-o9_HUMeMTSQicvjIg&r=aQRKg6d5fsz42zXkyiSdqg&m=BtUtXJtmUmFVBy9uXGsQs21fwy5dSvOHpeiXxLefQd8&s=_8QQZVgu0HFV2KxPaD6g8q4DHpRdXdvbjmV4u_STieg&e= recommends running 'mvn clean verify', but when I do (on master), the build fails: > > ... > [INFO] Parsing exclusions from C:\usr\git\flink\.gitignore ... > [INFO] Rat check: Summary over all files. Unapproved: 2, unknown: 2, generated: 0, approved: 8064 licenses. > ... > [INFO] flink .............................................. FAILURE [ > 20.726 s] > > Files with unapproved licenses: > > flink-runtime/src/test/resources/heap_keyed_statebackend_1_2.snapshot > > flink-runtime/src/test/resources/heap_keyed_statebackend_1_5_map.snaps > hot > > Do we need to update .gitignore? For these two files only, or for some new pattern? > > Thanks, > Alex > |
Alex,
I've already submitted similar kind of patch without explicit JIRA issue ( https://github.com/apache/flink/pull/6256) so I guess you don't need to file one. Thanks, Jungtaek Lim (HeartSaVioR) 2018년 7월 10일 (화) 오전 8:57, NEKRASSOV, ALEXEI <[hidden email]>님이 작성: > Does such a change require JIRA? > > https://flink.apache.org/contribute-code.html says: "... with an > exception for trivial hot fixes..." but when I go to create a pull request, > I see: "Exceptions are made for typos in JavaDoc or documentation". > I see inconsistency here... :) > > > -----Original Message----- > From: Chesnay Schepler [mailto:[hidden email]] > Sent: Monday, July 09, 2018 4:24 PM > To: [hidden email]; NEKRASSOV, ALEXEI <[hidden email]> > Subject: Re: 'mvn verify' fails on rat plugin > > These files are automatically detected as binary files on unix and thus > automatically ignored by the RAT plugin, but not on Windows. > Most Flink devs run unix and don't run into this problem, and thus don't > define a proper exclusion. > This happens regularly. > > It would be great if you could open a PR to add the missing exclusions. > > On 09.07.2018 21:47, NEKRASSOV, ALEXEI wrote: > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__flink.apache.org_contribute-2Dcode.html&d=DwIC3g&c=LFYZ-o9_HUMeMTSQicvjIg&r=aQRKg6d5fsz42zXkyiSdqg&m=BtUtXJtmUmFVBy9uXGsQs21fwy5dSvOHpeiXxLefQd8&s=_8QQZVgu0HFV2KxPaD6g8q4DHpRdXdvbjmV4u_STieg&e= > recommends running 'mvn clean verify', but when I do (on master), the build > fails: > > > > ... > > [INFO] Parsing exclusions from C:\usr\git\flink\.gitignore ... > > [INFO] Rat check: Summary over all files. Unapproved: 2, unknown: 2, > generated: 0, approved: 8064 licenses. > > ... > > [INFO] flink .............................................. FAILURE [ > > 20.726 s] > > > > Files with unapproved licenses: > > > > flink-runtime/src/test/resources/heap_keyed_statebackend_1_2.snapshot > > > > flink-runtime/src/test/resources/heap_keyed_statebackend_1_5_map.snaps > > hot > > > > Do we need to update .gitignore? For these two files only, or for some > new pattern? > > > > Thanks, > > Alex > > > > |
HeartSaVioR, thanks for the helpful pointer!
PR created: https://github.com/apache/flink/pull/6295 -----Original Message----- From: Jungtaek Lim [mailto:[hidden email]] Sent: Monday, July 09, 2018 11:43 PM To: [hidden email] Cc: Chesnay Schepler <[hidden email]> Subject: Re: 'mvn verify' fails on rat plugin Alex, I've already submitted similar kind of patch without explicit JIRA issue ( https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_flink_pull_6256&d=DwIFaQ&c=LFYZ-o9_HUMeMTSQicvjIg&r=aQRKg6d5fsz42zXkyiSdqg&m=tTDLBdeCUA6c3QaIR_k3b3fV8-z82q1gcI1bA2HHna4&s=gnWwo2FrEO0aXWkIffbOFdob5aE3Vnst-7Fr-JAC26M&e=) so I guess you don't need to file one. Thanks, Jungtaek Lim (HeartSaVioR) 2018년 7월 10일 (화) 오전 8:57, NEKRASSOV, ALEXEI <[hidden email]>님이 작성: > Does such a change require JIRA? > > https://urldefense.proofpoint.com/v2/url?u=https-3A__flink.apache.org_ > contribute-2Dcode.html&d=DwIFaQ&c=LFYZ-o9_HUMeMTSQicvjIg&r=aQRKg6d5fsz > 42zXkyiSdqg&m=tTDLBdeCUA6c3QaIR_k3b3fV8-z82q1gcI1bA2HHna4&s=oyBnxCDK_Gcgia7TqF56V6en_K41aaN-0lxXk2nv6Ak&e= says: "... with an exception for trivial hot fixes..." but when I go to create a pull request, I see: "Exceptions are made for typos in JavaDoc or documentation". > I see inconsistency here... :) > > > -----Original Message----- > From: Chesnay Schepler [mailto:[hidden email]] > Sent: Monday, July 09, 2018 4:24 PM > To: [hidden email]; NEKRASSOV, ALEXEI <[hidden email]> > Subject: Re: 'mvn verify' fails on rat plugin > > These files are automatically detected as binary files on unix and > thus automatically ignored by the RAT plugin, but not on Windows. > Most Flink devs run unix and don't run into this problem, and thus > don't define a proper exclusion. > This happens regularly. > > It would be great if you could open a PR to add the missing exclusions. > > On 09.07.2018 21:47, NEKRASSOV, ALEXEI wrote: > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__flink.apache.org_ > contribute-2Dcode.html&d=DwIC3g&c=LFYZ-o9_HUMeMTSQicvjIg&r=aQRKg6d5fsz > 42zXkyiSdqg&m=BtUtXJtmUmFVBy9uXGsQs21fwy5dSvOHpeiXxLefQd8&s=_8QQZVgu0H > FV2KxPaD6g8q4DHpRdXdvbjmV4u_STieg&e= > recommends running 'mvn clean verify', but when I do (on master), the > build > fails: > > > > ... > > [INFO] Parsing exclusions from C:\usr\git\flink\.gitignore ... > > [INFO] Rat check: Summary over all files. Unapproved: 2, unknown: 2, > generated: 0, approved: 8064 licenses. > > ... > > [INFO] flink .............................................. FAILURE > > [ > > 20.726 s] > > > > Files with unapproved licenses: > > > > > > flink-runtime/src/test/resources/heap_keyed_statebackend_1_2.snapsho > > t > > > > flink-runtime/src/test/resources/heap_keyed_statebackend_1_5_map.sna > > ps > > hot > > > > Do we need to update .gitignore? For these two files only, or for > > some > new pattern? > > > > Thanks, > > Alex > > > > |
Free forum by Nabble | Edit this page |