[jira] [Created] (FLINK-9665) PrometheusReporter does not properly unregister metrics

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-9665) PrometheusReporter does not properly unregister metrics

Shang Yuanchun (Jira)
Chesnay Schepler created FLINK-9665:
---------------------------------------

             Summary: PrometheusReporter does not properly unregister metrics
                 Key: FLINK-9665
                 URL: https://issues.apache.org/jira/browse/FLINK-9665
             Project: Flink
          Issue Type: Bug
          Components: Metrics
    Affects Versions: 1.4.2, 1.5.0, 1.6.0
            Reporter: Chesnay Schepler
            Assignee: Chesnay Schepler


The {{PrometheusReporter}} groups metrics with the same logical scope in a single {{Collector}} which are periodically polled by Prometheus.

New metrics are added to an existing collector, and a reference count is maintained so we can eventually cleanup the {{Collector}} itself.

For removed metrics we decrease the reference count, do not however remove the metrics that were added. As a result the collector will continue to expose metrics, as long as at least 1 metric exists with the same logical scope.

If the collector is a {{io.prometheus.client.Gauge}} we can use the {{#remove()}} method. For histograms we will have to modify our {{HistogramSummaryProxy}} class to allow removing individual histograms.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)