[jira] [Created] (FLINK-9582) dist assemblies access files outside of flink-dist

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-9582) dist assemblies access files outside of flink-dist

Shang Yuanchun (Jira)
Chesnay Schepler created FLINK-9582:
---------------------------------------

             Summary: dist assemblies access files outside of flink-dist
                 Key: FLINK-9582
                 URL: https://issues.apache.org/jira/browse/FLINK-9582
             Project: Flink
          Issue Type: Bug
          Components: Build System
    Affects Versions: 1.5.0, 1.6.0
            Reporter: Chesnay Schepler
            Assignee: Chesnay Schepler
             Fix For: 1.6.0


The flink-dist assemblies access compiled jars outside of flink-dist, for example like this:
{code:java}
<source>../flink-libraries/flink-cep/target/flink-cep_${scala.binary.version}-${project.version}.jar</source>{code}
As usual, accessing files outside of the module that you're building is a terrible idea.

It's brittle as it relies on paths that aren't guaranteed to be stable, and requires these modules to be built beforehand. There's also an inherent potential for dependency conflicts when building flink-dist on it's own, as maven may download certain snapshot artifacts, but the assemblies ignore these and bundle jars present in Flink.

We can use the maven-dependency plugin to copy required dependencies into the {{target}} directory of flink-dist, and point the assemblies to these jars.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)