[jira] [Created] (FLINK-6493) Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-6493) Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()

Shang Yuanchun (Jira)
Ted Yu created FLINK-6493:
-----------------------------

             Summary: Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()
                 Key: FLINK-6493
                 URL: https://issues.apache.org/jira/browse/FLINK-6493
             Project: Flink
          Issue Type: Bug
            Reporter: Ted Yu
            Priority: Minor


{code}
        && ((partitionStateSerializer == null && ((Snapshot) obj).getPartitionStateSerializer() == null)
          || partitionStateSerializer.equals(((Snapshot) obj).getPartitionStateSerializer()))
        && ((partitionStateSerializerConfigSnapshot == null && ((Snapshot) obj).getPartitionStateSerializerConfigSnapshot() == null)
          || partitionStateSerializerConfigSnapshot.equals(((Snapshot) obj).getPartitionStateSerializerConfigSnapshot()));
{code}
The null check for partitionStateSerializer / partitionStateSerializerConfigSnapshot is in combination with another clause.

This may lead to NPE in the partitionStateSerializer.equals() call.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)