[jira] [Created] (FLINK-4053) Return value from Connection should be checked against null

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-4053) Return value from Connection should be checked against null

Shang Yuanchun (Jira)
Ted Yu created FLINK-4053:
-----------------------------

             Summary: Return value from Connection should be checked against null
                 Key: FLINK-4053
                 URL: https://issues.apache.org/jira/browse/FLINK-4053
             Project: Flink
          Issue Type: Bug
            Reporter: Ted Yu
            Priority: Minor


In RMQSource.java and RMQSink.java, there is code in the following pattern:
{code}
      connection = factory.newConnection();
      channel = connection.createChannel();
{code}
According to https://www.rabbitmq.com/releases/rabbitmq-java-client/current-javadoc/com/rabbitmq/client/Connection.html#createChannel() :
{code}
Returns:
a new channel descriptor, or null if none is available
{code}
The return value should be checked against null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)