[jira] [Created] (FLINK-3461) Remove duplicate condition check in ZooKeeperLeaderElectionService

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-3461) Remove duplicate condition check in ZooKeeperLeaderElectionService

Shang Yuanchun (Jira)
Ufuk Celebi created FLINK-3461:
----------------------------------

             Summary: Remove duplicate condition check in ZooKeeperLeaderElectionService
                 Key: FLINK-3461
                 URL: https://issues.apache.org/jira/browse/FLINK-3461
             Project: Flink
          Issue Type: Improvement
            Reporter: Ufuk Celebi
            Priority: Trivial


In {{ZooKeeperLeaderElectionService}}:
{code}
@Override
public boolean hasLeadership() {
  if(leaderLatch.getState().equals(LeaderLatch.State.STARTED)) {
    return leaderLatch.hasLeadership();
  } else {
    return false;
  }
}
{code}

Looking into the leader {{leaderLatch.hasLeadership()}}, the state gets checked already/again.
{code}
return (state.get() == State.STARTED) && hasLeadership.get();
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)