[jira] [Created] (FLINK-3301) Ineffective synchronization in MessageAcknowledgingSourceBase#restoreState

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-3301) Ineffective synchronization in MessageAcknowledgingSourceBase#restoreState

Shang Yuanchun (Jira)
Ted Yu created FLINK-3301:
-----------------------------

             Summary: Ineffective synchronization in MessageAcknowledgingSourceBase#restoreState
                 Key: FLINK-3301
                 URL: https://issues.apache.org/jira/browse/FLINK-3301
             Project: Flink
          Issue Type: Bug
            Reporter: Ted Yu


Here is related code:
{code}
  public void restoreState(SerializedCheckpointData[] state) throws Exception {
    synchronized (pendingCheckpoints) {
      pendingCheckpoints = SerializedCheckpointData.toDeque(state, idSerializer);
{code}
When lock is held on current pendingCheckpoints field, new reference is assigned to the same field - making the synchronization ineffective.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)