[jira] [Created] (FLINK-2395) Check Scala catch blocks for Throwable

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-2395) Check Scala catch blocks for Throwable

Shang Yuanchun (Jira)
Till Rohrmann created FLINK-2395:
------------------------------------

             Summary: Check Scala catch blocks for Throwable
                 Key: FLINK-2395
                 URL: https://issues.apache.org/jira/browse/FLINK-2395
             Project: Flink
          Issue Type: Improvement
            Reporter: Till Rohrmann
            Priority: Minor


As described in [1], it's not a good practice to catch {{Throwables}} in Scala catch blocks because Scala uses some special exceptions for the control flow. Therefore we should check whether we can restrict ourselves to only catching subtypes of {{Throwable}}, such as {{Exception}}, instead.

[1] https://www.sumologic.com/2014/05/05/why-you-should-never-catch-throwable-in-scala/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)