[jira] [Created] (FLINK-2369) On Windows, in testFailingSortingDataSinkTask the temp file is not removed

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-2369) On Windows, in testFailingSortingDataSinkTask the temp file is not removed

Shang Yuanchun (Jira)
Gabor Gevay created FLINK-2369:
----------------------------------

             Summary: On Windows, in testFailingSortingDataSinkTask the temp file is not removed
                 Key: FLINK-2369
                 URL: https://issues.apache.org/jira/browse/FLINK-2369
             Project: Flink
          Issue Type: Bug
          Components: Distributed Runtime
         Environment: Windows 7 64-bit, JDK 8u51
            Reporter: Gabor Gevay
            Assignee: Gabor Gevay
            Priority: Minor


The test fails with the assert at the very end ("Temp output file has not been removed"). This happens because FileOutputFormat.tryCleanupOnError can't delete the file, because it is still open (note, that Linux happily deletes open files).

A fix would be to have the  this.format.close();  not just in the finally block (in DataSinkTask.invoke), but also before the tryCleanupOnError call (around line 217).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)