[jira] [Created] (FLINK-22725) SlotManagers should unregister metrics at the start of suspend()

[Shang Yuanchun (Jira)]

Chesnay Schepler created FLINK-22725:
----------------------------------------

             Summary: SlotManagers should unregister metrics at the start of suspend()
                 Key: FLINK-22725
                 URL: https://issues.apache.org/jira/browse/FLINK-22725
             Project: Flink
          Issue Type: Improvement
          Components: Runtime / Coordination, Runtime / Metrics
    Affects Versions: 1.13.0
            Reporter: Chesnay Schepler
            Assignee: Chesnay Schepler
             Fix For: 1.14.0, 1.13.1


Slotmanagers register metrics in start(), but only unregister them in close().

This has 2 issues:

a) If the SM is restarted it cannot re-register the metrics because the old ones are still present; this isn't a critical problem (because the old ones still work) but it produces unnecesasry logging noise

b) The metric may produce an NPE when accessed by a reporter during suspend().



--
This message was sent by Atlassian Jira
(v8.3.4#803005)