[jira] [Created] (FLINK-22514) TypeExtractor - Improving log message

[Shang Yuanchun (Jira)]

Avishay Balderman created FLINK-22514:
-----------------------------------------

             Summary: TypeExtractor - Improving log message
                 Key: FLINK-22514
                 URL: https://issues.apache.org/jira/browse/FLINK-22514
             Project: Flink
          Issue Type: Improvement
          Components: API / DataStream
            Reporter: Avishay Balderman


org.apache.flink.api.java.typeutils.TypeExtractor is checking if a field in a class is a "valid POJO field" .

The method that is responsible for this is:  
{code:java}
isValidPojoField{code}
When isValidPojoField find an invalid field a log message is written (see below) but the log message does not tell which field is invalid...

So now the developer needs to find out the "bad" field.

Adding the field info to the log message is easy and save the developer time.

 

 
{code:java}
for (Field field : fields) {
   Type fieldType = field.getGenericType();
   if(!isValidPojoField(field, clazz, typeHierarchy) && clazz != Row.class) {
      LOG.info("Class " + clazz + " cannot be used as a POJO type because not all fields are valid POJO fields, " +
         "and must be processed as GenericType. Please read the Flink documentation " +
         "on \"Data Types & Serialization\" for details of the effect on performance.");
      return null;
   }
{code}
 

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)