[jira] [Created] (FLINK-21696) scala code in "Writing WatermarkGenerators" documentation missing/deprecated

[Shang Yuanchun (Jira)]

Giacomo Gamba created FLINK-21696:
-------------------------------------

             Summary: scala code in "Writing WatermarkGenerators" documentation missing/deprecated
                 Key: FLINK-21696
                 URL: https://issues.apache.org/jira/browse/FLINK-21696
             Project: Flink
          Issue Type: Improvement
          Components: Documentation
            Reporter: Giacomo Gamba


Hi all,

I belive the scala code in the "Writing a Periodic WatermarkGenerator" and "Writing a Punctuated WatermarkGenerator" sections (Event Time -> Generatin Watermark) is outdated/wrong.

It still show how to extend the deprecated {{AssignerWithPunctuatedWatermarks}} and {{AssignerWithPeriodicWatermarks}} classes. Moreover it uses undefined arguements ({{output}}) (not sure if this was working before, I'm pretty new to Flink).

If it's alright I can put up a PR with the scala code on how to extend {{WatermarkGenerator}} class and some comment.

Also sorry if I misplaced this Issue, feel free to improve/correct

Giack



--
This message was sent by Atlassian Jira
(v8.3.4#803005)