[jira] [Created] (FLINK-20108) SingleThreadFetcherManager may add splits to a shutting down SplitFetcher

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-20108) SingleThreadFetcherManager may add splits to a shutting down SplitFetcher

Shang Yuanchun (Jira)
Jiangjie Qin created FLINK-20108:
------------------------------------

             Summary: SingleThreadFetcherManager may add splits to a shutting down SplitFetcher
                 Key: FLINK-20108
                 URL: https://issues.apache.org/jira/browse/FLINK-20108
             Project: Flink
          Issue Type: Bug
          Components: Connectors / Common
    Affects Versions: 1.11.2
            Reporter: Jiangjie Qin


Currently the split fetchers are only removed from the {{SplitFetcherManager.fetchers}} when the thread exit. The may cause problem because when {{SplitFetcherManager.addSplits()}} is called, it may see a shutting down split fetcher and adds splits to it. These splits will then just be lost.

The fix is to make {{SplitFetcherManager.fetchers}} field private and introduce a protected {{addSplitsToFetcher(Splits, fetcherId)}} method. That method will ensure the splits won't be assigned to a shutting down split fetcher instead of a new fetcher.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)