[jira] [Created] (FLINK-19320) Remove clearBuffers from the public interfaces of RecordWriter

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-19320) Remove clearBuffers from the public interfaces of RecordWriter

Shang Yuanchun (Jira)
Yingjie Cao created FLINK-19320:
-----------------------------------

             Summary: Remove clearBuffers from the public interfaces of RecordWriter
                 Key: FLINK-19320
                 URL: https://issues.apache.org/jira/browse/FLINK-19320
             Project: Flink
          Issue Type: Sub-task
          Components: Runtime / Task
            Reporter: Yingjie Cao
             Fix For: 1.12.0


Currently, RecordWriter#clearBuffers is only used to finish the current BufferBuilder and it does not clear buffers any more. Previously, it was used to recycle the partially filled buffer in the serializer but currently the serializer does not contains any network buffer any more.

For now, only some tests and DataSet classes use it and all of these usage should be replaced by RecordWriter#close which dose the same thing. Besides, for FLINK-19297, we do not want to keep this method in the new ResultPartitionWriter Interface. So in this ticket, we propose to remove clearBuffers from the public interfaces of RecordWriter.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)