[jira] [Created] (FLINK-19175) Tests in JoinITCase do not test BroadcastHashJoin

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-19175) Tests in JoinITCase do not test BroadcastHashJoin

Shang Yuanchun (Jira)
Dawid Wysakowicz created FLINK-19175:
----------------------------------------

             Summary: Tests in JoinITCase do not test BroadcastHashJoin
                 Key: FLINK-19175
                 URL: https://issues.apache.org/jira/browse/FLINK-19175
             Project: Flink
          Issue Type: Bug
          Components: Table SQL / Planner, Tests
            Reporter: Dawid Wysakowicz


The tests in JoinITCase claim to test the {{BroadcastHashJoin}}, but they actually do not. None of the tables used in the tests have proper statistics therefore, none of the tables meet the threshold for the broadcast join. At the same time the {{ShuffleHashJoin}} is not disabled, therefore they silently fallback to {{ShuffleHashJoin}}.

In summary none (or at least not all of the tests) are executed for BroadcastHashJoin, but are executed twice for ShuffleHashJoin.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)