[jira] [Created] (FLINK-18711) Trim the blank space for TableOptions

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-18711) Trim the blank space for TableOptions

Shang Yuanchun (Jira)
hailong wang created FLINK-18711:
------------------------------------

             Summary: Trim the blank space for TableOptions
                 Key: FLINK-18711
                 URL: https://issues.apache.org/jira/browse/FLINK-18711
             Project: Flink
          Issue Type: Improvement
          Components: Table SQL / Planner
    Affects Versions: 1.11.0
            Reporter: hailong wang
             Fix For: 1.12.0


If ddl table options have space before or after key or value, it will fail to create table source.

For example,
{code:java}
"CREATE TABLE " + INPUT_TABLE + "(" +
   "id BIGINT," +
   "timestamp6_col TIMESTAMP(6)," +
   "timestamp9_col TIMESTAMP(9)," +
   "time_col TIME," +
   "real_col FLOAT," +
   "double_col DOUBLE," +
   "decimal_col DECIMAL(10, 4)" +
   ") WITH (" +
   "  'connector'=' jdbc'," +
   "  'url '='" + DB_URL + "'," +
   "  'table-name'='" + INPUT_TABLE + "'" +
   ")"
{code}
If there have blank space before jdbc or blank space after url, it will fail.
I think If we can trim it, will be better for users.
My idea is we can just trim keys and values on MergeTableLikeUtil#mergeOptions
 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)