[jira] [Created] (FLINK-17532) Update tests to use BatchTestBase#checkTableResult

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-17532) Update tests to use BatchTestBase#checkTableResult

Shang Yuanchun (Jira)
Timo Walther created FLINK-17532:
------------------------------------

             Summary: Update tests to use BatchTestBase#checkTableResult
                 Key: FLINK-17532
                 URL: https://issues.apache.org/jira/browse/FLINK-17532
             Project: Flink
          Issue Type: Test
          Components: Table SQL / Planner
            Reporter: Timo Walther


Roughly 196 tests fail if we change the `Row.toString`. In the legacy planner, we will fix this quickly using some util. However, for the long-term Blink planner we should update those test to use the test bases and compare against instances instead of string.

Similar to:

{code}
    checkResult(
      "SELECT j, sum(k) FROM GenericTypedTable3 GROUP BY i, j",
      Seq(
        row(row(1, 1), 2),
        row(row(1, 1), 2),
        row(row(10, 1), 3)
      )
    )
{code}

Affected tests:
{code}
AggregateITCaseBase
PartitionableSinkITCase
CalcITCase
JoinITCase
SortITCase
CorrelateITCase
TableSinkITCase
AggregationITCase
GroupWindowITCase
SetOperatorsITCase
CalcITCase
UnnestITCase
AggregateRemoveITCase
PruneAggregateCallITCase
CalcITCase
CorrelateITCase
TableSinkITCase
SetOperatorsITCase
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)