[jira] [Created] (FLINK-17503) Make memory configuration logging more user-friendly

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-17503) Make memory configuration logging more user-friendly

Shang Yuanchun (Jira)
Till Rohrmann created FLINK-17503:
-------------------------------------

             Summary: Make memory configuration logging more user-friendly
                 Key: FLINK-17503
                 URL: https://issues.apache.org/jira/browse/FLINK-17503
             Project: Flink
          Issue Type: Improvement
          Components: Runtime / Coordination
    Affects Versions: 1.10.0
            Reporter: Till Rohrmann
             Fix For: 1.11.0, 1.10.2


The newly introduced memory configuration logs some output:

{code}
2020-05-04 11:50:05,984 INFO  org.apache.flink.runtime.taskexecutor.TaskExecutorResourceUtils [] - The configuration option Key: 'taskmanager.cpu.cores' , default: null (fallback keys: []) required for local execution is not set, setting it to its default value 1.7976931348623157E308
2020-05-04 11:50:05,989 INFO  org.apache.flink.runtime.taskexecutor.TaskExecutorResourceUtils [] - The configuration option Key: 'taskmanager.memory.task.heap.size' , default: null (fallback keys: []) required for local execution is not set, setting it to its default value 9223372036854775807 bytes
2020-05-04 11:50:05,989 INFO  org.apache.flink.runtime.taskexecutor.TaskExecutorResourceUtils [] - The configuration option Key: 'taskmanager.memory.task.off-heap.size' , default: 0 bytes (fallback keys: []) required for local execution is not set, setting it to its default value 9223372036854775807 bytes
2020-05-04 11:50:05,990 INFO  org.apache.flink.runtime.taskexecutor.TaskExecutorResourceUtils [] - The configuration option Key: 'taskmanager.memory.network.min' , default: 64 mb (fallback keys: [{key=taskmanager.network.memory.min, isDeprecated=true}]) required for local execution is not set, setting it to its default value 64 mb
2020-05-04 11:50:05,990 INFO  org.apache.flink.runtime.taskexecutor.TaskExecutorResourceUtils [] - The configuration option Key: 'taskmanager.memory.network.max' , default: 1 gb (fallback keys: [{key=taskmanager.network.memory.max, isDeprecated=true}]) required for local execution is not set, setting it to its default value 64 mb
2020-05-04 11:50:05,991 INFO  org.apache.flink.runtime.taskexecutor.TaskExecutorResourceUtils [] - The configuration option Key: 'taskmanager.memory.managed.size' , default: null (fallback keys: [{key=taskmanager.memory.size, isDeprecated=true}]) required for local execution is not set, setting it to its default value 128 mb
{code}

This logging output could be made more user-friendly the following way:

* Print only the key string of a {{ConfigOption}}, not the config option object with all the deprecated keys
* Skipping the lines for {{taskmanager.memory.task.heap.size}} and {{taskmanager.memory.task.off-heap.size}} - we don't really set them (they are JVM paramaters) and the printing of long max looks strange (user would have to know these are place holders without effect).
* Maybe similarly skipping the CPU cores value, this looks the strangest (double max).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)