[jira] [Created] (FLINK-17187) Streamline setting of config options

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-17187) Streamline setting of config options

Shang Yuanchun (Jira)
Chesnay Schepler created FLINK-17187:
----------------------------------------

             Summary: Streamline setting of config options
                 Key: FLINK-17187
                 URL: https://issues.apache.org/jira/browse/FLINK-17187
             Project: Flink
          Issue Type: Improvement
          Components: Dockerfiles
            Reporter: Chesnay Schepler
            Assignee: Chesnay Schepler
             Fix For: 1.11.0


The docker-entrypoint.sh has some verbose sections for setting config options with lots of duplicated logic. We should introduce a utility method for setting config options.

 
{code:java}
if grep -E "^jobmanager\.rpc\.address:.*" "${CONF_FILE}" > /dev/null; then
    sed -i -e "s/jobmanager\.rpc\.address:.*/jobmanager.rpc.address: ${JOB_MANAGER_RPC_ADDRESS}/g" "${CONF_FILE}"
else
    echo "jobmanager.rpc.address: ${JOB_MANAGER_RPC_ADDRESS}" >> "${CONF_FILE}"
fiif grep -E "^blob\.server\.port:.*" "${CONF_FILE}" > /dev/null; then
    sed -i -e "s/blob\.server\.port:.*/blob.server.port: 6124/g" "${CONF_FILE}"
else
    echo "blob.server.port: 6124" >> "${CONF_FILE}"
fi
...{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)