[jira] [Created] (FLINK-17049) Support implicit conversions in nested rows

[Shang Yuanchun (Jira)]

Dawid Wysakowicz created FLINK-17049:
----------------------------------------

             Summary: Support implicit conversions in nested rows
                 Key: FLINK-17049
                 URL: https://issues.apache.org/jira/browse/FLINK-17049
             Project: Flink
          Issue Type: Sub-task
            Reporter: Dawid Wysakowicz


{code}
        @Test
        public void testCastRowTableFunction() throws Exception {
                final List<Row> sourceData = Arrays.asList(
                        Row.of(Row.of(1))
                );

                final List<Row> sinkData = Arrays.asList(
                        Row.of(Row.of(new BigDecimal("1")))
                );

                TestCollectionTableFactory.reset();
                TestCollectionTableFactory.initData(sourceData);

                tEnv().sqlUpdate("CREATE TABLE SourceTable(s Row(a INT)) WITH ('connector' = 'COLLECTION')");
                tEnv().sqlUpdate("CREATE TABLE SinkTable(s ROW(a DECIMAL(10, 2))) WITH ('connector' = 'COLLECTION')");

                tEnv().createTemporarySystemFunction("func", RowCastScalarFunction.class);
                tEnv().sqlUpdate("INSERT INTO SinkTable SELECT func(s) FROM SourceTable");
                tEnv().execute("Test Job");

                assertThat(TestCollectionTableFactory.getResult(), equalTo(sinkData));
        }

        public static class RowCastScalarFunction extends ScalarFunction {
                public @DataTypeHint("ROW<f0 INT>") Row eval(
                        @DataTypeHint("ROW<f0 DECIMAL(10, 2)>") Row row) {
                        return Row.of(1);
                }
        }
{code}

fails with:

{code}
java.lang.AssertionError: use createStructType() instead

        at org.apache.calcite.sql.type.SqlTypeFactoryImpl.assertBasic(SqlTypeFactoryImpl.java:225)
        at org.apache.calcite.sql.type.SqlTypeFactoryImpl.createSqlType(SqlTypeFactoryImpl.java:48)
        at org.apache.flink.table.planner.calcite.FlinkTypeFactory.createSqlType(FlinkTypeFactory.scala:275)
        at org.apache.calcite.sql.SqlBasicTypeNameSpec.deriveType(SqlBasicTypeNameSpec.java:205)
        at org.apache.calcite.sql.SqlDataTypeSpec.deriveType(SqlDataTypeSpec.java:222)
        at org.apache.calcite.sql.SqlDataTypeSpec.deriveType(SqlDataTypeSpec.java:209)
        at org.apache.calcite.sql.validate.SqlValidatorImpl$DeriveTypeVisitor.visit(SqlValidatorImpl.java:5960)
        at org.apache.calcite.sql.validate.SqlValidatorImpl$DeriveTypeVisitor.visit(SqlValidatorImpl.java:5845)
        at org.apache.calcite.sql.SqlDataTypeSpec.accept(SqlDataTypeSpec.java:186)
        at org.apache.calcite.sql.validate.SqlValidatorImpl.deriveTypeImpl(SqlValidatorImpl.java:1800)
        at org.apache.calcite.sql.validate.SqlValidatorImpl.deriveType(SqlValidatorImpl.java:1785)
        at org.apache.calcite.sql.SqlNode.validateExpr(SqlNode.java:260)
        at org.apache.calcite.sql.SqlOperator.validateCall(SqlOperator.java:423)
        at org.apache.calcite.sql.SqlFunction.validateCall(SqlFunction.java:199)
        at org.apache.calcite.sql.validate.SqlValidatorImpl.validateCall(SqlValidatorImpl.java:5552)
        at org.apache.calcite.sql.SqlCall.validate(SqlCall.java:116)
        at org.apache.calcite.sql.SqlNode.validateExpr(SqlNode.java:259)
        at org.apache.calcite.sql.SqlOperator.validateCall(SqlOperator.java:423)
        at org.apache.calcite.sql.SqlFunction.validateCall(SqlFunction.java:199)
        at org.apache.calcite.sql.validate.SqlValidatorImpl.validateCall(SqlValidatorImpl.java:5552)
        at org.apache.calcite.sql.SqlCall.validate(SqlCall.java:116)
        at org.apache.calcite.sql.SqlNode.validateExpr(SqlNode.java:259)
        at org.apache.calcite.sql.validate.SqlValidatorImpl.validateExpr(SqlValidatorImpl.java:4306)
        at org.apache.calcite.sql.validate.SqlValidatorImpl.validateSelectList(SqlValidatorImpl.java:4284)
        at org.apache.calcite.sql.validate.SqlValidatorImpl.validateSelect(SqlValidatorImpl.java:3523)
        at org.apache.calcite.sql.validate.SelectNamespace.validateImpl(SelectNamespace.java:60)
        at org.apache.calcite.sql.validate.AbstractNamespace.validate(AbstractNamespace.java:84)
        at org.apache.calcite.sql.validate.SqlValidatorImpl.validateNamespace(SqlValidatorImpl.java:1110)
        at org.apache.calcite.sql.validate.SqlValidatorImpl.validateQuery(SqlValidatorImpl.java:1084)
        at org.apache.calcite.sql.SqlSelect.validate(SqlSelect.java:232)
        at org.apache.calcite.sql.validate.SqlValidatorImpl.validateScopedExpression(SqlValidatorImpl.java:1059)
        at org.apache.calcite.sql.validate.SqlValidatorImpl.validate(SqlValidatorImpl.java:766)
        at org.apache.flink.table.planner.calcite.FlinkPlannerImpl.org$apache$flink$table$planner$calcite$FlinkPlannerImpl$$validate(FlinkPlannerImpl.scala:128)
        at org.apache.flink.table.planner.calcite.FlinkPlannerImpl.validate(FlinkPlannerImpl.scala:107)
        at org.apache.flink.table.planner.operations.SqlToOperationConverter.convert(SqlToOperationConverter.java:134)
        at org.apache.flink.table.planner.operations.SqlToOperationConverter.convertSqlInsert(SqlToOperationConverter.java:351)
        at org.apache.flink.table.planner.operations.SqlToOperationConverter.convert(SqlToOperationConverter.java:149)
        at org.apache.flink.table.planner.delegation.ParserImpl.parse(ParserImpl.java:66)
        at org.apache.flink.table.api.internal.TableEnvironmentImpl.sqlUpdate(TableEnvironmentImpl.java:596)
        at org.apache.flink.table.planner.runtime.stream.sql.FunctionITCase.testCastRowTableFunction(FunctionITCase.java:632)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
        at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
        at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:239)
        at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
        at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
        at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
        at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
        at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
        at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
        at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
        at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
        at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:230)
        at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at com.intellij.rt.execution.application.AppMainV2.main(AppMainV2.java:131)
{code}

I think the problem is in {{org.apache.flink.table.planner.functions.inference.TypeInferenceOperandChecker#castTo}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)