[jira] [Created] (FLINK-17036) Datadog forwarder does not allow for EU endpoint

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-17036) Datadog forwarder does not allow for EU endpoint

Shang Yuanchun (Jira)
Raymond Farrelly created FLINK-17036:
----------------------------------------

             Summary: Datadog forwarder does not allow for EU endpoint
                 Key: FLINK-17036
                 URL: https://issues.apache.org/jira/browse/FLINK-17036
             Project: Flink
          Issue Type: Bug
          Components: Runtime / Metrics
            Reporter: Raymond Farrelly


Essentially the FLINK integration does not work in the EU instance due to:

[https://github.com/apache/flink/blob/master/flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java#L45]

`.com` is hardcoded. Datadog has two endpoints `.com` and `.eu` both need to be accounted for or EU customers cannot use the integration. [https://docs.datadoghq.com/agent/basic_agent_usage/?tab=agentv6v7#datadog-site]

As a quick suggestion I put together a PR that would account for this. Please note I am not a software Engineer so this is very much a starting point.

I followed the below to ensure it builds:

```
git clone [https://github.com/apache/flink.git]
cd flink
mvn clean package -DskipTests # this will take up to 10 minutes```

Made some changes and did a rough build on this which was successful:
```
raymond.farrelly@RFM flink % mvn clean -pl :flink-metrics-datadog
...
[INFO]
[INFO] ---------------< org.apache.flink:flink-metrics-datadog >---------------
[INFO] Building flink-metrics-datadog 1.11-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @ flink-metrics-datadog ---
[INFO] Deleting /Users/raymond.farrelly/Documents/flink/flink-metrics/flink-metrics-datadog/target
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.292 s
[INFO] Finished at: 2020-04-02T18:06:18+01:00
[INFO] ------------------------------------------------------------------------
raymond.farrelly@RFM flink %
```



--
This message was sent by Atlassian Jira
(v8.3.4#803005)