[jira] [Created] (FLINK-16942) ES 5 sink should allows users to select netty transport client

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-16942) ES 5 sink should allows users to select netty transport client

Shang Yuanchun (Jira)
Chesnay Schepler created FLINK-16942:
----------------------------------------

             Summary: ES 5 sink should allows users to select netty transport client
                 Key: FLINK-16942
                 URL: https://issues.apache.org/jira/browse/FLINK-16942
             Project: Flink
          Issue Type: Improvement
          Components: Connectors / ElasticSearch
    Affects Versions: 1.10.0, 1.9.0, 1.11.0
            Reporter: Chesnay Schepler


When assembling the settings for the {{PreBuiltTransportClient}} the {{Elasticsearch5ApiCallBridge}} first adds the user-provided client and then overrides http/transport types with netty 3.

This means  that users are forced to use netty 3, despite the connector being able to work with a more recent and secure version.

{code:java}
Settings settings = Settings.builder().put(clientConfig)
        .put(NetworkModule.HTTP_TYPE_KEY, Netty3Plugin.NETTY_HTTP_TRANSPORT_NAME)
        .put(NetworkModule.TRANSPORT_TYPE_KEY, Netty3Plugin.NETTY_TRANSPORT_NAME)
        .build();
{code}

We should invert the order in which the settings are added.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)