[jira] [Created] (FLINK-16753) Exception from AsyncCheckpointRunnable should be wrapped in CheckpointException

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-16753) Exception from AsyncCheckpointRunnable should be wrapped in CheckpointException

Shang Yuanchun (Jira)
Jiayi Liao created FLINK-16753:
----------------------------------

             Summary: Exception from AsyncCheckpointRunnable should be wrapped in CheckpointException
                 Key: FLINK-16753
                 URL: https://issues.apache.org/jira/browse/FLINK-16753
             Project: Flink
          Issue Type: Improvement
    Affects Versions: 1.10.0
            Reporter: Jiayi Liao


If an exception is thrown when task is doing aysnc checkpoint, the checkpoint will be declined and regarded as {{CheckpointFailureReason.JOB_FAILURE}}, which gives a wrong message to users.

I think we can simply replace
{code:java}
owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(), checkpointException);
{code}

with
 
{code:java}
owner.getEnvironment().declineCheckpoint(checkpointMetaData.getCheckpointId(), new CheckpointException(CheckpointFailureReason.EXCEPTION, checkpointException));
{code}

cc [~trohrmann]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)