[jira] [Created] (FLINK-16221) Execution::transitionState() should log an error when error parameter is not null

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-16221) Execution::transitionState() should log an error when error parameter is not null

Shang Yuanchun (Jira)
yazgoo created FLINK-16221:
------------------------------

             Summary: Execution::transitionState() should log an error when error parameter is not null
                 Key: FLINK-16221
                 URL: https://issues.apache.org/jira/browse/FLINK-16221
             Project: Flink
          Issue Type: Improvement
          Components: Runtime / Coordination
    Affects Versions: 1.10.0, 1.9.2
            Reporter: yazgoo
         Attachments: info_to_error.patch

When execution state transitions with an error, an INFO is logged n Execution::transitionState().
I think an ERROR should be logged.
This is especially usefull when states transitions to failing, to be able to retrieve the error causing the failure.
So:
|LOG.error("{} ({}) switched from {} to {}.", getVertex().getTaskNameWithSubtaskIndex(), getAttemptId(), currentState, targetState, error);|


should become
|LOG.info("{} ({}) switched from {} to {}.", getVertex().getTaskNameWithSubtaskIndex(), getAttemptId(), currentState, targetState, error);|



--
This message was sent by Atlassian Jira
(v8.3.4#803005)