[jira] [Created] (FLINK-15859) Unify identifiers in the interface methods of CatalogManager

[Shang Yuanchun (Jira)]

Dawid Wysakowicz created FLINK-15859:
----------------------------------------

             Summary: Unify identifiers in the interface methods of CatalogManager
                 Key: FLINK-15859
                 URL: https://issues.apache.org/jira/browse/FLINK-15859
             Project: Flink
          Issue Type: Improvement
          Components: Table SQL / API
            Reporter: Dawid Wysakowicz
             Fix For: 1.11.0


We're not being too consistent with the type of identifier that the FunctionCatalog/CatalogManager accepts.

Some methods accept {{UnresolvedIdentifier}} e.g. {{FunctionCatalog#registerTemporaryCatalogFunction}}, {{CatalogManager#dropTemporaryView}}.

Some resolved {{ObjectIdentifier}} e.g. {{CatalogManager#createTemporaryTable}}, {{CatalogManager#createTable}}.

I am not sure which one should we prefer. If we go with the {{UnresolvedIdentifier}} the benefit is that we always qualify it in a {{Catalog*}}. The downside is that we would use {{UnresolvedIdentifier}} in {{*Operations}}, (e.g. {{CreateTableOperation}} etc.), whereas we said that all Operations should be fully resolved...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)