[jira] [Created] (FLINK-15307) Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-15307) Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy

Shang Yuanchun (Jira)
andrew.D.lin created FLINK-15307:
------------------------------------

             Summary: Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy
                 Key: FLINK-15307
                 URL: https://issues.apache.org/jira/browse/FLINK-15307
             Project: Flink
          Issue Type: Improvement
          Components: Runtime / Configuration
    Affects Versions: 1.9.1, 1.9.0, 1.10.0
            Reporter: andrew.D.lin
         Attachments: image-2019-12-18-14-59-03-181.png

Subclasses of RestartStrategy
 * FailingRestartStrategy
 * FailureRateRestartStrategy
 * FixedDelayRestartStrategy
 * InfiniteDelayRestartStrategy

Implementation class of FailoverStrategy
 * AdaptedRestartPipelinedRegionStrategyNG
 * RestartAllStrategy
 * RestartIndividualStrategy
 * RestartPipelinedRegionStrategy

 

FailoverStrategy describes how the job computation recovers from task failures.

I think the following names may be easier to understand and easier to distinguish:

Implementation class of FailoverStrategy
 * AdaptedPipelinedRegionFailoverStrategyNG
 * FailoverAllStrategy
 * FailoverIndividualStrategy
 * FailoverPipelinedRegionStrategy

FailoverStrategy is currently generated by configuration. If we change the name of the implementation class, it will not affect compatibility.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)