[jira] [Created] (FLINK-14962) FindBugs warnings: Inefficient use of keySet iterator instead of entrySet iterator

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-14962) FindBugs warnings: Inefficient use of keySet iterator instead of entrySet iterator

Shang Yuanchun (Jira)
Dezhi Cai created FLINK-14962:
---------------------------------

             Summary: FindBugs warnings: Inefficient use of keySet iterator instead of entrySet iterator
                 Key: FLINK-14962
                 URL: https://issues.apache.org/jira/browse/FLINK-14962
             Project: Flink
          Issue Type: Bug
          Components: Connectors / Common
    Affects Versions: 1.9.1, 1.9.0, 1.8.0
            Reporter: Dezhi Cai


FindBugs report WMI_WRONG_MAP_ITERATOR warnings on master.

related class : 

org.apache.flink.formats.parquet.ParquetMapInputFormat

org.apache.flink.graph.library.CommunityDetection

org.apache.flink.streaming.connectors.fs.bucketing.BucketingSink (already marked as "Deprecated")

 

 

The description of the bug is as follows:

*WMI: Inefficient use of keySet iterator instead of entrySet iterator (WMI_WRONG_MAP_ITERATOR)*
This method accesses the value of a Map entry, using a key that was retrieved from a keySet iterator. It is more efficient to use an iterator on the entrySet of the map, to avoid the Map.get(key) lookup.
[http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)