Yun Tang created FLINK-14654:
--------------------------------
Summary: Fix the arguments number mismatching with placeholders in log statements
Key: FLINK-14654
URL:
https://issues.apache.org/jira/browse/FLINK-14654 Project: Flink
Issue Type: Bug
Affects Versions: 1.9.1
Reporter: Yun Tang
Fix For: 1.10.0
As official Flink [java code style|
https://flink.apache.org/contributing/code-style-and-quality-java.html#preconditions-and-log-statements] suggested, we should use correct log statement format. However, there existed 13 files within current master branch that the arguments number mismatch with placeholders in log statements.
The error looks like:
{code:java}
LOG.warn("Failed to read native metric %s from RocksDB", property, e);
{code}
and the correct format should be
{code:java}
LOG.warn("Failed to read native metric {} from RocksDB.", property, e);
{code}
The other errors look like
{code:java}
LOG.warn("Could not find method implementations in the shaded jar. Exception: {}", e);
{code}
and the correct format should be
{code:java}
LOG.warn("Could not find method implementations in the shaded jar.", e);
{code}
Below is the full list of files have problems in log statements.
{code:java}
flink-contrib/flink-connector-wikiedits/src/main/java/org/apache/flink/streaming/connectors/wikiedits/WikipediaEditEventIrcStream.java
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/PipelineErrorHandler.java
flink-runtime/src/main/java/org/apache/flink/runtime/security/modules/HadoopModule.java
flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetPojoInputFormat.java
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/values/ValuesInputFormat.java
flink-end-to-end-tests/flink-connector-gcp-pubsub-emulator-tests/src/test/java/org/apache/flink/streaming/connectors/gcp/pubsub/emulator/GCloudEmulatorManager.java
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironmentImpl.java
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/ReporterSetup.java
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricMonitor.java{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Locked
