[jira] [Created] (FLINK-14438) Fix RowTypeInfo.equals()

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-14438) Fix RowTypeInfo.equals()

Shang Yuanchun (Jira)
Timo Walther created FLINK-14438:
------------------------------------

             Summary: Fix RowTypeInfo.equals()
                 Key: FLINK-14438
                 URL: https://issues.apache.org/jira/browse/FLINK-14438
             Project: Flink
          Issue Type: Improvement
          Components: API / Type Serialization System
            Reporter: Timo Walther


As discussed in FLINK-12848, the {{equals}} method of {{RowTypeInfo}} causes confusion because it does not consider field names which makes it difficult to use the type in data structures (such as hash maps) or testing.

So far {{RowTypeInfo}} is marked as  {{@PublicEvolving}}. However, it is not feasible to perform changes to {{RowTypeInfo.equals()}} in the current code base. The number of affected tests (>80) shows that this change is not trivial and would affect the stability of the legacy planner. However, most of the failing tests are in the legacy planner. It seems the Blink code has no problems with this change which is great! We suggest to apply the changes once we drop the legacy planner.





--
This message was sent by Atlassian Jira
(v8.3.4#803005)