[jira] [Created] (FLINK-14174) Don't swallow exception when rethrowing type mismatches with side outputs

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-14174) Don't swallow exception when rethrowing type mismatches with side outputs

Shang Yuanchun (Jira)
John Lonergan created FLINK-14174:
-------------------------------------

             Summary: Don't swallow exception when rethrowing type mismatches with side outputs
                 Key: FLINK-14174
                 URL: https://issues.apache.org/jira/browse/FLINK-14174
             Project: Flink
          Issue Type: Improvement
          Components: API / DataStream
    Affects Versions: 1.9.0, 1.8.1
            Reporter: John Lonergan


The change made by https://github.com/apache/flink/pull/4663/files swallows the original exception.

Whilst I am in favour of adding additional helpful tips (which was the purpose of FLINK-4663) I don't agree with throwing away or masking causal exceptions.

IMHO the correct approach is to add the helpful hint as the first arg to "new ExceptionInChainedOperatorException(msg, ex)" and pass the original class cast ex as the cause.

Ie change this .. https://github.com/apache/flink/blob/master/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java#L672




--
This message was sent by Atlassian Jira
(v8.3.4#803005)