[jira] [Created] (FLINK-14159) flink rocksdb StreamCompressionDecorator not right

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-14159) flink rocksdb StreamCompressionDecorator not right

Shang Yuanchun (Jira)
jackylau created FLINK-14159:
--------------------------------

             Summary: flink rocksdb StreamCompressionDecorator not right
                 Key: FLINK-14159
                 URL: https://issues.apache.org/jira/browse/FLINK-14159
             Project: Flink
          Issue Type: Bug
          Components: Runtime / State Backends
    Affects Versions: 1.9.0
            Reporter: jackylau
             Fix For: 1.10.0


I think the current flink rocksdb StreamCompressionDecorator is not right calling method 

getCompressionDecorator(executionConfig) which defalut value is false.That is to say, current compression is none.But I find rocksdb  using {{options.compression}} to specify the compression to use. By default it is Snappy, which you can see here [https://github.com/facebook/rocksdb/wiki/RocksDB-Tuning-Guide]. And I use rocksdb tool sstdump to find it is indeed snappy compression.

So I think it should be return SnappyStreamCompressionDecorator.INSTANCE  rather than getCompressionDecorator( executionConfig) 

Coud i commit a PR?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)