[jira] [Created] (FLINK-14065) Log metric name when the metric fails on registration/unregistration

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-14065) Log metric name when the metric fails on registration/unregistration

Shang Yuanchun (Jira)
Zhilong Hong created FLINK-14065:
------------------------------------

             Summary: Log metric name when the metric fails on registration/unregistration
                 Key: FLINK-14065
                 URL: https://issues.apache.org/jira/browse/FLINK-14065
             Project: Flink
          Issue Type: Improvement
          Components: Runtime / Metrics
    Affects Versions: 1.9.0
            Reporter: Zhilong Hong
             Fix For: 1.10.0


When MetricGroup registers Metrics in MetricRegistryImpl, sometimes the registration fails due to exceptions. However, currently it only logsĀ {{"Error while registering metric" }}with no more information, which isĀ inconvenient for users to troubleshoot which metric fails and why it fails.

Also, the warning log in registration and unregistration are both "{{Error while registering metric}}". This will lead users to confusion (although users can locate the correct place according to the call stack).

So I propose to log metric name when the metrics fails on registration/unregistration.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)